[Geoserver-devel] [Vote] for integration JSON-FeatureCount into stable version

Hi GeoServer-developers,

I think I have formulated my last mail wrong. I would really like the JSON-FeatureCount extension to be integrated into the stable version. Andrea Aime told me that for this a vote in the GeoServer-developer-mailing list is neccessary.

So what do you think? Is it ok to integrate the extension into the stable version? It is a rather small extension and it is tested.

I would be very happy to receive positive comments.

Best regards

Paul

Von: Biskup, Paul
Gesendet: Montag, 21. Oktober 2013 10:33
An: ‘geoserver-devel@lists.sourceforge.net’
Betreff: Integrate JSON-FeatureCount into stable version

Hi GeoServer-developers,

i have developed a small extension, which outputs the feature count in a wfs-getFeature-request.

Andrea Aime has already merged it with the main GeoServer-code.

Could anyone of you please integrate this feature into the stable version of GeoServer?

This is the original mail from the mailing list: http://osgeo-org.1560.x6.nabble.com/JSON-output-total-number-of-features-for-paging-td5035093.html

Jira-ticket: http://jira.codehaus.org/browse/GEOS-6088

GIT-pull request: https://github.com/geoserver/geoserver/pull/267

Thanks in advance!

Best regards
Paul

On Tue, Oct 29, 2013 at 8:55 AM, Biskup, Paul
<Paul.Biskup@anonymised.com>wrote:

Hi GeoServer-developers,

I think I have formulated my last mail wrong. I would really like the
JSON-FeatureCount extension to be integrated into the stable version.
Andrea Aime told me that for this a vote in the GeoServer-developer-mailing
list is neccessary.

So what do you think? Is it ok to integrate the extension into the stable
version? It is a rather small extension and it is tested.

I'm good with the backport, mind, it will have to contain also my bug fix,
your original patch broke the build.

One thing to clarify is that the totalCount attribute that is being added
is the number of features matched, not
the number of features returned.
That's also why it has separate code paths for WFS 2.0 (where GetFeature
computes the total matched already)
and WFS 1.0/1.1, where the count has to be setup separately since all we
have at the collection level
is the count of features returned.

I would be very happy to receive positive comments.

Not very polite to ask for positive comments, leave people to comment
positively or negatively as they see fit

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

This transmission is intended for the named addressee(s) only and may contain sensitive or protectively marked material up to RESTRICTED and should be handled accordingly. Unless you are the named addressee (or authorised to receive it for the addressee) you may not copy or use it, or disclose it to anyone else. If you have received this transmission in error please notify the sender immediately. All email traffic sent to or from us, including without limitation all GCSX traffic, may be subject to recording and/or monitoring in accordance with relevant legislation.

···

I took that as reading he didn’t want comments like:

“Well this is rubbish”

But instead was asking for comments in the form of constructive criticism.

Of course, this is one of the better mailing lists and the “negative” comments are still constructive, so not necessary here, but Paul may not have known that.

Cheers,
Jonathan

I would be very happy to receive positive comments.

Not very polite to ask for positive comments, leave people to comment positively or negatively as they see fit

Hey all,

this was my first contribution and I just wanted to get some feedback :slight_smile: So sorry if have expressed myself wrong. I still have to learn the rules…

Cheers
Paul

Von: Jonathan Moules [mailto:jonathanmoules@anonymised.com]
Gesendet: Montag, 4. November 2013 12:18
An: Andrea Aime
Cc: Biskup, Paul; Geoserver-devel
Betreff: Re: [Geoserver-devel] [Vote] for integration JSON-FeatureCount into stable version

I would be very happy to receive positive comments.

Not very polite to ask for positive comments, leave people to comment positively or negatively as they see fit

I took that as reading he didn’t want comments like:

“Well this is rubbish”

But instead was asking for comments in the form of constructive criticism.

Of course, this is one of the better mailing lists and the “negative” comments are still constructive, so not necessary here, but Paul may not have known that.

Cheers,

Jonathan

This transmission is intended for the named addressee(s) only and may contain sensitive or protectively marked material up to RESTRICTED and should be handled accordingly. Unless you are the named addressee (or authorised to receive it for the addressee) you may not copy or use it, or disclose it to anyone else. If you have received this transmission in error please notify the sender immediately. All email traffic sent to or from us, including without limitation all GCSX traffic, may be subject to recording and/or monitoring in accordance with relevant legislation.

On 03/11/13 22:51, Andrea Aime wrote:

On Tue, Oct 29, 2013 at 8:55 AM, Biskup, Paul
<Paul.Biskup@anonymised.com <mailto:Paul.Biskup@anonymised.com>> wrote:
    I would be very happy to receive positive comments.
Not very polite to ask for positive comments, leave people to comment
positively or negatively as they see fit

I think Paul meant "constructive comments".

Kind regards,

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

Welcome, Paul. We appreciate your contribution. You have also discovered that our finest developers have great attention to detail. :slight_smile:

On 06/11/13 00:01, Biskup, Paul wrote:

Hey all,

this was my first contribution and I just wanted to get some feedback
:slight_smile: So sorry if have expressed myself wrong. I still have to learn the
rules…

Cheers
Paul

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

On Tue, Oct 29, 2013 at 8:55 AM, Biskup, Paul
<Paul.Biskup@anonymised.com>wrote:

Hi GeoServer-developers,

I think I have formulated my last mail wrong. I would really like the
JSON-FeatureCount extension to be integrated into the stable version.
Andrea Aime told me that for this a vote in the GeoServer-developer-mailing
list is neccessary.

So what do you think? Is it ok to integrate the extension into the stable
version? It is a rather small extension and it is tested.

I would be very happy to receive positive comments.

Well, +1 here. Haven't seen negative votes and the request has been up for
10 days now, so I'm going to backport
it during the weekend if nobody objects

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

+1

-Jukka-

________________________________
Lähettäjä: Andrea Aime<mailto:andrea.aime@…1268…>
Lähetetty: ‎8.‎11.‎2013 18:18
Vastaanottaja: Biskup, Paul<mailto:Paul.Biskup@…3654…>
Kopio: Geoserver-devel<mailto:geoserver-devel@lists.sourceforge.net>
Aihe: Re: [Geoserver-devel] [Vote] for integration JSON-FeatureCount into stable version

On Tue, Oct 29, 2013 at 8:55 AM, Biskup, Paul <Paul.Biskup@...3654...<mailto:Paul.Biskup@…3654…>> wrote:
Hi GeoServer-developers,

I think I have formulated my last mail wrong. I would really like the JSON-FeatureCount extension to be integrated into the stable version. Andrea Aime told me that for this a vote in the GeoServer-developer-mailing list is neccessary.

So what do you think? Is it ok to integrate the extension into the stable version? It is a rather small extension and it is tested.

I would be very happy to receive positive comments.

Well, +1 here. Haven't seen negative votes and the request has been up for 10 days now, so I'm going to backport
it during the weekend if nobody objects

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------