[Geoserver-devel] wcs 1.0.0 cite test issues

I ran into some failures running the wcs 1.0.0 tests. A few were errors in the tests themselves but a couple of others seem legit:

* wcs1-0-0:describecoverage_operations-describecoverage_response-supportedcrss-rectifiedgrid

This one complains that an srsName attribute is missing on the element:

   /CoverageOffering/domainSet/spatialDomain/gml:RectifiedGrid

in a describe coverage request. I patched it by simply adding the attribute, with a value equal to srsName of the Envelope element which is its sibling.

* wcs1-0-0:getcapabilities_operations-getcapabilities_request-section

This test dictates that when a full capabilities request is done (with a root element that contains the service version) that each of the subelements: Service, Capability, and ContentMetadata elements should *not* have a version.

The fix was simply to remove the version attributes on said elements... the motivation being that we never encode these entities in isolation? Does wcs support partial capabilities documents?

* wcs1-0-0:getcoverage_operations-getcoverage_request-each_interpolation_method

This one seemed to be an encoding error, part of the DescribeCoverage response looks like this:

       <supportedCRSs>
          <requestResponseCRSs>EPSG:4326
     </requestResponseCRSs>
       </supportedCRSs>

With a space and a newline after the "EPSG:4326". I simply removed the whitespace (at the end of the list) and the newline to make it look like this:

       <supportedCRSs>
          <requestResponseCRSs>EPSG:4326</requestResponseCRSs>
       </supportedCRSs>

And that fixes the test.

So I will go ahead and commit the fixes as they seem pretty minor in both cases. But it woudl be good to have someone review the changes since I am much less confident in changing the coverage stuff.

-Justin

--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

On 10-05-19 9:10 PM, Justin Deoliveira wrote:

I ran into some failures running the wcs 1.0.0 tests. A few were errors
in the tests themselves but a couple of others seem legit:

*
wcs1-0-0:describecoverage_operations-describecoverage_response-supportedcrss-rectifiedgrid

This one complains that an srsName attribute is missing on the element:

    /CoverageOffering/domainSet/spatialDomain/gml:RectifiedGrid

in a describe coverage request. I patched it by simply adding the
attribute, with a value equal to srsName of the Envelope element which
is its sibling.

* wcs1-0-0:getcapabilities_operations-getcapabilities_request-section

This test dictates that when a full capabilities request is done (with a
root element that contains the service version) that each of the
subelements: Service, Capability, and ContentMetadata elements should
*not* have a version.

The fix was simply to remove the version attributes on said elements...
the motivation being that we never encode these entities in isolation?
Does wcs support partial capabilities documents?

*
wcs1-0-0:getcoverage_operations-getcoverage_request-each_interpolation_method

This one seemed to be an encoding error, part of the DescribeCoverage
response looks like this:

        <supportedCRSs>
           <requestResponseCRSs>EPSG:4326
      </requestResponseCRSs>
        </supportedCRSs>

With a space and a newline after the "EPSG:4326". I simply removed the
whitespace (at the end of the list) and the newline to make it look like
this:

        <supportedCRSs>
           <requestResponseCRSs>EPSG:4326</requestResponseCRSs>
        </supportedCRSs>

And that fixes the test.

So I will go ahead and commit the fixes as they seem pretty minor in
both cases. But it woudl be good to have someone review the changes
since I am much less confident in changing the coverage stuff.

-Justin

--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Interesting note. Looking at trunk where the wcs 1.0 code has undergone a huge refactor it seems that these issues are not there. Which makes me more confident in committing them :slight_smile:

On 10-05-19 9:10 PM, Justin Deoliveira wrote:

I ran into some failures running the wcs 1.0.0 tests. A few were errors
in the tests themselves but a couple of others seem legit:

*
wcs1-0-0:describecoverage_operations-describecoverage_response-supportedcrss-rectifiedgrid

This one complains that an srsName attribute is missing on the element:

    /CoverageOffering/domainSet/spatialDomain/gml:RectifiedGrid

in a describe coverage request. I patched it by simply adding the
attribute, with a value equal to srsName of the Envelope element which
is its sibling.

* wcs1-0-0:getcapabilities_operations-getcapabilities_request-section

This test dictates that when a full capabilities request is done (with a
root element that contains the service version) that each of the
subelements: Service, Capability, and ContentMetadata elements should
*not* have a version.

The fix was simply to remove the version attributes on said elements...
the motivation being that we never encode these entities in isolation?
Does wcs support partial capabilities documents?

*
wcs1-0-0:getcoverage_operations-getcoverage_request-each_interpolation_method

This one seemed to be an encoding error, part of the DescribeCoverage
response looks like this:

        <supportedCRSs>
           <requestResponseCRSs>EPSG:4326
      </requestResponseCRSs>
        </supportedCRSs>

With a space and a newline after the "EPSG:4326". I simply removed the
whitespace (at the end of the list) and the newline to make it look like
this:

        <supportedCRSs>
           <requestResponseCRSs>EPSG:4326</requestResponseCRSs>
        </supportedCRSs>

And that fixes the test.

So I will go ahead and commit the fixes as they seem pretty minor in
both cases. But it woudl be good to have someone review the changes
since I am much less confident in changing the coverage stuff.

-Justin

--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Justin Deoliveira ha scritto:

I ran into some failures running the wcs 1.0.0 tests. A few were errors in the tests themselves but a couple of others seem legit:

* wcs1-0-0:describecoverage_operations-describecoverage_response-supportedcrss-rectifiedgrid

This one complains that an srsName attribute is missing on the element:

   /CoverageOffering/domainSet/spatialDomain/gml:RectifiedGrid

in a describe coverage request. I patched it by simply adding the attribute, with a value equal to srsName of the Envelope element which is its sibling.

Odd... have they been changing the WCS suites as well lately?

* wcs1-0-0:getcapabilities_operations-getcapabilities_request-section

This test dictates that when a full capabilities request is done (with a root element that contains the service version) that each of the subelements: Service, Capability, and ContentMetadata elements should *not* have a version.

The fix was simply to remove the version attributes on said elements... the motivation being that we never encode these entities in isolation? Does wcs support partial capabilities documents?

Not WCS 1.0, but WCS 1.1 does if memory serves me well.

* wcs1-0-0:getcoverage_operations-getcoverage_request-each_interpolation_method

This one seemed to be an encoding error, part of the DescribeCoverage response looks like this:

       <supportedCRSs>
          <requestResponseCRSs>EPSG:4326
     </requestResponseCRSs>
       </supportedCRSs>

With a space and a newline after the "EPSG:4326". I simply removed the whitespace (at the end of the list) and the newline to make it look like this:

       <supportedCRSs>
          <requestResponseCRSs>EPSG:4326</requestResponseCRSs>
       </supportedCRSs>

And that fixes the test.

So I will go ahead and commit the fixes as they seem pretty minor in both cases. But it woudl be good to have someone review the changes since I am much less confident in changing the coverage stuff.

I'll have a look

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

Ciao Justin,
I will have a look myself this afternoon.

Simone.
-------------------------------------------------------
Ing. Simone Giannecchini
GeoSolutions S.A.S.
Founder - Software Engineer
Via Carignoni 51
55041 Camaiore (LU)
Italy

phone: +39 0584983027
fax: +39 0584983027
mob: +39 333 8128928

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/simonegiannecchini
http://twitter.com/simogeo

-------------------------------------------------------

On Thu, May 20, 2010 at 8:24 AM, Andrea Aime <aaime@anonymised.com> wrote:

Justin Deoliveira ha scritto:

I ran into some failures running the wcs 1.0.0 tests. A few were errors
in the tests themselves but a couple of others seem legit:

*
wcs1-0-0:describecoverage_operations-describecoverage_response-supportedcrss-rectifiedgrid

This one complains that an srsName attribute is missing on the element:

/CoverageOffering/domainSet/spatialDomain/gml:RectifiedGrid

in a describe coverage request. I patched it by simply adding the
attribute, with a value equal to srsName of the Envelope element which
is its sibling.

Odd... have they been changing the WCS suites as well lately?

* wcs1-0-0:getcapabilities_operations-getcapabilities_request-section

This test dictates that when a full capabilities request is done (with a
root element that contains the service version) that each of the
subelements: Service, Capability, and ContentMetadata elements should
*not* have a version.

The fix was simply to remove the version attributes on said elements...
the motivation being that we never encode these entities in isolation?
Does wcs support partial capabilities documents?

Not WCS 1.0, but WCS 1.1 does if memory serves me well.

*
wcs1-0-0:getcoverage_operations-getcoverage_request-each_interpolation_method

This one seemed to be an encoding error, part of the DescribeCoverage
response looks like this:

   &lt;supportedCRSs&gt;
      &lt;requestResponseCRSs&gt;EPSG:4326
 &lt;/requestResponseCRSs&gt;
   &lt;/supportedCRSs&gt;

With a space and a newline after the "EPSG:4326". I simply removed the
whitespace (at the end of the list) and the newline to make it look like
this:

   &lt;supportedCRSs&gt;
      &lt;requestResponseCRSs&gt;EPSG:4326&lt;/requestResponseCRSs&gt;
   &lt;/supportedCRSs&gt;

And that fixes the test.

So I will go ahead and commit the fixes as they seem pretty minor in
both cases. But it woudl be good to have someone review the changes
since I am much less confident in changing the coverage stuff.

I'll have a look

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

------------------------------------------------------------------------------

_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel