[Geoserver-devel] we are mixing slf4j versions in jetty

GeoServer GeoServer Developer
1

Hi all,
I was trying to use the bin package of geoserver which ships a standalone version of jetty but in some cases I’m getting:
java.lang.NoSuchMethodError: org.slf4j.Logger.isTraceEnabled()Z
which comes from my plugin.

In geoserver we never call this method (isTraceEnabled()) which was added after the 1.4 (http://www.slf4j.org/api/org/slf4j/Logger.html#isTraceEnabled%28%29)
so the problem never throws up.

The wrong library version comes from the jetty package and is located here:
./geoserver-2.4-SNAPSHOT/lib/slf4j-simple-1.0.1.jar

It should be 1.5.8 instead.

Anyhow I think we can just remove it since we are also shipping the slf4j-api, slf4j-log4j12 and the log4j implementation 1.2.14 which is sufficient.

What do you think?

Cheers,
Carlo

–

==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK for more information.

Dott. Carlo Cancellieri
@cancellieric
Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

2

Ciao Carlo,
I would suggest to just remove this lib if it is not needed for the
bin GeoServer
I would probably does it first on Master and then backport after 1 month.

I don't think this requires a GSIP, prepare a pull request for people to test.

Sooner rather than later I would probably upgrade our Jetty dependency as well.

Regards,
Simone Giannecchini

Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.

Ing. Simone Giannecchini
@simogeo
Founder/Director

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

On Tue, Apr 8, 2014 at 6:16 PM, carlo cancellieri
<carlo.cancellieri@anonymised.com> wrote:

Hi all,
I was trying to use the bin package of geoserver which ships a standalone
version of jetty but in some cases I'm getting:
java.lang.NoSuchMethodError: org.slf4j.Logger.isTraceEnabled()Z
which comes from my plugin.
In geoserver we never call this method (isTraceEnabled()) which was added
after the 1.4
(http://www.slf4j.org/api/org/slf4j/Logger.html#isTraceEnabled())
so the problem never throws up.

The wrong library version comes from the jetty package and is located here:
./geoserver-2.4-SNAPSHOT/lib/slf4j-simple-1.0.1.jar

It should be 1.5.8 instead.

Anyhow I think we can just remove it since we are also shipping the
slf4j-api, slf4j-log4j12 and the log4j implementation 1.2.14 which is
sufficient.

What do you think?

Cheers,
Carlo

--

Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK for more
information.

Dott. Carlo Cancellieri
@cancellieric
Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

3

On Wed, Apr 9, 2014 at 11:06 AM, Simone Giannecchini <
simone.giannecchini@anonymised.com> wrote:

Ciao Carlo,
I would suggest to just remove this lib if it is not needed for the
bin GeoServer
I would probably does it first on Master and then backport after 1 month.

I don't think this requires a GSIP, prepare a pull request for people to
test.

Sooner rather than later I would probably upgrade our Jetty dependency as
well.

There was a discussion recently, in order to upgrade Jetty we need to first
use
Java 7 as the minimum, as Jetty started requiring it a long time ago.
Another option would be to look if we can use a stripped down tomcat
instead.

Cheers
Andrea

--

Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

4

On Tue, Apr 8, 2014 at 6:16 PM, carlo cancellieri <
carlo.cancellieri@anonymised.com> wrote:

Hi all,
I was trying to use the bin package of geoserver which ships a standalone
version of jetty but in some cases I'm getting:
java.lang.NoSuchMethodError: org.slf4j.Logger.isTraceEnabled()Z
which comes from my plugin.
In geoserver we never call this method (isTraceEnabled()) which was added
after the 1.4 (
http://www.slf4j.org/api/org/slf4j/Logger.html#isTraceEnabled())
so the problem never throws up.

The wrong library version comes from the jetty package and is located
here:
./geoserver-2.4-SNAPSHOT/lib/slf4j-simple-1.0.1.jar

It should be 1.5.8 instead.

Anyhow I think we can just remove it since we are also shipping the
slf4j-api, slf4j-log4j12 and the log4j implementation 1.2.14 which is
sufficient.

What do you think?

That we need to check if Jetty is using the library for its own logging,
and if so, if we can replace the one in the shared libs
with a newer one without causing troubles to Jetty

Cheers
Andrea

--

Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

5

Here is the pull req (description is attached):
https://github.com/geoserver/geoserver/pull/558

···

2014-04-09 14:49 GMT+02:00 Andrea Aime <andrea.aime@anonymised.com>:

–

==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK for more information.

Dott. Carlo Cancellieri
@cancellieric
Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

On Tue, Apr 8, 2014 at 6:16 PM, carlo cancellieri <carlo.cancellieri@anonymised.com> wrote:

Hi all,
I was trying to use the bin package of geoserver which ships a standalone version of jetty but in some cases I’m getting:
java.lang.NoSuchMethodError: org.slf4j.Logger.isTraceEnabled()Z
which comes from my plugin.

In geoserver we never call this method (isTraceEnabled()) which was added after the 1.4 (http://www.slf4j.org/api/org/slf4j/Logger.html#isTraceEnabled%28%29)
so the problem never throws up.

The wrong library version comes from the jetty package and is located here:
./geoserver-2.4-SNAPSHOT/lib/slf4j-simple-1.0.1.jar

It should be 1.5.8 instead.

Anyhow I think we can just remove it since we are also shipping the slf4j-api, slf4j-log4j12 and the log4j implementation 1.2.14 which is sufficient.

What do you think?

That we need to check if Jetty is using the library for its own logging, and if so, if we can replace the one in the shared libs
with a newer one without causing troubles to Jetty

Cheers
Andrea

–

==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

6

Ciao Andrea,
clarification:

  • apparently jetty does not use this lib
  • we removed it and tested it the geoserver binaries and things worked

The pull request simply removes that dependency form building the bin so that others can test.

···

Regards,
Simone Giannecchini

Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK for more information.

Ing. Simone Giannecchini
@simogeo
Founder/Director

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

On Wed, Apr 9, 2014 at 4:19 PM, carlo cancellieri <carlo.cancellieri@anonymised.com> wrote:

Here is the pull req (description is attached):
https://github.com/geoserver/geoserver/pull/558

Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

2014-04-09 14:49 GMT+02:00 Andrea Aime <andrea.aime@anonymised.com>:

–

==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK for more information.

Dott. Carlo Cancellieri
@cancellieric
Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

On Tue, Apr 8, 2014 at 6:16 PM, carlo cancellieri <carlo.cancellieri@anonymised.com> wrote:

Hi all,
I was trying to use the bin package of geoserver which ships a standalone version of jetty but in some cases I’m getting:
java.lang.NoSuchMethodError: org.slf4j.Logger.isTraceEnabled()Z
which comes from my plugin.

In geoserver we never call this method (isTraceEnabled()) which was added after the 1.4 (http://www.slf4j.org/api/org/slf4j/Logger.html#isTraceEnabled%28%29)
so the problem never throws up.

The wrong library version comes from the jetty package and is located here:
./geoserver-2.4-SNAPSHOT/lib/slf4j-simple-1.0.1.jar

It should be 1.5.8 instead.

Anyhow I think we can just remove it since we are also shipping the slf4j-api, slf4j-log4j12 and the log4j implementation 1.2.14 which is sufficient.

What do you think?

That we need to check if Jetty is using the library for its own logging, and if so, if we can replace the one in the shared libs
with a newer one without causing troubles to Jetty

Cheers
Andrea

–

==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

7

Here is the related jira
https://jira.codehaus.org/browse/GEOS-6444

Carlo

···

2014-04-09 16:52 GMT+02:00 Simone Giannecchini <simone.giannecchini@anonymised.com>:

Ciao Andrea,
clarification:

  • apparently jetty does not use this lib
  • we removed it and tested it the geoserver binaries and things worked

The pull request simply removes that dependency form building the bin so that others can test.

–

==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK for more information.

Dott. Carlo Cancellieri
@cancellieric
Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Regards,
Simone Giannecchini

==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK for more information.

Ing. Simone Giannecchini
@simogeo
Founder/Director

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

mob: +39 333 8128928

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

On Wed, Apr 9, 2014 at 4:19 PM, carlo cancellieri <carlo.cancellieri@anonymised.com> wrote:

Here is the pull req (description is attached):
https://github.com/geoserver/geoserver/pull/558

Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

2014-04-09 14:49 GMT+02:00 Andrea Aime <andrea.aime@anonymised.com>:

–

==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK for more information.

Dott. Carlo Cancellieri
@cancellieric
Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

On Tue, Apr 8, 2014 at 6:16 PM, carlo cancellieri <carlo.cancellieri@anonymised.com> wrote:

Hi all,
I was trying to use the bin package of geoserver which ships a standalone version of jetty but in some cases I’m getting:
java.lang.NoSuchMethodError: org.slf4j.Logger.isTraceEnabled()Z
which comes from my plugin.

In geoserver we never call this method (isTraceEnabled()) which was added after the 1.4 (http://www.slf4j.org/api/org/slf4j/Logger.html#isTraceEnabled%28%29)
so the problem never throws up.

The wrong library version comes from the jetty package and is located here:
./geoserver-2.4-SNAPSHOT/lib/slf4j-simple-1.0.1.jar

It should be 1.5.8 instead.

Anyhow I think we can just remove it since we are also shipping the slf4j-api, slf4j-log4j12 and the log4j implementation 1.2.14 which is sufficient.

What do you think?

That we need to check if Jetty is using the library for its own logging, and if so, if we can replace the one in the shared libs
with a newer one without causing troubles to Jetty

Cheers
Andrea

–

==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it