[Geoserver-devel] websphere "compatibility" community module

Hi all,

Recently we had a client reporting issues with the geoserver web ui on websphere. The problem reported that many of the links in the ui don’t work and always lead to the home page. The reason for this a bug in websphere in the way it handles relative page redirects that only include a query string, and not a complete context path.

Relevant issues have been reported in wicket, for instance:

https://issues.apache.org/jira/browse/WICKET-2078

Also some more info here:

http://www.ibm.com/developerworks/forums/thread.jspa?threadID=250807
http://www-01.ibm.com/support/docview.wss?rs=180&context=SSEQTP&dc=DB550&uid=swg1PK89992&loc=en_US&cs=UTF-8&lang=en&rss=ct180websphere

Long story short while this is clearly a websphere bug it doesn’t appear to be getting fixed any time soon. So the solution i came up with was to create a filter that turns relative redirects that only include a query string into ones that also include the context path. Not pretty but it seems to work.

So i was thinking about adding this as a community module. The module would include a single filter class which you can find here:

https://github.com/jdeolive/geoserver/blob/was/src/community/websphere/src/main/java/org/geoserver/web/websphere/WebSphereFilter.java

Any objections?

Thanks.

-Justin


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

On Fri, Feb 17, 2012 at 6:02 AM, Justin Deoliveira <jdeolive@anonymised.com.1501…> wrote:

Hi all,

Recently we had a client reporting issues with the geoserver web ui on websphere. The problem reported that many of the links in the ui don’t work and always lead to the home page. The reason for this a bug in websphere in the way it handles relative page redirects that only include a query string, and not a complete context path.

Relevant issues have been reported in wicket, for instance:

https://issues.apache.org/jira/browse/WICKET-2078

Also some more info here:

http://www.ibm.com/developerworks/forums/thread.jspa?threadID=250807
http://www-01.ibm.com/support/docview.wss?rs=180&context=SSEQTP&dc=DB550&uid=swg1PK89992&loc=en_US&cs=UTF-8&lang=en&rss=ct180websphere

Long story short while this is clearly a websphere bug it doesn’t appear to be getting fixed any time soon. So the solution i came up with was to create a filter that turns relative redirects that only include a query string into ones that also include the context path. Not pretty but it seems to work.

So i was thinking about adding this as a community module. The module would include a single filter class which you can find here:

https://github.com/jdeolive/geoserver/blob/was/src/community/websphere/src/main/java/org/geoserver/web/websphere/WebSphereFilter.java

Any objections?

Works for me. As an alternative we could consider including this as a dormant filter in web-core that gets enabled via system variable.

Cheers
Andrea

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 339 8844549

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf


That works for me too… I guess we could also just add the filter class to the web-core module but leave it totally dormant and websphere users can enable it in web.xml as they normally would a filter. We could still go one step further and add the system property as well.

So cool, unless anyone objects i will go this route. Thanks Andrea!

-Justin

On Fri, Feb 17, 2012 at 9:46 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Fri, Feb 17, 2012 at 6:02 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hi all,

Recently we had a client reporting issues with the geoserver web ui on websphere. The problem reported that many of the links in the ui don’t work and always lead to the home page. The reason for this a bug in websphere in the way it handles relative page redirects that only include a query string, and not a complete context path.

Relevant issues have been reported in wicket, for instance:

https://issues.apache.org/jira/browse/WICKET-2078

Also some more info here:

http://www.ibm.com/developerworks/forums/thread.jspa?threadID=250807
http://www-01.ibm.com/support/docview.wss?rs=180&context=SSEQTP&dc=DB550&uid=swg1PK89992&loc=en_US&cs=UTF-8&lang=en&rss=ct180websphere

Long story short while this is clearly a websphere bug it doesn’t appear to be getting fixed any time soon. So the solution i came up with was to create a filter that turns relative redirects that only include a query string into ones that also include the context path. Not pretty but it seems to work.

So i was thinking about adding this as a community module. The module would include a single filter class which you can find here:

https://github.com/jdeolive/geoserver/blob/was/src/community/websphere/src/main/java/org/geoserver/web/websphere/WebSphereFilter.java

Any objections?

Works for me. As an alternative we could consider including this as a dormant filter in web-core that gets enabled via system variable.

Cheers
Andrea

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 339 8844549

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf



Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.