[Geoserver-devel] We'll need to push out a new release soon... very soon...

Hi,
it seems yours truly fucked up in style this time, the patch for http://jira.codehaus.org/browse/GEOS-4477
had a small side effect… both login and logout on the web UI are broken!

I’m a bit surprised that nobody noticed/reported this one already screaming out loud, but there is it…
I’ve just committed a patch that should fix it:
http://jira.codehaus.org/browse/GEOS-4567

Can people give it a spin?
Anyways, I think we have to schedule a 2.1.1 really soon now, or else backport the patch to
a 2.1.0a tag and re-release from there.

The changelog for 2.1.1 so far would be the following:
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+GEOS+AND+fixVersion+%3D+%222.1.1%22+AND+status+in+%28Resolved%2C+Closed%29

Not so bad, there are few things but some are the important kind.

Opinions?

Cheers
Andrea

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf


Hmm… I actually don’t see an issue with 2.1.0. I just tried both the mac, bin, and war artifacts directly from sourceforge and i can log in and out ok. Tried a few different browsers and still no issue. Am I misunderstanding?

On Mon, May 23, 2011 at 1:30 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
it seems yours truly fucked up in style this time, the patch for http://jira.codehaus.org/browse/GEOS-4477
had a small side effect… both login and logout on the web UI are broken!

I’m a bit surprised that nobody noticed/reported this one already screaming out loud, but there is it…
I’ve just committed a patch that should fix it:
http://jira.codehaus.org/browse/GEOS-4567

Can people give it a spin?
Anyways, I think we have to schedule a 2.1.1 really soon now, or else backport the patch to
a 2.1.0a tag and re-release from there.

The changelog for 2.1.1 so far would be the following:
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+GEOS+AND+fixVersion+%3D+%222.1.1%22+AND+status+in+%28Resolved%2C+Closed%29

Not so bad, there are few things but some are the important kind.

Opinions?

Cheers
Andrea

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf



What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its
next-generation tools to help Windows* and Linux* C/C++ and Fortran
developers boost performance applications - including clusters.
http://p.sf.net/sfu/intel-dev2devmay


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

On Tue, May 24, 2011 at 12:04 AM, Justin Deoliveira <jdeolive@anonymised.com…1501…> wrote:

Hmm… I actually don’t see an issue with 2.1.0. I just tried both the mac, bin, and war artifacts directly from sourceforge and i can log in and out ok. Tried a few different browsers and still no issue. Am I misunderstanding?

Tried on 2.1.x and the issue was there, assumed it affected 2.1.0 as well without trying the official
artifacts.
Hum, the commit that should have broken it has been committed April 15 so… doh?

Wait a second, those same filter that were not associated in the springSecurityContext.xml
anymore were likely brought back by http://jira.codehaus.org/browse/GEOS-4421, for which
I’ve committed a fix only 3 days ago.
This would explain why the issue was noticed only today and also why it’s not happening
on 2.1.0!

Gah, saved by the side effects of another bug!
All right, I guess that we can wait a big longer for 2.1.1 then :-p

Cheers
Andrea

On Mon, May 23, 2011 at 1:30 PM, Andrea Aime <andrea.aime@anonymised.com.> wrote:

Hi,
it seems yours truly fucked up in style this time, the patch for http://jira.codehaus.org/browse/GEOS-4477
had a small side effect… both login and logout on the web UI are broken!

I’m a bit surprised that nobody noticed/reported this one already screaming out loud, but there is it…
I’ve just committed a patch that should fix it:
http://jira.codehaus.org/browse/GEOS-4567

Can people give it a spin?
Anyways, I think we have to schedule a 2.1.1 really soon now, or else backport the patch to
a 2.1.0a tag and re-release from there.

The changelog for 2.1.1 so far would be the following:
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+GEOS+AND+fixVersion+%3D+%222.1.1%22+AND+status+in+%28Resolved%2C+Closed%29

Not so bad, there are few things but some are the important kind.

Opinions?

Cheers
Andrea

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf



What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its
next-generation tools to help Windows* and Linux* C/C++ and Fortran
developers boost performance applications - including clusters.
http://p.sf.net/sfu/intel-dev2devmay


Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf


Just to confirm, I just tried on 2.1.0, and it totally worked fine.

On Mon, May 23, 2011 at 6:21 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Tue, May 24, 2011 at 12:04 AM, Justin Deoliveira <jdeolive@anonymised.com…> wrote:

Hmm… I actually don’t see an issue with 2.1.0. I just tried both the mac, bin, and war artifacts directly from sourceforge and i can log in and out ok. Tried a few different browsers and still no issue. Am I misunderstanding?

Tried on 2.1.x and the issue was there, assumed it affected 2.1.0 as well without trying the official
artifacts.
Hum, the commit that should have broken it has been committed April 15 so… doh?

Wait a second, those same filter that were not associated in the springSecurityContext.xml
anymore were likely brought back by http://jira.codehaus.org/browse/GEOS-4421, for which
I’ve committed a fix only 3 days ago.
This would explain why the issue was noticed only today and also why it’s not happening
on 2.1.0!

Gah, saved by the side effects of another bug!
All right, I guess that we can wait a big longer for 2.1.1 then :-p

Cheers
Andrea

On Mon, May 23, 2011 at 1:30 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
it seems yours truly fucked up in style this time, the patch for http://jira.codehaus.org/browse/GEOS-4477
had a small side effect… both login and logout on the web UI are broken!

I’m a bit surprised that nobody noticed/reported this one already screaming out loud, but there is it…
I’ve just committed a patch that should fix it:
http://jira.codehaus.org/browse/GEOS-4567

Can people give it a spin?
Anyways, I think we have to schedule a 2.1.1 really soon now, or else backport the patch to
a 2.1.0a tag and re-release from there.

The changelog for 2.1.1 so far would be the following:
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+GEOS+AND+fixVersion+%3D+%222.1.1%22+AND+status+in+%28Resolved%2C+Closed%29

Not so bad, there are few things but some are the important kind.

Opinions?

Cheers
Andrea

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf



What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its
next-generation tools to help Windows* and Linux* C/C++ and Fortran
developers boost performance applications - including clusters.
http://p.sf.net/sfu/intel-dev2devmay


Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf



vRanger cuts backup time in half-while increasing security.
With the market-leading solution for virtual backup and recovery,
you get blazing-fast, flexible, and affordable data protection.
Download your free trial now.
http://p.sf.net/sfu/quest-d2dcopy1


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Andrea,

we cannot reproduce this on trunk, either before your GEOS-4567 patch or on a trunk build from 14 May (before the Spring 3 upgrade). Did it only affect 2.1.x? I know the problematic patch was applied to trunk as well; it does not seem to have caused any problems there.

Kind regards,
Ben.

On 24/05/11 03:30, Andrea Aime wrote:

Hi,
it seems yours truly fucked up in style this time, the patch for http://jira.codehaus.org/browse/GEOS-4477
<http://jira.codehaus.org/browse/GEOS-4477&gt;had a small side effect... both login and logout on the web UI are broken!

I'm a bit surprised that nobody noticed/reported this one already screaming out loud, but there is it...
I've just committed a patch that should fix it:
http://jira.codehaus.org/browse/GEOS-4567

Can people give it a spin?
Anyways, I think we have to schedule a 2.1.1 really soon now, or else backport the patch to
a 2.1.0a tag and re-release from there.

The changelog for 2.1.1 so far would be the following:
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+GEOS+AND+fixVersion+%3D+"2.1.1"+AND+status+in+(Resolved%2C+Closed)

Not so bad, there are few things but some are the important kind.

Opinions?

Cheers
Andrea

--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineering Team Leader
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

On Tue, May 24, 2011 at 4:42 AM, Ben Caradoc-Davies Ben.Caradoc-Davies@anonymised.com wrote:

Andrea,

we cannot reproduce this on trunk, either before your GEOS-4567 patch or on a trunk build from 14 May (before the Spring 3 upgrade). Did it only affect 2.1.x? I know the problematic patch was applied to trunk as well; it does not seem to have caused any problems there.

It definitely was not working for me and Christian on trunk yesterday (before the patch),
kept on resulting in error complaining that the Dispatcher was not associated to
that path (because the Spring filters were not catching it like they should have done)

Cheers
Andrea

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf


On Tue, May 24, 2011 at 4:42 AM, Ben Caradoc-Davies Ben.Caradoc-Davies@anonymised.com wrote:

Andrea,

we cannot reproduce this on trunk, either before your GEOS-4567 patch or on a trunk build from 14 May (before the Spring 3 upgrade). Did it only affect 2.1.x? I know the problematic patch was applied to trunk as well; it does not seem to have caused any problems there.

Just downloaded and checked a couple of nightly builds created before yesterday’s patch:

http://gridlock.opengeo.org/geoserver/trunk/geoserver-trunk-2011-05-23-bin.zip
http://gridlock.opengeo.org/geoserver/2.1.x/geoserver-2.1.x-2011-05-23-bin.zip

Trying to log out from both will result in this error in the browser:

HTTP ERROR: 404

NOT_FOUND

RequestURI=/geoserver/j_spring_security_logout

Powered by Jetty://

and this in the logs:

24 mag 08:32:17 WARN [servlet.PageNotFound] - No mapping found for HTTP request with URI [/geoserver/j_spring_security_logout] in DispatcherServlet with name ‘dispatcher’

So yeah, the bug was present in both branches

Cheers
Andrea

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf


Are there are configuration steps needed to reproduce this? Could we be avoiding the problem by using an existing data directory? Does this affect the admin user?

On 24/05/11 14:33, Andrea Aime wrote:

On Tue, May 24, 2011 at 4:42 AM, Ben Caradoc-Davies<Ben.Caradoc-Davies@anonymised.com> wrote:
Andrea,

we cannot reproduce this on trunk, either before your GEOS-4567 patch or on a trunk build from 14 May (before the Spring 3 upgrade). Did it only affect 2.1.x? I know the problematic patch was applied to trunk as well; it does not seem to have caused any problems there.

Just downloaded and checked a couple of nightly builds created before yesterday's patch:

http://gridlock.opengeo.org/geoserver/trunk/geoserver-trunk-2011-05-23-bin.zip
http://gridlock.opengeo.org/geoserver/2.1.x/geoserver-2.1.x-2011-05-23-bin.zip

Trying to log out from both will result in this error in the browser:
HTTP ERROR: 404

NOT_FOUND

RequestURI=/geoserver/j_spring_security_logout

Powered by Jetty://<http://jetty.mortbay.org/&gt;

and this in the logs:

  24 mag 08:32:17 WARN [servlet.PageNotFound] - No mapping found for HTTP request with URI [/geoserver/j_spring_security_logout] in DispatcherServlet with name 'dispatcher'

So yeah, the bug was present in both branches

Cheers
Andrea

--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineering Team Leader
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

On Tue, May 24, 2011 at 8:41 AM, Ben Caradoc-Davies Ben.Caradoc-Davies@anonymised.com wrote:

Are there are configuration steps needed to reproduce this?

None, just grab the nightly as I did and run them.

Could we be avoiding the problem by using an existing data directory?

I don’t see how, the issue is in the code, not related to configurations

Does this affect the admin user?

It does, as said, impossible to login or logout from the admin GUI

Cheers
Andrea

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf


Andrea,

I don't see what your patch for GEOS-4567 in r15914 *on trunk* is supposed to do. It adds two lines to a bean in applicationSecurityContext.xml ... but that bean is already commented out *on trunk*. If trunk is broken, your patch cannot fix it.

The same change adds uncommented configuration items on stable, but trunk has another bean defined above. There is enough context (no pun intended) around the changed lines for patch to apply the diff with a little fuzz.

Kind regards,
Ben.

On 24/05/11 14:54, Andrea Aime wrote:

On Tue, May 24, 2011 at 8:41 AM, Ben Caradoc-Davies<Ben.Caradoc-Davies@anonymised.com> wrote:
Are there are configuration steps needed to reproduce this?

None, just grab the nightly as I did and run them.

Could we be avoiding the problem by using an existing data directory?

I don't see how, the issue is in the code, not related to configurations

Does this affect the admin user?

It does, as said, impossible to login or logout from the admin GUI

Cheers
Andrea

--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineering Team Leader
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

On Tue, May 24, 2011 at 9:28 AM, Ben Caradoc-Davies Ben.Caradoc-Davies@anonymised.com wrote:

Andrea,

I don’t see what your patch for GEOS-4567 in r15914 on trunk is
supposed to do. It adds two lines to a bean in
applicationSecurityContext.xml … but that bean is already commented
out on trunk. If trunk is broken, your patch cannot fix it.

Doh. Just tried again and yeah, I cannot login/logout on trunk.
Made the change in the right section and now I can login/logout again.
Thought I’m sure I’ve checked it yesterday… maybe it was just too late
and did not pay enough attention… dunno…

Cheers
Andrea

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf


Well, I've got good news, and I've got bad news.

The good news is that I can confirm the error on trunk. You were right. My bad. Looking in git logs suggests that the 14 May build was before the problem was introduced. My local build must not have been up-to-date. And I downloaded:
http://gridlock.opengeo.org/geoserver/trunk/geoserver-trunk-2011-05-23-bin.zip
and confirmed the failure there as well. Definitely broken.

The bad news is that it is *still* broken on trunk, for the reason I gave below. At least the mystery is solved. :slight_smile:

Kind regards,
Ben.

On 24/05/11 15:28, Ben Caradoc-Davies wrote:

Andrea,

I don't see what your patch for GEOS-4567 in r15914 *on trunk* is
supposed to do. It adds two lines to a bean in
applicationSecurityContext.xml ... but that bean is already commented
out *on trunk*. If trunk is broken, your patch cannot fix it.

The same change adds uncommented configuration items on stable, but
trunk has another bean defined above. There is enough context (no pun
intended) around the changed lines for patch to apply the diff with a
little fuzz.

Kind regards,
Ben.

On 24/05/11 14:54, Andrea Aime wrote:

On Tue, May 24, 2011 at 8:41 AM, Ben Caradoc-Davies<Ben.Caradoc-Davies@anonymised.com> wrote:
Are there are configuration steps needed to reproduce this?

None, just grab the nightly as I did and run them.

Could we be avoiding the problem by using an existing data directory?

I don't see how, the issue is in the code, not related to configurations

Does this affect the admin user?

It does, as said, impossible to login or logout from the admin GUI

Cheers
Andrea

--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineering Team Leader
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

Thanks, Andrea. I can confirm that login is now fixed on trunk.

On 24/05/11 15:41, Andrea Aime wrote:

Made the change in the right section and now I can login/logout again.

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineering Team Leader
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre