[Geoserver-devel] WfsXmlReader duplication

Hi,
in GeoServer at the moment we do have 4 classes named
WfsXmlReader, they are basically clones of each other,
each handling wfs 1.0, wfs 1.1, wfsv 1.0 and wfsv 1.1
parsing.

Looking at them, it seems to be possible to parametrize
them so that we only have one, or at least, have
a common superclass for all (idea, the single class
receives a generic configuration and a reference to
the catalog, and we're done, no?).

One thing I noticed is that the classes in wfsv do
enable validation when the cite hacks are enabled,
but not when strict=true is passed as a parameter,
whilst the one in wfs do the opposite, they only
look at strict=true.
I believed both classes had to look into both
of them?

Cheers
Andrea

+1 on merging the readers.

And yes, I think the correct behavior is to enable validation on both cite hacks and strict = true.

-Justin

Andrea Aime wrote:

Hi,
in GeoServer at the moment we do have 4 classes named
WfsXmlReader, they are basically clones of each other,
each handling wfs 1.0, wfs 1.1, wfsv 1.0 and wfsv 1.1
parsing.

Looking at them, it seems to be possible to parametrize
them so that we only have one, or at least, have
a common superclass for all (idea, the single class
receives a generic configuration and a reference to
the catalog, and we're done, no?).

One thing I noticed is that the classes in wfsv do
enable validation when the cite hacks are enabled,
but not when strict=true is passed as a parameter,
whilst the one in wfs do the opposite, they only
look at strict=true.
I believed both classes had to look into both
of them?

Cheers
Andrea

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

!DSPAM:4007,483faca5240931336712104!

--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com