Hi all,
geot-788 has been marked as fixed on 1.4.x after rc3 has been cut.
Now, by policy we should realelase 1.4.0rc3 so:
* we either revert Saul change;
* or we keep it and whatch it in at least 2 other developers to
make really sure it's not bound to trigger other problems
It's not Saul fault in fact, it's mine, I should have provided
a general warning that 1.4.x is in deep freeze, and I di not...
something for you release process Brent 
Now, do we go for the second route? Since the change, which I
still haven't seen on the commits mailing list, is in the dispatch
module, I propose me and Justin have a look at it.
What do you think?
Cheers
Andrea
To be completetly honest, I vote you revert the change.
The fix is incredibly minor, and no-one would ever know the difference if it got pushed to 1.4.1-rc0.
I think getting a legit 1.4.0 out is much much more valuable than wasting 2 peoples time for four hours. It's a multiple-slashes issue that cropped up because mapbuilder was creating urls like "http://localhost:8080//geoserver..." rather than with one slash. Pretty low-priority.
So I vote revert the change.
--saul
Andrea Aime wrote:
Hi all,
geot-788 has been marked as fixed on 1.4.x after rc3 has been cut.
Now, by policy we should realelase 1.4.0rc3 so:
* we either revert Saul change;
* or we keep it and whatch it in at least 2 other developers to
make really sure it's not bound to trigger other problems
It's not Saul fault in fact, it's mine, I should have provided
a general warning that 1.4.x is in deep freeze, and I di not...
something for you release process Brent
Now, do we go for the second route? Since the change, which I
still haven't seen on the commits mailing list, is in the dispatch
module, I propose me and Justin have a look at it.
What do you think?
Cheers
Andrea
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
I would just revert the patch, release, and reapply once the code freeze
is off. Unless the patch is really needed, then I would vote for running
cite tests again. I know its a pain, but i am not sure a manual
inspection will cut it.
-Justin
Andrea Aime wrote:
Hi all,
geot-788 has been marked as fixed on 1.4.x after rc3 has been cut.
Now, by policy we should realelase 1.4.0rc3 so:
* we either revert Saul change;
* or we keep it and whatch it in at least 2 other developers to
make really sure it's not bound to trigger other problems
It's not Saul fault in fact, it's mine, I should have provided
a general warning that 1.4.x is in deep freeze, and I di not...
something for you release process Brent
Now, do we go for the second route? Since the change, which I
still haven't seen on the commits mailing list, is in the dispatch
module, I propose me and Justin have a look at it.
What do you think?
Cheers
Andrea
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
!DSPAM:1004,455222be255454820651628!
--
Justin Deoliveira
jdeolive@anonymised.com
The Open Planning Project
http://topp.openplans.org
Saul Farber ha scritto:
To be completetly honest, I vote you revert the change.
The fix is incredibly minor, and no-one would ever know the difference if it got pushed to 1.4.1-rc0.
I think getting a legit 1.4.0 out is much much more valuable than wasting 2 peoples time for four hours. It's a multiple-slashes issue that cropped up because mapbuilder was creating urls like "http://localhost:8080//geoserver..." rather than with one slash. Pretty low-priority.
So I vote revert the change.
Cool, will do tomorrow as first thing.
Thanks for the comprehension and the love for quality
Cheers
Andrea