Hi,
yesterday I've been working on merging GeoSolutions watermark patches on
trunk. Working on trunk was good, since the patch could not
be merged as is, full application required some API changes
in GT2 that would have needed a GT2 proposal. Happily this part
was not "core" so I could simply skip it.
So in the end I merged the part that makes global watermarks
(as opposed of per layer watermarks) and this is what we
do have now on trunk:
* global watermark setting
* watermark can be an image of your choice
* set the position of the watermark in relative terms (upper left,
center, and so on)
* watermark wms raster and kmz output
* proper watermarking of metatiled images (*)
* watermark pdf output (*)
* you can set transparency so that you can have translucent watermark
(*)
* load the watermark from the data dir (*)
* check that watermark file exists, at least when it's on disk
(no checks it it's an http URL) (*)
* watermark caching, so that the watermark is not reloaded each time
we need to paint it. This works only for on disk files (for http url
I don't really know how to check for the cache freshness,
dealing with caching headers and the like would have required
quite some time and tests, so I don't cache them at all) (*)
Now, all the items marked with a (*) where not included
in the original patch that GeoSolutions has been using
for a few months, but were needed imho to have a well
rounded and acceptably fast watermarking.
This means what's on trunk now is not fully tested... I'm a little
weary of committing this to 1.6.x so close to the 1.6.1 release,
is it a problem if we do the backport right after the 1.6.1
release for inclusion in 1.6.2?
How do other developers feel about it?
Cheers
Andrea
First off, great work to both Andrea and Alessio. This is going to be a pretty sweet new feature. As for when. I dont have too big a preference. I would prefer 1.6.2 just because it gives us more time to test. But if people have a strong preference to get it into 1.6.1 i would be ok postponing it a couple of days. Or perhaps throwing out an RC release first.
Andrea Aime wrote:
Hi,
yesterday I've been working on merging GeoSolutions watermark patches on
trunk. Working on trunk was good, since the patch could not
be merged as is, full application required some API changes
in GT2 that would have needed a GT2 proposal. Happily this part
was not "core" so I could simply skip it.
So in the end I merged the part that makes global watermarks
(as opposed of per layer watermarks) and this is what we
do have now on trunk:
* global watermark setting
* watermark can be an image of your choice
* set the position of the watermark in relative terms (upper left,
center, and so on)
* watermark wms raster and kmz output
* proper watermarking of metatiled images (*)
* watermark pdf output (*)
* you can set transparency so that you can have translucent watermark
(*)
* load the watermark from the data dir (*)
* check that watermark file exists, at least when it's on disk
(no checks it it's an http URL) (*)
* watermark caching, so that the watermark is not reloaded each time
we need to paint it. This works only for on disk files (for http url
I don't really know how to check for the cache freshness,
dealing with caching headers and the like would have required
quite some time and tests, so I don't cache them at all) (*)
Now, all the items marked with a (*) where not included
in the original patch that GeoSolutions has been using
for a few months, but were needed imho to have a well
rounded and acceptably fast watermarking.
This means what's on trunk now is not fully tested... I'm a little
weary of committing this to 1.6.x so close to the 1.6.1 release,
is it a problem if we do the backport right after the 1.6.1
release for inclusion in 1.6.2?
How do other developers feel about it?
Cheers
Andrea
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
!DSPAM:4007,47c5432b16286491211187!
--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com