[Geoserver-devel] Whitespace changes in AbstractSecurityWicketTestSupport

Someone has changed all the line endings in AbstractSecurityWicketTestSupport to windows style. This is causing me a bit of friction in trying to update my wicket upgrade branch.


David Winslow
OpenGeo - http://opengeo.org/

On Tue, Jan 29, 2013 at 3:48 PM, David Winslow <dwinslow@anonymised.com> wrote:

Someone has changed all the line endings in AbstractSecurityWicketTestSupport to windows style. This is causing me a bit of friction in trying to update my wicket upgrade branch.

Now this is weird, git history states the file has been modified by you, Christian and Justin.
Afaik none of you works on a Windows machine?

Mumble… am I seeing things, or the windows newlines have always been in that file
since the day it was first committed?

Cheers
Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Yes, looks like you’re right (at least, the copy on the wicket-upgrade branch is also using Windows line breaks.) Git’s only converting it to unix-style on checkout. I wonder how many other files we have that are affected by this.

···

On Tue, Jan 29, 2013 at 9:59 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Tue, Jan 29, 2013 at 3:48 PM, David Winslow <dwinslow@anonymised.com> wrote:

Someone has changed all the line endings in AbstractSecurityWicketTestSupport to windows style. This is causing me a bit of friction in trying to update my wicket upgrade branch.

Now this is weird, git history states the file has been modified by you, Christian and Justin.
Afaik none of you works on a Windows machine?

Mumble… am I seeing things, or the windows newlines have always been in that file
since the day it was first committed?

Cheers
Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it