Hi list,
I have a couple of questions on the subject since I’m not too familiar with that and I’m trying to understand how it works.
I have configured a style with a RasterSymbolizer containing a colorMap.
Then, I have set a static legend for that style, referring to a colormap.png in the GEOSERVER_DATA_DIR/style folder, by configuring the Online Resource field.
Then, I have configured a raster layer, by specifying that style as default style.
However, I have noticed that the rendered legend isn’t the static one but it’s still the one dynamically computed from the style’s colormap.
Is it a bug or is it the expected behaviour?
Taking a look at the code:
https://github.com/geoserver/geoserver/blob/master/src/wms/src/main/java/org/geoserver/wms/legendgraphic/GetLegendGraphicKvpReader.java#L438
It seems like the external legend is only “retrieved” in case the InfoObj is an instance of a LayerInfo. Debugging there, it is a null object so no legend is retrieved.
Should the internal getLegendGraphic also provide the LAYER parameter (since we are in the Publishing tab of a Layer we should know that, right?)?
So, out of curiosity, I have tried passing the LAYER parameter to that getLegendGraphic but I’m still getting the computed legend instead of the static one.
Taking a look at the code, I see this:
This line fill the LegendRequest details
https://github.com/geoserver/geoserver/blob/master/src/wms/src/main/java/org/geoserver/wms/legendgraphic/GetLegendGraphicKvpReader.java#L155
This results into calling this:
https://github.com/geoserver/geoserver/blob/master/src/wms/src/main/java/org/geoserver/wms/legendgraphic/GetLegendGraphicKvpReader.java#L234
which setup a FeatureType here:
https://github.com/geoserver/geoserver/blob/master/src/wms/src/main/java/org/geoserver/wms/legendgraphic/GetLegendGraphicKvpReader.java#L235
Note that this line will set the name of the layer as “GridCoverage”
due to using the FeatureUtilities.wrapGridCoverageReader method.
https://github.com/geotools/geotools/blob/master/modules/library/coverage/src/main/java/org/geotools/resources/coverage/FeatureUtilities.java#L221
Long story short, when trying to get the LegendInfo at this line:
https://github.com/geoserver/geoserver/blob/master/src/wms/src/main/java/org/geoserver/wms/legendgraphic/GetLegendGraphicKvpReader.java#L441
will resolve the LegendInfo object but at line 445 it won’t get the LegendRequest:
since the name of the layer doesn’t match (being set by the wrapper to http://www.opengis.net/gml:GridCoverage.)
So I’m lost
Does it represents a set of bugs or did I missed something?
Do you have any feedbacks on the topic?
Please, let me know.
Cheers,
Daniele
···
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
Ing. Daniele Romagnoli
Senior Software Engineer
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.