Hi,
updating Wicket to a more recent version has been in our TODO list for a long while.
David started an upgrade to wicket 1.5, I tried to help along, then we got stuck on some
security pages, Christian came along and then… we stopped working on it.
The thing is, the attempt at an upgrade is complicated and has been distributed over
a large stretch of time, David first attempts date back to the middle of 2012…
Anyways, recently I took up that branch and worked towards making it build, and succeeded,
results here:
https://github.com/geoserver/geoserver/tree/feature-upgrade-wicket
The diff is … large, around 500KB. And the work is sort of halfway, because our tests are
not exactly covering stuff in detail, lots of manual testing and fixes are still needed.
Now, I had a look at Wicket releases and realized we lost the train again, because the 1.5.x
series has not received a point release in 6 months, whilst Wicket 6, the current stable
series, is already at 6.10
So I’ve tried out to upgrade to it, the idea being that we want to do manual testing of
everything (and associated fixes) just once.
Did the upgrade in the poms and… main had something like 280 compile errors (gaaah!!!).
Marched along, making stuff build again was not exactly a walk in the park, but eventually
succeeded and created a branch for it (which does build, with tests):
https://github.com/geoserver/geoserver/tree/feature-upgrade-wicket16
(the diff does not go up much compared to 1.5, it’s around 650KB)
Then tried to start it interactively, and did not work… finally figured out our gzip filter
breaks page loading, no idea why at the moment (since supposedly Wicket does not
gzip compress contents since 1.5, and oh, if you want to try the Wicket 1.5 branch, the
issue is there too, you’ll have to comment out the gzip filter mappings in web.xml).
Regardless, for the moment I commented the gzip filter out and now the branch
has a GUI that starts, and well, at least you can navigate
between pages, and some of the simplest ones do work, while others do not and break
in various ways (they normally load, but some bits are missing or misbehaving).
This is where I believe we need more of a concerted effort from some people that already
have some Wicket experience, to iron out the most visible/complex problems.
And then probably another round with more people, and with end users, hammering the
UI in detail searching for leftover issues.
Do you think we can get something like this organized? Who’s on board, what’s your
availability?
Circling back to the importer module (see my other mail about code rot), knowing it has
a significant UI portion I wanted to migrate it too (it has to do the full jump from 1.4
to 6), but as observed, the core module does not compile, and once made to compile,
has tests failing. Other community modules might be in the same situation, haven’t checked.
Well, looking forward to hear from you :-p
Cheers
Andrea
–
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
–
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it