Hi,
the Windows build is almost working. Actually, it just never fails on my win7
box, but on the build server, hosted in a VM, it still does a bit (7 out of last 10
builds working fine):
http://winbuild.geo-solutions.it/jenkins/job/GeoServer-Master/
One failure that keeps on happening every now and then is this one:
Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 20.202 sec <<< FAILURE!
testOutputFormatWrongCase(org.geoserver.wfs.xslt.GetFeatureXSLTTest) Time elapsed: 15 sec <<< FAILURE!
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.geoserver.wfs.xslt.GetFeatureXSLTTest.setupXSLT(GetFeatureXSLTTest.java:47)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
And the code where it happens leaves me quite baffled:
@Before
public void setupXSLT() throws IOException {
File dd = getTestData().getDataDirectoryRoot();
File wfs = new File(dd, “wfs”);
File transform = new File(wfs, “transform”);
if (transform.exists()) {
FileUtils.deleteDirectory(transform);
}
assertTrue(transform.mkdirs()); << this is line 47
FileUtils.copyDirectory(new File(“src/test/resources/org/geoserver/wfs/xslt”), transform);
// makes sure the output format list is updated
XSLTOutputFormatUpdater updater = applicationContext.getBean(XSLTOutputFormatUpdater.class);
updater.run();
}
So, before each test we clean up a directory in the data dir. The FileUtils.deleteDirectory
supposedly cleans up a directory recursively, and will throw an exception in case it
cannot.
So apparently we are able to delete the directory, but then sometimes the subsequent mkdirs()
fails to create it back? This would fail only if the directory creation is impossible, or if
it was there already, but neither case should really be happening,
when testOutputFormatWrongCase runs it’s the 6th times setupXSLT() is called,
Anybody has a clue?
The other error is also rather maddening:
···
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
