Dear Jimmy,
things are slightly more difficult than this I believe.
Going by memory, we cannot simply remove the Switch check on 16bits, we might need also to do some review at the WMS encoders in GeoServer to make sure the proper data type is chose for the proper format as most of them won’t expect us to send them 16 bits but rather 8.
There is also another bit, at the moment all the contrast enhancement operators produce 8 bits by default, this should be extended as well and would require some additional work inside the RsterSmbolizer.
If you are willing to invest some time into making this change we might be able to give some directions or the usual answer to pick someone from this page:
http://geoserver.org/support/
···
On Mon, Oct 2, 2017 at 12:58 PM, Envall, Jimmy C <jimmy.envall@anonymised.com> wrote:
Dear community,
This issue refers to a fix proposed by Ville Karppinen at Finnish Meterological Institute (FMI) regarding a patch to Geotools. The fix would enable Geoserver to serve raw raster data with 16 bit data trough WMS without it being rescaled to 8 bit. This would allow the user to fully utilize the benefits of 16 bit data trough WMS.
The matter is now current again. The patch indeed works in the sense that it allows 16 bit data to be downloaded trough WMS. However, building Geoserver against the patched Geotools causes some of the unit tests in Geoserver to fail in a null pointer exception. The failing tests are in org.geoserver.wms.map.RenderedImageOutputFormatTest.java, namely testInterpolations and testInterpolationFromLayerConfig.
The issue seems to be with the transparency. The test data used in the aforementioned tests is 16 bit. Geoserver/Geotools does not handle 16 bit data with alpha, and it seems that JAI does not handle TYPE_USHORT_GRAY with an alpha channel either.
It would be very neat to be able to serve 16 bit data trough WMS in case the original data supports it.
Would anyone have any suggestions on how to handle this properly?
One suggestion is to check whether the user requested transparent data and, and rescale to 8 bit in that case. Would this approach make sense?
The patch can be seen here:
https://github.com/asterycs/geotools/commit/307d4e2a3d0089b9c27d98ba18435599494f8c10
Best regards
Jimmy Envall
Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Geoserver-devel mailing list
Geoserver-devel@anonymised.com.366…sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Regards,
Simone Giannecchini
GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information.
Ing. Simone Giannecchini
@simogeo
Founder/Director
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.