On Fri, Jan 2, 2015 at 8:51 PM, Andrea Aime <andrea.aime@anonymised.com>
wrote:
I disagree, GeoTools stores are not just used by GetMap, they have to work
properly
no matter what the client is.
Your suggestion makes sense only when there is one calling point and many
stores, but in fact
we have a many to many situation and no control over the client code
(GeoTools wise at least).
Thinking about it a bit more, there are also stores that are not written
inside GeoTools and that
we cannot vet for sanity or good practices in general, so having also the
client code
buliding filters do a round of simplification might also make sense.
Streaming renderer does it because it makes a lenghtly combination of rule
filters in OR,
generating a possibly very complex filter that makes some databases choke.
I believe streaming renderer was the first user of the simplifier, and I
made the same reasoning
as you, "hard to apply it to every store, I'll change the renderer instead".
Today the situation is a bit the opposite, new stores not used in demanding
production
environments do not use the simplifier, but the important ones do.
And the GetMap chain ends in the streaming renderer, which should be doing
a step of
simplification.
So all things being equal, I prefer to have the store do the right thing,
and at most, if really
necessary, do an extra step of simplification in GetMap.
Given PropertyDataStore should mimick to the best possible the JDBC ones
(the production
ones), I'd still suggest to have at least the simplfication running in the
store code
Cheers
Andrea
--
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
Please, notice that GeoSolutions will be closed for seasonal holidays
from December the 24th to January the 6th
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------