[Geoserver-devel] working through GSIP 74 feedback

Hi all,

With GSIP 73 done i have moved onto working through feedback for GSIP 74. Here are the current bits of feedback that I got from the proposal, and the status of each.

  • api breaking of WorkspaceAccessLimits constructor

I have re-enabled the two argument constructor taking only read/write parameters. To fill in the adminable parameter we check the current authentication and if the admin role is present we grant set it to true.

  • later adding the ability to set admin flag on layers, styles, layer-groups without breaking resource manager api

I think for now it is best to keep it off rather than add the flag and have it not be used. When we do add that capability we should be able to follow the same suite as WorkspaceAccessLimits, and that is to have the default for the admin flag be set to true if the current authentication has the admin role.

  • better ui, only show data menu items if the user is actually a workspace admin

This has been fixed. And indeed is a much nicer way of doing it :slight_smile:

-Justin


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.