[Geoserver-devel] XStreamPersister and marshaled map order

Hello,

We use revision control (git) for our GEOSERVER_DATA_DIR and have noticed that some (most?) Map instances persisted using o.g.c.u.XStreamPersister result in nondeterministic sorting order. Would there be any objections to a PR with a modification to XStreamPersister.BreifMapConverter [sic] to convert any Map instance that’s not a SortedMap or LinkedHashMap (others?) to a TreeMap just before persistence? This isolate localize the change and reduce the number of spurious diffs we are seeing.

Thanks, Tom.


Tom Kunicki | Software Engineer
w: 608 695 4251 e: tom.kunicki@anonymised.com

Make a bug report and start at it - but you may want to benchmark before and after.

Note there should be some kind of list map that preserved order of keys while still offering good performance.

On Aug 5, 2014, at 10:11 PM, Tom Kunicki <tom.kunicki@anonymised.com> wrote:

Hello,

We use revision control (git) for our GEOSERVER_DATA_DIR and have noticed that some (most?) Map instances persisted using o.g.c.u.XStreamPersister result in nondeterministic sorting order. Would there be any objections to a PR with a modification to XStreamPersister.BreifMapConverter [sic] to convert any Map instance that’s not a SortedMap or LinkedHashMap (others?) to a TreeMap just before persistence? This isolate localize the change and reduce the number of spurious diffs we are seeing.

Thanks, Tom.


Tom Kunicki | Software Engineer
w: 608 695 4251 e: tom.kunicki@anonymised.com


Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk


Geoserver-devel mailing list
Geoserver-devel@anonymised.comists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel