Hi folks,
Does anyone know what the following log trace refers to, and how it may be prevented?
WARN [catalog.util] - There is code not closing CloseableIterator!!! Auto closing at finalize().
I get a continuous stream of these going past, apparently associated with WMS GetCapabilities requests.
Regards,
Andrew
Hi Andrew
I've got the same problems as you did. Did you find out what's the problem?
Regards
Anders Erlandsson
--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Code-not-closing-CloseableIterator-tp5073066p5189440.html
Sent from the GeoServer - User mailing list archive at Nabble.com.
On Mon, Feb 23, 2015 at 2:57 PM, sbkkae <anders.erlandsson@anonymised.com>
wrote:
Hi Andrew
I've got the same problems as you did. Did you find out what's the problem?
Had a quick look at he code and cannot see unclosed iterators.
Which version of GeoServer are you using?
Can the issue be reproduced using 2.6.x or 2.7.x?
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
I am seeing the same thing on 2.7-RC1.
Repro is:
1. Do a WMS 1.3.0 GetCapabilities from the admin page
2. Click back in the browser, then keep drilling into the properties pages
for various stores, layers, and layer groups, cancelling each time at the
end or clicking back on the top left (back to home page)
Eventually you will see in the console:
14 Apr 16:14:23 WARN [catalog.util] - There is code not closing
CloseableIterator!!! Auto closing at finalize().
14 Apr 16:14:23 WARN [catalog.util] - There is code not closing
CloseableIterator!!! Auto closing at finalize().
14 Apr 16:14:24 WARN [catalog.util] - There is code not closing
CloseableIterator!!! Auto closing at finalize().
--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Code-not-closing-CloseableIterator-tp5073066p5201378.html
Sent from the GeoServer - User mailing list archive at Nabble.com.
This warning might be coming from around line 1415 in the method:
org.geoserver.security.SecureCatalogImpl.list(Class<T>, Filter, Integer,
Integer, SortBy)
The following lines:
return new
CloseableIteratorAdapter(Iterators.filter(filteredWrapped,
com.google.common.base.Predicates.notNull()));
should be changed to:
return CloseableIteratorAdapter.filter(filteredWrapped,
com.google.common.base.Predicates.<T> notNull());
--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Code-not-closing-CloseableIterator-tp5073066p5218849.html
Sent from the GeoServer - User mailing list archive at Nabble.com.
On Thu, Aug 6, 2015 at 10:02 PM, sikeoka <steve.ikeoka@anonymised.com> wrote:
This warning might be coming from around line 1415 in the method:
org.geoserver.security.SecureCatalogImpl.list(Class<T>, Filter, Integer,
Integer, SortBy)The following lines:
return new
CloseableIteratorAdapter(Iterators.filter(filteredWrapped,
com.google.common.base.Predicates.notNull()));should be changed to:
return CloseableIteratorAdapter.filter(filteredWrapped,
com.google.common.base.Predicates.<T> notNull());
I don't see how this can possibly make the iterator get closed, the
close operation requires a explicting "close" call in the code
using the iterator.
Was a ticket ever opened, with steps to reproduce?
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
Even if all code that is calling the list() function always closes the
returned CloseableIterator, the final CloseableIteratorAdapter instance that
is created in SecureCatalogImpl.list() does not contain the reference to
close the filteredWrapped CloseableIterator so filteredWrapped is left
unclosed when the garbage collector gets to it. The code change in my
previous messages fixes that so closing the CloseableIterator that is
returned by SecureCatalogImpl.list() will close the filteredWrapped
instance.
This does not generate the warning message in most cases because
CloseableIteratorAdapter.hasNext() will call close() on itself before
returning false but calling hasNext() until it returns false is not a
requirement. I was able to find an instance in the WMS 1.3.0
GetCapabilities code where hasNext() may not be called until it returns
false although this is likely to happen anywhere where an exception is
thrown while processing the iterator.
This is a portion of the code from Capabilities_1_3_0_Transformer:
private void handleRootBbox(Iterator<LayerInfo> layers) {
...
while(layers.hasNext()) {
...
if(latlonBbox.contains(world)){
break;
}
}
...
}
I did not see a JIRA ticket about this. I can reproduce this with a WMS
1.3.0 GetCapabilities request although the warning message won't appear
until the garbage collector runs which may not always happen with a single
request.
--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Code-not-closing-CloseableIterator-tp5073066p5219096.html
Sent from the GeoServer - User mailing list archive at Nabble.com.
On Sun, Aug 9, 2015 at 9:09 PM, sikeoka <steve.ikeoka@anonymised.com> wrote:
Even if all code that is calling the list() function always closes the
returned CloseableIterator, the final CloseableIteratorAdapter instance
that
is created in SecureCatalogImpl.list() does not contain the reference to
close the filteredWrapped CloseableIterator so filteredWrapped is left
unclosed when the garbage collector gets to it. The code change in my
previous messages fixes that so closing the CloseableIterator that is
returned by SecureCatalogImpl.list() will close the filteredWrapped
instance.
Ah... I was focusing on that extra <T> in the row, and did not notice
the real change was switching from constructor to factory method
This does not generate the warning message in most cases because
CloseableIteratorAdapter.hasNext() will call close() on itself before
returning false but calling hasNext() until it returns false is not a
requirement. I was able to find an instance in the WMS 1.3.0
GetCapabilities code where hasNext() may not be called until it returns
false although this is likely to happen anywhere where an exception is
thrown while processing the iterator.This is a portion of the code from Capabilities_1_3_0_Transformer:
private void handleRootBbox(Iterator<LayerInfo> layers) {
...
while(layers.hasNext()) {
...
if(latlonBbox.contains(world)){
break;
}
}
...
}I did not see a JIRA ticket about this.
Can someone please do it? Nothing gets done without a ticket to remind
us, because it's almost impossible that we have time to work it right away,
and when we find some time a week or a month later, only what's on Jira
gets considered
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
JIRA ticket:
https://osgeo-org.atlassian.net/browse/GEOS-7151
Pull request:
Steve Ikeoka
--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Code-not-closing-CloseableIterator-tp5073066p5219222.html
Sent from the GeoServer - User mailing list archive at Nabble.com.
On Mon, Aug 10, 2015 at 6:18 PM, sikeoka <steve.ikeoka@anonymised.com> wrote:
JIRA ticket:
https://osgeo-org.atlassian.net/browse/GEOS-7151Pull request:
https://github.com/geoserver/geoserver/pull/1181
Thank you!
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------