[Geoserver-users] Does CQL/ECQL support comments?

GeoServer GeoServer User
1

Hi all

We occasionally make use of CQL in our GeoServer layer definition (in Add a new layer, the very last option before Save is Restrict the features on layer by CQL filter.

My first question to the GeoServer team is: is this restricted to CQL, or does it allow ECQL too? I am assuming that ECQL is supported due to this statement:

Whenever the documentation refers to CQL, ECQL syntax can be used as well (and if not, please report that as a bug!).
ref: https://docs.geoserver.org/stable/en/user/tutorials/cql/cql_tutorial.html

Secondly, more to GeoTools: does CQL, or ECQL, support the use of comments?

Nothing is mentioned in https://docs.geoserver.org/stable/en/user/filter/ecql_reference.html

But the ECQL NBF grammar at https://github.com/geotools/geotools/blob/master/modules/library/cql/ECQL.md has one reference to:

<separator> ::= { <comment> | <space> | <newline> }...

but no definition of . Perhaps that should be removed as the code at https://github.com/geotools/geotools/tree/master/modules/library/cql/src/main/jjtree does not contain any mention of comment.

Thanks

Peter

2

So what would comment look like for CQL / ECQL ? Similar to SQL with a -- ? Looking around at other implementations --, /* ... */ and // are all supported.

As for ECQL.md here is a PR https://github.com/geotools/geotools/pull/2823

···

–
Jody Garnett

3

Hi Jody

Seeing as a CQL filter can be provided on a single line/URL, I think that an ‘open and close comment’ syntax would be important i.e. /* ... */ would be a good start.

Thanks for confirming that it currently does not exist.

Regards

Peter

On Sun, 1 Mar 2020 at 02:48, Jody Garnett <jody.garnett@anonymised.com> wrote:

So what would comment look like for CQL / ECQL ? Similar to SQL with a -- ? Looking around at other implementations --, /* ... */ and // are all supported.

As for ECQL.md here is a PR https://github.com/geotools/geotools/pull/2823

–
Jody Garnett

On Fri, 28 Feb 2020 at 02:29, Peter Smythe <gs@…8839…> wrote:

Hi all

We occasionally make use of CQL in our GeoServer layer definition (in Add a new layer, the very last option before Save is Restrict the features on layer by CQL filter.

My first question to the GeoServer team is: is this restricted to CQL, or does it allow ECQL too? I am assuming that ECQL is supported due to this statement:

Whenever the documentation refers to CQL, ECQL syntax can be used as well (and if not, please report that as a bug!).
ref: https://docs.geoserver.org/stable/en/user/tutorials/cql/cql_tutorial.html

Secondly, more to GeoTools: does CQL, or ECQL, support the use of comments?

Nothing is mentioned in https://docs.geoserver.org/stable/en/user/filter/ecql_reference.html

But the ECQL NBF grammar at https://github.com/geotools/geotools/blob/master/modules/library/cql/ECQL.md has one reference to:

<separator> ::= { <comment> | <space> | <newline> }...

but no definition of . Perhaps that should be removed as the code at https://github.com/geotools/geotools/tree/master/modules/library/cql/src/main/jjtree does not contain any mention of comment.

Thanks

Peter

GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel