[Geoserver-users] Geoserver constantly reorders wfs.xml, pita for config in source control

Geoserver constantly reorders wfs.xml, swapping v_20 and v_10 sections, when there has been no logical change to the file. While it remains valid xml it is flagged as a changed file which is a pita when trying to hold the config in source control.

Using source control that supports xml diff would be a lot more complex than it appears at face value because it would need to understand the meaning to decide what is a change.

Is there any good reason why this file is being changed? It seems like it would be a trivial bugfix to leave the order and the file alone when it is not actually being changed?

Thanks

Ben

On Thu, Feb 26, 2015 at 5:55 PM, Ben Norris <ben.norris@anonymised.com> wrote:

Geoserver constantly reorders wfs.xml, swapping v_20 and v_10 sections,
when there has been no logical change to the file. While it remains valid
xml it is flagged as a changed file which is a pita when trying to hold the
config in source control.

Using source control that supports xml diff would be a lot more complex tha
n it appears at face value because it would need to understand the
meaning to decide what is a change.

Indeed it's annoying, seen it myself multiple times. Never had a pressing
reason to investigate though (hardly gets the "most pressing issue" label).

Is there any good reason why this file is being changed? It seems like it
would be a trivial bugfix to leave the order and the file alone when it is
not actually being changed?

No idea, but if you say the fix is trivial, why don't you give it a crack
and make a pull request? :slight_smile:
https://github.com/geoserver/geoserver/blob/master/CONTRIBUTING.md

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

I suspect it will be trivial to someone who knows the codebase where the config is loaded (either that or impossible for some obscure reason J ). Learning it and then making the change is considerably more work, which unfortunately I don’t have time for.

It’s not a demand, just would be nice if someone stuck it on the list to look at at some point. Not sure why it is so difficult to make a suggestion/report a bug on this project?

From: andrea.aime@…84… [mailto:andrea.aime@…84…] On Behalf Of Andrea Aime
Sent: 26 February 2015 17:25
To: Ben Norris
Cc: geoserver-users@lists.sourceforge.net
Subject: Re: [Geoserver-users] Geoserver constantly reorders wfs.xml, pita for config in source control

On Thu, Feb 26, 2015 at 5:55 PM, Ben Norris <ben.norris@…6901…> wrote:

Geoserver constantly reorders wfs.xml, swapping v_20 and v_10 sections, when there has been no logical change to the file. While it remains valid xml it is flagged as a changed file which is a pita when trying to hold the config in source control.

Using source control that supports xml diff would be a lot more complex than it appears at face value because it would need to understand the meaning to decide what is a change.

Indeed it’s annoying, seen it myself multiple times. Never had a pressing reason to investigate though (hardly gets the “most pressing issue” label).

Is there any good reason why this file is being changed? It seems like it would be a trivial bugfix to leave the order and the file alone when it is not actually being changed?

No idea, but if you say the fix is trivial, why don’t you give it a crack and make a pull request? :slight_smile:

https://github.com/geoserver/geoserver/blob/master/CONTRIBUTING.md

Cheers

Andrea

On Thu, Feb 26, 2015 at 6:38 PM, Ben Norris <ben.norris@anonymised.com> wrote:

I suspect it will be trivial to someone who knows the codebase where the
config is loaded (either that or impossible for some obscure reason J ).
Learning it and then making the change is considerably more work, which
unfortunately I don’t have time for.

It’s not a demand, just would be nice if someone stuck it on the list to
look at at some point. Not sure why it is so difficult to make a
suggestion/report a bug on this project?

Reporting a bug is actually relatively easy, just go here:
http://jira.codehaus.org/browse/GEOS

The main issue is getting the ticket resolved, and that might become in
fact hard if you
cannot solve it yourself.
There are basically two avenues. I'd say 90% of the work is done on paid
contracts,
and core developers are working full time on those (it's up to 9 hours a
day for me).
And then there is the spare time, which is maybe 4 hours during the weekend
(again, for me),
where "everything else" gets addressed, by priority and/or sometimes just
because one
likes to do a certain thing and not another one

First order of priority is reviewing pull requests, in order to keep
contributions coming from
non core devs flowing... that alone uses a lot of those 4 hours.
And then there is everything else, that is, all the open tickets in jira...
and one ends up
working on those that can fit the remaining time (e..g, easy ones, possibly
affecting a lot
of people).

And sometimes you really just want to work on something, like when I
decided to put
back some life in the css support. I started July 2014, using half of my
seaside vacations,
and continued working on it on and off until Christmas, where it used
another half of
my winter vacations, and then madly over then next few weekends, in order
to complete it
by the feature freeze (Jan 18 2015).

So.. imagine how hard it must be to hear users complaints when you
basically are throwing
all the time you have on the project, and yet it's never enough.....
but it's a given that one cannot make everybody happy, and I've learned to
live with it :wink:

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

My intention was to help you by reporting a bug that you might not be aware of, and I’ve already gone out of my way to do that. I didn’t really want to make a ton of accounts or listen to a guilt trip. I am hardworking and busy too, the hostility is uncalled for and not any way that is going to earn support for yourself or this project.

Good day.

From: andrea.aime@…84… [mailto:andrea.aime@…84…] On Behalf Of Andrea Aime
Sent: 26 February 2015 17:48
To: Ben Norris
Cc: geoserver-users@lists.sourceforge.net
Subject: Re: [Geoserver-users] Geoserver constantly reorders wfs.xml, pita for config in source control

On Thu, Feb 26, 2015 at 6:38 PM, Ben Norris <ben.norris@…6901…> wrote:

I suspect it will be trivial to someone who knows the codebase where the config is loaded (either that or impossible for some obscure reason J ). Learning it and then making the change is considerably more work, which unfortunately I don’t have time for.

It’s not a demand, just would be nice if someone stuck it on the list to look at at some point. Not sure why it is so difficult to make a suggestion/report a bug on this project?

Reporting a bug is actually relatively easy, just go here: http://jira.codehaus.org/browse/GEOS

The main issue is getting the ticket resolved, and that might become in fact hard if you

cannot solve it yourself.

There are basically two avenues. I’d say 90% of the work is done on paid contracts,

and core developers are working full time on those (it’s up to 9 hours a day for me).

And then there is the spare time, which is maybe 4 hours during the weekend (again, for me),

where “everything else” gets addressed, by priority and/or sometimes just because one

likes to do a certain thing and not another one

First order of priority is reviewing pull requests, in order to keep contributions coming from

non core devs flowing… that alone uses a lot of those 4 hours.

And then there is everything else, that is, all the open tickets in jira… and one ends up

working on those that can fit the remaining time (e…g, easy ones, possibly affecting a lot

of people).

And sometimes you really just want to work on something, like when I decided to put

back some life in the css support. I started July 2014, using half of my seaside vacations,

and continued working on it on and off until Christmas, where it used another half of

my winter vacations, and then madly over then next few weekends, in order to complete it

by the feature freeze (Jan 18 2015).

So… imagine how hard it must be to hear users complaints when you basically are throwing

all the time you have on the project, and yet it’s never enough…

but it’s a given that one cannot make everybody happy, and I’ve learned to live with it :wink:

Cheers

Andrea

==

GeoServer Professional Services from the experts! Visit

http://goo.gl/NWWaa2 for more information.

==

Ing. Andrea Aime

@geowolf

Technical Lead

GeoSolutions S.A.S.

Via Poggio alle Viti 1187

55054 Massarosa (LU)

Italy

phone: +39 0584 962313

fax: +39 0584 1660272

mob: +39 339 8844549

http://www.geo-solutions.it

http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


On Thu, Feb 26, 2015 at 7:02 PM, Ben Norris <ben.norris@anonymised.com> wrote:

My intention was to *help you* by reporting a bug that you might not be
aware of, and I’ve already gone out of my way to do that. I didn’t really
want to make a ton of accounts or listen to a guilt trip. I am hardworking
and busy too, the hostility is uncalled for and not any way that is going
to earn support for yourself or this project.

If you simply want to report a bug, my previous answer contains the way:

Reporting a bug is actually relatively easy, just go here:

http://jira.codehaus.org/browse/GEOS

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------