[Geoserver-users] GeoServer fc_cleanup branch

GeoServer GeoServer User
1

Added a few comments to github … nothing important.

  • you could take advantage of some of the utility methods that were just added.
  • a few places could use try / finally to ensure featureIterator.close() is called

Possible duplication with GeoTools:

  • ReprojectingFeatureCollection
  • RetypingIterator

And RemappingIterator looks like it could be subsumed by the recent Transform work.

–
Jody Garnett

On Sunday, 4 November 2012 at 7:06 AM, Justin Deoliveira wrote:

Here it is. I pushed it up to the main repository in case you want to make changes Andrea.

https://github.com/geoserver/geoserver/tree/fc_cleanup

Indeed the part i was unsure about was the secure feature collection / secure feature source. I basically dropped all the unnecessary methods from SecureFeatureCollection as you mentioned. I also removed the wrapping in DefaultSecureDataFactory of the plain Iterator interface.

-Justin

On Sat, Nov 3, 2012 at 12:40 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Sat, Nov 3, 2012 at 7:27 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

SecuredFeatureCollection wise I believe we can just drop all the extra
methods
Jody removed from FeatureCollection,
don’t think that GeoServer uses any of them but wanted to make sure
security
could not be broken by accident if one module started using them

Yeah, more or less that is what i did. There was a test case though that
were calling the remove/add methods, so updated that. Will definitely want a
review on that stuff.

Sure will do. Since it was security I wanted to make sure I was shutting down
all possible ways to write when not allowed (well, past reflection
against private
fields of course), but those methods and the tests were just me being
thorough as
I believe there is nothing in GeoServer using them.

I’ll have a look at the branch as it’s made available.

Cheers
Andrea

2

Sorry wrong list

–
Jody Garnett

On Thursday, 8 November 2012 at 2:21 AM, Jody Garnett wrote:

Added a few comments to github … nothing important.

  • you could take advantage of some of the utility methods that were just added.
  • a few places could use try / finally to ensure featureIterator.close() is called

Possible duplication with GeoTools:

  • ReprojectingFeatureCollection
  • RetypingIterator

And RemappingIterator looks like it could be subsumed by the recent Transform work.

–
Jody Garnett

On Sunday, 4 November 2012 at 7:06 AM, Justin Deoliveira wrote:

Here it is. I pushed it up to the main repository in case you want to make changes Andrea.

https://github.com/geoserver/geoserver/tree/fc_cleanup

Indeed the part i was unsure about was the secure feature collection / secure feature source. I basically dropped all the unnecessary methods from SecureFeatureCollection as you mentioned. I also removed the wrapping in DefaultSecureDataFactory of the plain Iterator interface.

-Justin

On Sat, Nov 3, 2012 at 12:40 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Sat, Nov 3, 2012 at 7:27 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

SecuredFeatureCollection wise I believe we can just drop all the extra
methods
Jody removed from FeatureCollection,
don’t think that GeoServer uses any of them but wanted to make sure
security
could not be broken by accident if one module started using them

Yeah, more or less that is what i did. There was a test case though that
were calling the remove/add methods, so updated that. Will definitely want a
review on that stuff.

Sure will do. Since it was security I wanted to make sure I was shutting down
all possible ways to write when not allowed (well, past reflection
against private
fields of course), but those methods and the tests were just me being
thorough as
I believe there is nothing in GeoServer using them.

I’ll have a look at the branch as it’s made available.

Cheers
Andrea