Hello Andrea,
The buffer in GetMap determines the extra search area for features whose geometry is outside of the requested area,
but whose symbolizer is big enough to make it appear in the painted map anyways.
This is sent down to GeoTools as a single value, if you want to really make that per layer instead of just picking
the highest value, you’ll have to modify GeoTools StreamingRenderer and Layer classes, which would be an API
change over there (thus, subject to a format proposal, and limited to trunk, you can backport to the stable series
only with a positive vote of the project management committee).
I’ve not personally interested in extending GetMap as well but because currently
the documentation and implementation are mainly shared for both operations,
I assumed that I would not be able to enhance one without the other.
I’m not sure if separating the implementations is more trouble than it’s worth.
However, changing GeoTools sounds like a lot of effort.
I don’t really want to make half-hearted job of changing GetMap because
if in the future it needs to be improved further, then I don’t know if it’s acceptable to change the behaviour.
Perhaps it’s not a big deal, it’s just that as a user I expect the same result with two calls for separate layers as for one merged call.
No, this one does not make sense. There is already a limit on the maximum buffer size (I believe it’s 20?), why
add this extra complication?
If the caller does not want to specify a buffer for a certain layer, we can leave it empty like in styles, e.g.
buffer=10,15,17
That’s all I meant.
What’s the minimum that works for you?
Best Regards
Simon Hartley
From: andrea.aime@anonymised.com [mailto:andrea.aime@anonymised.com] On Behalf Of Andrea Aime
Sent: 26 March 2013 17:53
To: Simon Hartley
Cc: geoserver-users@lists.sourceforge.net
Subject: Re: [Geoserver-users] GetFeatureInfo buffer
On Tue, Mar 26, 2013 at 5:54 PM, Simon Hartley <SHartley@anonymised.com> wrote:
Hello,
Currently if I do separate GetFeatureInfo requests for each layer I can specify a different buffer parameter for each layer.
When trying to combine the separate requests I discover that I can only specify a single buffer.
Is it a valid enhancement to allow buffer to accept a different value for each layer?
It sounds like a valid enhancement to me.
GetMap would probably need to be enhanced at the same time.
The buffer in GetMap determines the extra search area for features whose geometry is outside of the requested area,
but whose symbolizer is big enough to make it appear in the painted map anyways.
This is sent down to GeoTools as a single value, if you want to really make that per layer instead of just picking
the highest value, you’ll have to modify GeoTools StreamingRenderer and Layer classes, which would be an API
change over there (thus, subject to a format proposal, and limited to trunk, you can backport to the stable series
only with a positive vote of the project management committee).
Also it would be necessary for any layer to be able to opt-out of specifying a buffer and just let the automatic, SLD-based calculation be used.
No, this one does not make sense. There is already a limit on the maximum buffer size (I believe it’s 20?), why
add this extra complication?
If the caller does not want to specify a buffer for a certain layer, we can leave it empty like in styles, e.g.
buffer=10,15,17
I’ve had a look at the source and although it seems a relatively simple change, there are aspects that I don’t understand (possibly there’s some reflection going on).
Do I need to add a ticket?
Yes, a ticket is required. Also a junit test for every new behavior you add.
Given this is a new feature, things would work like in GeoTools, first commit on trunk after passing a review,
and then call the project steering committee for a vote in order to backport on the stable series.
Cheers
Andrea
–
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*** This communication has been sent from World Fuel Services
Corporation or its subsidiaries or its affiliates for the intended recipient
only and may contain proprietary, confidential or privileged information.
If you are not the intended recipient, any review, disclosure, copying,
use, or distribution of the information included in this communication
and any attachments is strictly prohibited. If you have received this
communication in error, please notify us immediately by replying to this
communication and delete the communication, including any
attachments, from your computer. Electronic communications sent to or
from World Fuel Services Corporation or its subsidiaries or its affiliates
may be monitored for quality assurance and compliance purposes.***