[Geoserver-users] Oracle database driver support improvements waiting for feedback

Hi all,

There are two pull requests improving Oracle database driver support that are caught in a catch-22. The problem is that none of the regular developers have access to an Oracle instance so these cannot be merged.

This is a request for feedback on either or both of these pull requests so that they are validated and can be merged and make using Oracle databases easier in future releases of GeoTools and GeoServer.

For GeoTools:https://github.com/geotools/geotools/pull/2832

for GeoServer: https://github.com/geoserver/geoserver/pull/4119

Thanks, Mark

Hi!
I do believe that Oracle has a free XE edition, and also is free to use for development.

Hälsning / Regards
Mats.E

Skickat från min / Sent from my iPhone, Ursäkta att jag är kortfattad / Excuse my brevity.

15 apr. 2020 kl. 10:13 skrev mark <mc.prins@anonymised.com>:

Hi all,

There are two pull requests improving Oracle database driver support that are caught in a catch-22. The problem is that none of the regular developers have access to an Oracle instance so these cannot be merged.

This is a request for feedback on either or both of these pull requests so that they are validated and can be merged and make using Oracle databases easier in future releases of GeoTools and GeoServer.

For GeoTools:https://github.com/geotools/geotools/pull/2832

for GeoServer: https://github.com/geoserver/geoserver/pull/4119

Thanks, Mark

_______________________________________________
Geoserver-users mailing list

Please make sure you read the following two resources before posting to this list:
- Earning your support instead of buying it, but Ian Turton: http://www.ianturton.com/talks/foss4g.html#/
- The GeoServer user list posting guidelines: http://geoserver.org/comm/userlist-guidelines.html

If you want to request a feature or an improvement, also see this: https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer

Geoserver-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-users

Hi,
the issue is indeed not money but finding time to set it up and run the tests.
I had a Oracle 12 docker image locally, but it was using lots of space that I needed to work with OSM data, and had to wipe it out…
I set it up a handful of times by now, always a pain, takes time, searches over the internet for strange commands, fighting with permissions and the like… typically eats away 2-4 hours for me (but to be honest, I use Oracle maybe 1-2 days a year, so it just keeps on being unfamiliar). Believe other core devs are in the same boat, if they are not so blessed as to never touch Oracle DB at all :-p

Cheers
Andrea

···

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

Hi Andrea et al!
Lack of access to certain environments seem to be a returning problem in FOSS development. However, the need for those environments indicate the the user community uses them.
Provided that licensing does not interfere, I would suggest that a cloud service be established, in this case for example with an Oracle instance and suitable set of geodata loaded.
This cloud computer could be very slim in terms of cores and RAM since it would do only limited work. If it was normally shut down, and only booted when needed, the monthly cost could be kept at a minimum.
The computer and software would of course need to be maintained, but I am sure this knowledge exists in the user community.

Regards, Mats.E

···

GisKraft, Geodatakonsult

Mats Elfström, Marsvinsholms stationsväg 80, 271 93 Ystad, Sweden
tel: +46 70 595 39 35 / www.giskraft.se

Hi,

I’ll check with my employer if we have the ability to aid in this matter.

So, is it a schema with test data that we would test changes against from time to time?

Regards,
Olle Markljung

ons 15 apr. 2020 kl. 11:14 skrev Andrea Aime <andrea.aime@anonymised.com>:

Hi,
the issue is indeed not money but finding time to set it up and run the tests.
I had a Oracle 12 docker image locally, but it was using lots of space that I needed to work with OSM data, and had to wipe it out…
I set it up a handful of times by now, always a pain, takes time, searches over the internet for strange commands, fighting with permissions and the like… typically eats away 2-4 hours for me (but to be honest, I use Oracle maybe 1-2 days a year, so it just keeps on being unfamiliar). Believe other core devs are in the same boat, if they are not so blessed as to never touch Oracle DB at all :-p

Cheers
Andrea

On Wed, Apr 15, 2020 at 10:50 AM Mats Elfström <mats.elfstrom@anonymised.com> wrote:

Hi!
I do believe that Oracle has a free XE edition, and also is free to use for development.

Hälsning / Regards
Mats.E

Skickat från min / Sent from my iPhone, Ursäkta att jag är kortfattad / Excuse my brevity.

15 apr. 2020 kl. 10:13 skrev mark <mc.prins@anonymised.com>:

Hi all,

There are two pull requests improving Oracle database driver support that are caught in a catch-22. The problem is that none of the regular developers have access to an Oracle instance so these cannot be merged.

This is a request for feedback on either or both of these pull requests so that they are validated and can be merged and make using Oracle databases easier in future releases of GeoTools and GeoServer.

For GeoTools:https://github.com/geotools/geotools/pull/2832

for GeoServer: https://github.com/geoserver/geoserver/pull/4119

Thanks, Mark


Geoserver-users mailing list

Please make sure you read the following two resources before posting to this list:

If you want to request a feature or an improvement, also see this: https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer

Geoserver-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-users


Geoserver-users mailing list

Please make sure you read the following two resources before posting to this list:

If you want to request a feature or an improvement, also see this: https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer

Geoserver-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-users

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.


Geoserver-users mailing list

Please make sure you read the following two resources before posting to this list:

If you want to request a feature or an improvement, also see this: https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer

Geoserver-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-users

Hi Olle,
thanks for looking into it. It’s a empty schema with full rights within it, the tests are creating and destroying tables
into it multiple times per test.

Cheers
Andrea

···

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

I will post a quick note on how to set up the Oracle schema, at least for 12.2, tomorrow when I get back in the office.
I currently have this module set up on our in-house Jenkins.

Op wo 15 apr. 2020 14:06 schreef Andrea Aime <andrea.aime@anonymised.com>:

Hi Olle,
thanks for looking into it. It’s a empty schema with full rights within it, the tests are creating and destroying tables
into it multiple times per test.

Cheers
Andrea

On Wed, Apr 15, 2020 at 1:26 PM Olle Markljung <markljung@anonymised.com> wrote:

Hi,

I’ll check with my employer if we have the ability to aid in this matter.

So, is it a schema with test data that we would test changes against from time to time?

Regards,
Olle Markljung

ons 15 apr. 2020 kl. 11:14 skrev Andrea Aime <andrea.aime@anonymised.com.1107…>:

Hi,
the issue is indeed not money but finding time to set it up and run the tests.
I had a Oracle 12 docker image locally, but it was using lots of space that I needed to work with OSM data, and had to wipe it out…
I set it up a handful of times by now, always a pain, takes time, searches over the internet for strange commands, fighting with permissions and the like… typically eats away 2-4 hours for me (but to be honest, I use Oracle maybe 1-2 days a year, so it just keeps on being unfamiliar). Believe other core devs are in the same boat, if they are not so blessed as to never touch Oracle DB at all :-p

Cheers
Andrea

On Wed, Apr 15, 2020 at 10:50 AM Mats Elfström <mats.elfstrom@…10136…> wrote:

Hi!
I do believe that Oracle has a free XE edition, and also is free to use for development.

Hälsning / Regards
Mats.E

Skickat från min / Sent from my iPhone, Ursäkta att jag är kortfattad / Excuse my brevity.

15 apr. 2020 kl. 10:13 skrev mark <mc.prins@anonymised.com>:

Hi all,

There are two pull requests improving Oracle database driver support that are caught in a catch-22. The problem is that none of the regular developers have access to an Oracle instance so these cannot be merged.

This is a request for feedback on either or both of these pull requests so that they are validated and can be merged and make using Oracle databases easier in future releases of GeoTools and GeoServer.

For GeoTools:https://github.com/geotools/geotools/pull/2832

for GeoServer: https://github.com/geoserver/geoserver/pull/4119

Thanks, Mark


Geoserver-users mailing list

Please make sure you read the following two resources before posting to this list:

If you want to request a feature or an improvement, also see this: https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer

Geoserver-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-users


Geoserver-users mailing list

Please make sure you read the following two resources before posting to this list:

If you want to request a feature or an improvement, also see this: https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer

Geoserver-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-users

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.


Geoserver-users mailing list

Please make sure you read the following two resources before posting to this list:

If you want to request a feature or an improvement, also see this: https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer

Geoserver-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-users

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.


GeoTools-GT2-Users mailing list
GeoTools-GT2-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-gt2-users

Short term we only need to run it once, to test this PR :slight_smile:

Long term it would be great to setup an oracle test job on our community jenkins build server (as has been done for other databases).

···


Jody Garnett

For environments requiring setup (MongoDB, Oracle, Elasticsearch) the is really a team effort where we rely on our community to test release candidates, and in this case review a pull request.

In this specific case, if we had a volunteer to setup an online test (using Oracle XE) we would be able to provide faster / better service with lower effort. The test provides its own data and is setup with this environment in mind.

As Andrea indicated we lack a passionate module maintainer for Oracle, if you two have knowledge on this is a great opportunity to take part.

···


Jody Garnett

Passionate being the keyword, as in, someone that would use their spare time. Oracle is covered, but only during working hours, under contract.
The issue we’re having here is that a review is needed, which implies among other things running tests, but there is no contract covering it and
allowing usage of work hours, leaving it to the good will of those that would use their spare time to setup Oracle, run the tests, review the changes.

···

Regards, Andrea Aime

== GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

something along the following should do for creating an integration test schema for Geotools (your DBA may disagree with this, it’s what they do, especially when it comes to Oracle DBA’s):

– create user GEOTOOLS with password “geotools” using defined tablespaces
CREATE USER “GEOTOOLS” IDENTIFIED BY “geotools”
DEFAULT TABLESPACE “DATA_TS”
TEMPORARY TABLESPACE “TEMP”

– grant roles
GRANT “CONNECT” TO “GEOTOOLS”
GRANT “RESOURCE” TO “GEOTOOLS”

– system grants
GRANT CREATE SESSION TO “GEOTOOLS”
GRANT ALTER SESSION TO “GEOTOOLS”
GRANT UNLIMITED TABLESPACE TO “GEOTOOLS”
GRANT CREATE TABLE TO “GEOTOOLS”
GRANT CREATE SYNONYM TO “GEOTOOLS”
GRANT CREATE VIEW TO “GEOTOOLS”
GRANT CREATE SEQUENCE TO “GEOTOOLS”
GRANT CREATE PROCEDURE TO “GEOTOOLS”
GRANT CREATE TRIGGER TO “GEOTOOLS”
GRANT CREATE MATERIALIZED VIEW TO “GEOTOOLS”

GRANT CREATE OPERATOR TO “GEOTOOLS”

And then in your ~/.geotools a file called “oracle.properties” with the following content:

user=geotools
username=geotools
password=geotools
schema=GEOTOOLS
dbtype=Oracle
database=orcl
host=192.168.1.11
port=1521

url=jdbc:oracle:thin:@192.168.1.11:1521:orcl
driver=oracle.jdbc.OracleDriver

You’ll need to change the IPadress and database instance in there ofcourse

running the test locally can be accompished using:
mvn clean install -Dall -pl :gt-jdbc-oracle -Ponline -Doracle=true (for master branch)

and
mvn clean install -Dall -pl :gt-jdbc-oracle -Ponline (for feature branch, as the oracle property was removed)

···

Disclaimer;
This message is just a reflection of what I thought at the time of sending. The message may contain information that is not intended for you or that you don’t understand.

Hi Mark,
thanks for the update… maybe that should be in a README for the module, indicated as a suggestion.
Thinking out loud about our current predicament… one way to solve it, would be to add a gihub action running
a oracle VM, and running the tests, similar to the one I recently added for PostGIS:

https://github.com/geotools/geotools/blob/master/.github/workflows/postgis_online.yml

I cannot find an action spinning up Oracle, but this SO entry seems to suggest one can run random docker images too:
https://stackoverflow.com/questions/57549439/how-do-i-use-docker-with-github-actions

This one could be useful too:
https://help.github.com/en/actions/building-actions/creating-a-docker-container-action

If something like this could be setup, it would solve all future issues regarding running Oracle tests for PRs.

Cheers
Andrea

···

Regards, Andrea Aime

== GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.