[Geoserver-users] Removing workspaces twice

Hi All,
I'm recently testing jdbcconfig (on geoserver 2.10, 2.9, 2,8), and I discover
an interesting thing related workspaces remove function: it is called twice!

At beginning, I thought it was a bug of jdbcconfig, but today I got a confirm
that two calls are in geoserver code.

To verify that, is enough to add a

System.out.println("Removing Workspace");

in CatalogImpl.java (package org.geoserver.catalog.impl) at line 1212, compile
and deploy.
After that, run application server (tomcat 8 for me), create a workspace and
remove that. On catalina.out, you should see the message twice.

Using geoserver, this is not a bug, but in jdbcconfig there is

findObjectId(...)

at line 592 of ConfigDatabase.java, that fails on the second call, because
there isn't the workspace.

Before proposing a patch, I'd like to understand why there are two calls to
remove method (may be there's a good reason, but actually I can't see it).
Depending on it, which idea is better: remove duplicated call or allow
removing not existing workspaces without generating an exception.

Cheers.

.Federico C Guizzardi

_

abstract.it
...............................................................................
Registro Imprese di Napoli 788429 / Cap. Soc. 10.000 Euro I.V. Avvertenze
Legali - D. Lgs. 196/03 Tutela dei dati personali. Le informazioni contenute
in questo messaggio e in ogni eventuale allegato sono riservate e ne è vietata
ogni forma di diffusione. Se avete ricevuto questa comunicazione per errore,
Vi preghiamo di informare immediatamente il mittente del messaggio e di
eliminare l'e-mail.

Hi Federico,
trying to remove twice seems like a bug, do you have the stack traces of the
two invocations, or a description of where they are coming from?

Cheers
Andrea

···

On Wed, May 18, 2016 at 10:20 AM, Federico C.Guizzardi <cippinofg@anonymised.com> wrote:

Hi All,
I’m recently testing jdbcconfig (on geoserver 2.10, 2.9, 2,8), and I discover
an interesting thing related workspaces remove function: it is called twice!

At beginning, I thought it was a bug of jdbcconfig, but today I got a confirm
that two calls are in geoserver code.

To verify that, is enough to add a

System.out.println(“Removing Workspace”);

in CatalogImpl.java (package org.geoserver.catalog.impl) at line 1212, compile
and deploy.
After that, run application server (tomcat 8 for me), create a workspace and
remove that. On catalina.out, you should see the message twice.

Using geoserver, this is not a bug, but in jdbcconfig there is

findObjectId(…)

at line 592 of ConfigDatabase.java, that fails on the second call, because
there isn’t the workspace.

Before proposing a patch, I’d like to understand why there are two calls to
remove method (may be there’s a good reason, but actually I can’t see it).
Depending on it, which idea is better: remove duplicated call or allow
removing not existing workspaces without generating an exception.

Cheers.

.Federico C Guizzardi

_
abstract.it

Registro Imprese di Napoli 788429 / Cap. Soc. 10.000 Euro I.V. Avvertenze
Legali - D. Lgs. 196/03 Tutela dei dati personali. Le informazioni contenute
in questo messaggio e in ogni eventuale allegato sono riservate e ne è vietata
ogni forma di diffusione. Se avete ricevuto questa comunicazione per errore,
Vi preghiamo di informare immediatamente il mittente del messaggio e di
eliminare l’e-mail.


Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j


Geoserver-users mailing list
Geoserver-users@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-users

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


In attach

trace_delete_bug (3.58 KB)

···

On Wed, May 18, 2016 at 11:38 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi Federico,
trying to remove twice seems like a bug, do you have the stack traces of the
two invocations, or a description of where they are coming from?

Cheers
Andrea

On Wed, May 18, 2016 at 10:20 AM, Federico C.Guizzardi <cippinofg@anonymised.com> wrote:

Hi All,
I’m recently testing jdbcconfig (on geoserver 2.10, 2.9, 2,8), and I discover
an interesting thing related workspaces remove function: it is called twice!

At beginning, I thought it was a bug of jdbcconfig, but today I got a confirm
that two calls are in geoserver code.

To verify that, is enough to add a

System.out.println(“Removing Workspace”);

in CatalogImpl.java (package org.geoserver.catalog.impl) at line 1212, compile
and deploy.
After that, run application server (tomcat 8 for me), create a workspace and
remove that. On catalina.out, you should see the message twice.

Using geoserver, this is not a bug, but in jdbcconfig there is

findObjectId(…)

at line 592 of ConfigDatabase.java, that fails on the second call, because
there isn’t the workspace.

Before proposing a patch, I’d like to understand why there are two calls to
remove method (may be there’s a good reason, but actually I can’t see it).
Depending on it, which idea is better: remove duplicated call or allow
removing not existing workspaces without generating an exception.

Cheers.

.Federico C Guizzardi

_
abstract.it

Registro Imprese di Napoli 788429 / Cap. Soc. 10.000 Euro I.V. Avvertenze
Legali - D. Lgs. 196/03 Tutela dei dati personali. Le informazioni contenute
in questo messaggio e in ogni eventuale allegato sono riservate e ne è vietata
ogni forma di diffusione. Se avete ricevuto questa comunicazione per errore,
Vi preghiamo di informare immediatamente il mittente del messaggio e di
eliminare l’e-mail.


Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j


Geoserver-users mailing list
Geoserver-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-users

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


dott. Federico Guizzardi
Abstract s.r.l.