Hi Martin and Markus,
The logs about building addons are not updated. I’m also not sure about addons manual pages. I think that i.theilsen from yesterday should be visible but it is not. Is this related? I though that it is not. The logs are recent just the overall log is outdated.
Vaclav
http://wingrass.fsv.cvut.cz/grass70/addons/grass-7.0.0svn/logs/ALL.html
http://wingrass.fsv.cvut.cz/grass70/addons/grass-7.0.0svn/logs/
http://grass.osgeo.org/grass70/manuals/addons/
Hi,
2014-12-07 19:26 GMT+01:00 Vaclav Petras <wenzeslaus@gmail.com>:
The logs about building addons are not updated. I'm also not sure about
addons manual pages. I think that i.theilsen from yesterday should be
visible but it is not. Is this related? I though that it is not. The logs
are recent just the overall log is outdated.
http://wingrass.fsv.cvut.cz/grass70/addons/grass-7.0.0svn/logs/
http://grass.osgeo.org/grass70/manuals/addons/
should be fixed now. Martin
--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa
Thanks for the Martin.
On Mon, Dec 8, 2014 at 8:09 AM, Martin Landa <landa.martin@gmail.com> wrote:
The addons manual pages are still not built for some addons. I haven't
checked all but I checked the recent ones. The page claims to be updated
daily and the date I see in page info actually is Mon 08 Dec 2014 09:05:01
PM EST. Is there a log somewhere? Or some list where the modules should be
added?
http://grass.osgeo.org/grass70/manuals/addons/v.surf.nnbathy.html
http://grass.osgeo.org/grass70/manuals/addons/r.surf.nnbathy.html
(http://grass.osgeo.org/grass70/manuals/addons/m.surf.nnbathy.html)
http://grass.osgeo.org/grass70/manuals/addons/i.theilsen.html
http://grass.osgeo.org/grass70/manuals/addons/r.futures.html
http://trac.osgeo.org/grass/browser/grass-addons/grass7/misc/m.surf.nnbathy
http://trac.osgeo.org/grass/browser/grass-addons/grass7/imagery/i.theilsen
http://trac.osgeo.org/grass/browser/grass-addons/grass7/raster/r.futures
By the way, I'm wondering if m.surf.nnbathy is the right choice of name.
There is no standard for two different modules in one directory but
m.surf.nnbathy looks like a module name but is not. For example, r.colors
contains also r3.colors. That's not ideal but it does not introduce false
module name m.colors (m if for misc not mix anyway).
Hi Vaclav,
2014-12-09 20:27 GMT+01:00 Vaclav Petras <wenzeslaus@gmail.com>:
The addons manual pages are still not built for some addons. I haven't
checked all but I checked the recent ones. The page claims to be updated
daily and the date I see in page info actually is Mon 08 Dec 2014 09:05:01
PM EST. Is there a log somewhere? Or some list where the modules should be
added?http://grass.osgeo.org/grass70/manuals/addons/v.surf.nnbathy.html
http://grass.osgeo.org/grass70/manuals/addons/r.surf.nnbathy.html
(http://grass.osgeo.org/grass70/manuals/addons/m.surf.nnbathy.html)
http://grass.osgeo.org/grass70/manuals/addons/i.theilsen.html
http://grass.osgeo.org/grass70/manuals/addons/r.futures.htmlhttp://trac.osgeo.org/grass/browser/grass-addons/grass7/misc/m.surf.nnbathy
http://trac.osgeo.org/grass/browser/grass-addons/grass7/imagery/i.theilsen
http://trac.osgeo.org/grass/browser/grass-addons/grass7/raster/r.futures
now should be OK. The manual has been updated for long time. I have
fixed all scripts.
By the way, I'm wondering if m.surf.nnbathy is the right choice of name.
There is no standard for two different modules in one directory but
m.surf.nnbathy looks like a module name but is not. For example, r.colors
contains also r3.colors. That's not ideal but it does not introduce false
module name m.colors (m if for misc not mix anyway).
Hm, I just wonder what name would be better v.surf.nnbathy or r.surf.nnbathy...
Martin
--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa
On Thu, Dec 11, 2014 at 5:39 AM, Martin Landa <landa.martin@gmail.com>
wrote:
Hi Vaclav,
2014-12-09 20:27 GMT+01:00 Vaclav Petras <wenzeslaus@gmail.com>:
> The addons manual pages are still not built for some addons. I haven't
> checked all but I checked the recent ones. The page claims to be updated
> daily and the date I see in page info actually is Mon 08 Dec 2014
09:05:01
> PM EST. Is there a log somewhere? Or some list where the modules should
be
> added?
>
> http://grass.osgeo.org/grass70/manuals/addons/v.surf.n
<http://grass.osgeo.org/grass70/manuals/addons/v.surf.nnbathy.html>
trac.osgeo.org/grass/browser/grass-addons/tools/addonsnbathy.html
<http://grass.osgeo.org/grass70/manuals/addons/v.surf.nnbathy.html>
> http://grass.osgeo.org/grass70/manuals/addons/r.surf.nnbathy.html
> (http://grass.osgeo.org/grass70/manuals/addons/m.surf.nnbathy.html)
> http://grass.osgeo.org/grass70/manuals/addons/i.theilsen.html
> http://grass.osgeo.org/grass70/manuals/addons/r.futures.html
>
>
http://trac.osgeo.org/grass/browser/grass-addons/grass7/misc/m.surf.nnbathy
>
http://trac.osgeo.org/grass/browser/grass-addons/grass7/imagery/i.theilsen
> http://trac.osgeo.org/grass/browser/grass-addons/grass7/raster/r.futuresnow should be OK. The manual has been updated for long time. I have
fixed all scripts.
Thanks. It's good to know that you provided all scripts to build addons.
http://trac.osgeo.org/grass/browser/grass-addons/tools/addons?rev=63481
> By the way, I'm wondering if m.surf.nnbathy is the right choice of name.
> There is no standard for two different modules in one directory but
> m.surf.nnbathy looks like a module name but is not. For example, r.colors
> contains also r3.colors. That's not ideal but it does not introduce false
> module name m.colors (m if for misc not mix anyway).Hm, I just wonder what name would be better v.surf.nnbathy or
r.surf.nnbathy...
Me too but I guess that any of them will do. I don't know what is more
native from the point of view of the modules, this could be one way how to
decide. The other is what is the common use case (at least from the point
of view of the author). I would say that it is v.surf.nnbathy would be the
more used one, you usually interpolate points.
Martin
--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa
Hi,
Why can't you just present two different modules ? I know that they have
common code, but is it such a problem to have redundancy in addons ?
yes, the main reason is the code redundancy [1].
In any case, if these modules work well, I would plead for including them
into the main distribution as the functionality is quite important in my
eyes.
The modules were just rewritten from Bash to Python, they still call
`nnbathy` on background. So there is no way to include them to the
main distribution. Anyway Adam (cc'ed, author of new Python modules)
started to work on the native implementation of natural neighbor for
GRASS probably partly based on nn-c lib (MIT licence).
If you really have to chose, I would probably agree with Vaclav and prefer
v.surf.nnbathy.
I would agree. I will rename module right now. Martin
[1] http://trac.osgeo.org/grass/browser/grass-addons/grass7/misc/m.surf.nnbathy/libnnbathy/nnbathy.py#L5
--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa
Hi,
2014-12-12 12:17 GMT+01:00 Martin Landa <landa.martin@gmail.com>:
If you really have to chose, I would probably agree with Vaclav and prefer
v.surf.nnbathy.I would agree. I will rename module right now. Martin
I split the modules to `raster/r.surf.nnbathy` (*) and
`vector/v.surf.nnbathy`. The module `r.surf.nnbathy` now requires to
install also `v.surf.nnbathy`.
$ g.extension r.surf.nnbathy
$ r.surf.nnbathy in=x out=y
ERROR: r.surf.nnbathy requires 'v.surf.nnbathy'. Please install this
module by running:
g.extension v.surf.nnbathy
$g.extension v.surf.nnbathy
r.surf.nnbathy in=x out=y
...
Enjoy, Martin
(*) I discovered that addons in G7 contained bash version of
r.surf.nnbathy. I have happily removed it and replaced by Python
version.
--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa