[GRASS-dev] addons dependencies

Hi all,

one student of mine rewrote `r.surf.nnbathy` and `v.surf.nnbathy` to
Python for GRASS 7. The modules are using it's own little python
library/module to perform computation. I wonder how to deal with such
issues in addons regarding `g.extension`. I can see two options:

1) to put both modules and lib to one place, where ? (raster X vector)
2) put `r.surf.nnbathy` to raster and `v.surf.nnbathy` to vector
2a) where to put lib (/lib?) and how to install it via g.extension

The second option would require to introduce into g.extension some
mechanism of dependencies.

Any idea, opinion? Thanks in advance, Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa

On 05/11/14 10:38, Martin Landa wrote:

Hi all,

one student of mine rewrote `r.surf.nnbathy` and `v.surf.nnbathy` to
Python for GRASS 7. The modules are using it's own little python
library/module to perform computation. I wonder how to deal with such
issues in addons regarding `g.extension`. I can see two options:

1) to put both modules and lib to one place, where ? (raster X vector)
2) put `r.surf.nnbathy` to raster and `v.surf.nnbathy` to vector
2a) where to put lib (/lib?) and how to install it via g.extension

The second option would require to introduce into g.extension some
mechanism of dependencies.

Any idea, opinion?

No opinion, but there is a similar problem just with files in the same directory:

see #2480.

And I just tried v.in.wfs2: g.extension does not give an error message during installation, but it only installs the v.in.wfs2.py file, not the other files and so when I run it, I get

v.in.wfs2 url=http://geoserver.gis.irisnet.be/urbis/wfs layers=Municipalities output=comm
Traceback (most recent call last):
   File
"/data/home/mlennert/SRC/GRASS/grass70release/dist.x86_64
-unknown-linux-gnu/scripts/v.in.wfs2", line 129, in <module>
     sys.exit(main())
   File
"/data/home/mlennert/SRC/GRASS/grass70release/dist.x86_64
-unknown-linux-gnu/scripts/v.in.wfs2", line 113, in main
     from wfs_drv import WFSDrv
ImportError: No module named wfs_drv

I'm no Makefile expert and don't know how these errors can be solved (but would have loved to have my students install v.class.ml on Monday morning :wink: ).

Moritz

Hi,

2014-11-07 13:33 GMT+01:00 Moritz Lennert <mlennert@club.worldonline.be>:

[...]

And I just tried v.in.wfs2: g.extension does not give an error message
during installation, but it only installs the v.in.wfs2.py file, not the
other files and so when I run it, I get

v.in.wfs2 url=http://geoserver.gis.irisnet.be/urbis/wfs
layers=Municipalities output=comm
Traceback (most recent call last):
  File
"/data/home/mlennert/SRC/GRASS/grass70release/dist.x86_64
-unknown-linux-gnu/scripts/v.in.wfs2", line 129, in <module>
    sys.exit(main())
  File
"/data/home/mlennert/SRC/GRASS/grass70release/dist.x86_64
-unknown-linux-gnu/scripts/v.in.wfs2", line 113, in main
    from wfs_drv import WFSDrv
ImportError: No module named wfs_drv

please try out r63275. Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa

On 28/11/14 23:41, Martin Landa wrote:

Hi,

2014-11-07 13:33 GMT+01:00 Moritz Lennert <mlennert@club.worldonline.be>:

[...]

And I just tried v.in.wfs2: g.extension does not give an error message
during installation, but it only installs the v.in.wfs2.py file, not the
other files and so when I run it, I get

v.in.wfs2 url=http://geoserver.gis.irisnet.be/urbis/wfs
layers=Municipalities output=comm
Traceback (most recent call last):
   File
"/data/home/mlennert/SRC/GRASS/grass70release/dist.x86_64
-unknown-linux-gnu/scripts/v.in.wfs2", line 129, in <module>
     sys.exit(main())
   File
"/data/home/mlennert/SRC/GRASS/grass70release/dist.x86_64
-unknown-linux-gnu/scripts/v.in.wfs2", line 113, in main
     from wfs_drv import WFSDrv
ImportError: No module named wfs_drv

please try out r63275. Martin

v.in.wfs2 now runs (although it bails out because of the recent change in parameters (v.in.ogr dsn -> input).

v.class.ml does not work:

g.extension extension=v.class.ml svnurl=http://svn.osgeo.org/grass/grass-addons/grass7
Fetching <v.class.ml> from GRASS-Addons SVN repository (be patient)...
Compiling...
Traceback (most recent call last):
   File "/tmp/tmpkEQYEu/v.class.ml/scripts/v.class.ml", line
387, in <module>
     from training_extraction import extract_training
ImportError: No module named training_extraction
make: *** [v.class.ml.tmp.html] Error 1
ERROR: Compilation failed, sorry. Please check above error messages.

Makefiles are different between the two, so maybe the issue is a wrong Makefile for v.class.ml. However, running "make MODULE_TOPDIR=xyz" from the grass-addons svn tree works...

Moritz

On Mon, Dec 1, 2014 at 4:18 PM, Moritz Lennert
<mlennert@club.worldonline.be> wrote:

On 28/11/14 23:41, Martin Landa wrote:

...

please try out r63275. Martin

v.in.wfs2 now runs (although it bails out because of the recent change in
parameters (v.in.ogr dsn -> input).

I thought that this would be caught by the updated parser magic via
lib/gis/renamed_options?
Ah, v.in.ogr wasn't registered yet, so done in r63317 (and r63318 respectively).

Please try again,

Markus

On 01/12/14 18:07, Markus Neteler wrote:

On Mon, Dec 1, 2014 at 4:18 PM, Moritz Lennert
<mlennert@club.worldonline.be> wrote:

On 28/11/14 23:41, Martin Landa wrote:

...

please try out r63275. Martin

v.in.wfs2 now runs (although it bails out because of the recent change in
parameters (v.in.ogr dsn -> input).

I thought that this would be caught by the updated parser magic via
lib/gis/renamed_options?
Ah, v.in.ogr wasn't registered yet, so done in r63317 (and r63318 respectively).

Please try again,

Yes, now it works.

Only weird thing:

v.in.wfs2 url= http://geoserver.gis.irisnet.be/ows layers=urbis:URB_A_MZ output=urbis srs=31370
Downloading data from WFS server...
Reprojecting data...
Importing vector map into GRASS...
WARNING: Please update the interface of the module: option <dsn> has been renamed to <input>

For the user it is not clear where this warning comes from as dsn in not a parameter in v.in.wfs2. But this is true for all warnings of v.in.ogr in this module, so it is a different problem.

Moritz

Hi,

2014-12-03 19:07 GMT+01:00 Moritz Lennert <mlennert@club.worldonline.be>:

v.in.wfs2 url= http://geoserver.gis.irisnet.be/ows layers=urbis:URB_A_MZ
output=urbis srs=31370
Downloading data from WFS server...
Reprojecting data...
Importing vector map into GRASS...
WARNING: Please update the interface of the module: option <dsn> has been
renamed to <input>

please try out r63362.

WARNING: Please update the user interface of <v.in.ogr>: option <dsn>
has been renamed to <input>

Is it better? Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa

On Wed, Dec 3, 2014 at 7:17 PM, Martin Landa <landa.martin@gmail.com> wrote:

2014-12-03 19:07 GMT+01:00 Moritz Lennert <mlennert@club.worldonline.be>:

v.in.wfs2 url= http://geoserver.gis.irisnet.be/ows layers=urbis:URB_A_MZ
output=urbis srs=31370
Downloading data from WFS server...
Reprojecting data...
Importing vector map into GRASS...
WARNING: Please update the interface of the module: option <dsn> has been
renamed to <input>

please try out r63362.

WARNING: Please update the user interface of <v.in.ogr>: option <dsn>
has been renamed to <input>

To me that sounds a bit misleading since we don't need to update
v.in.ogr. How about

WARNING: Please update the usage of <v.in.ogr>: option <dsn> has been
renamed to <input>
?

Markus

Hi,

2014-12-04 8:36 GMT+01:00 Markus Neteler <neteler@osgeo.org>:

To me that sounds a bit misleading since we don't need to update
v.in.ogr. How about

WARNING: Please update the usage of <v.in.ogr>: option <dsn> has been
renamed to <input>

right, it's seems to be better, done in r63367. I can backport it to
relbr70 if it's OK for you.

Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa

On Thu, Dec 4, 2014 at 9:20 AM, Martin Landa <landa.martin@gmail.com> wrote:

2014-12-04 8:36 GMT+01:00 Markus Neteler <neteler@osgeo.org>:

To me that sounds a bit misleading since we don't need to update
v.in.ogr. How about

WARNING: Please update the usage of <v.in.ogr>: option <dsn> has been
renamed to <input>

right, it's seems to be better, done in r63367. I can backport it to
relbr70 if it's OK for you.

Yes. We can further finetune if needed.

thanks
Markus

On 04/12/14 13:08, Markus Neteler wrote:

On Thu, Dec 4, 2014 at 9:20 AM, Martin Landa <landa.martin@gmail.com> wrote:

2014-12-04 8:36 GMT+01:00 Markus Neteler <neteler@osgeo.org>:

To me that sounds a bit misleading since we don't need to update
v.in.ogr. How about

WARNING: Please update the usage of <v.in.ogr>: option <dsn> has been
renamed to <input>

right, it's seems to be better, done in r63367. I can backport it to
relbr70 if it's OK for you.

Yes. We can further finetune if needed.

+1

Thanks !

Moritz

FYI, the QGIS Processing plugin does not work when accessing GRASS 7 tools because of the error shown below.

Robert Moskovitz
California Geological Survey
Seismic Hazards Zonation Program

CONFIDENTIALITY NOTICE: This communication is intended only for the use of the individual or entity to which it is addressed. This message contains information from the State of California, California Geological Survey, which may be privileged, confidential and exempt from disclosure under applicable law, including the Electronic Communications Privacy Act. If the reader of this communication is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this communication is strictly prohibited.

-----Original Message-----
From: grass-dev-bounces@lists.osgeo.org [mailto:grass-dev-bounces@lists.osgeo.org] On Behalf Of Markus Neteler
Sent: Wednesday, December 3, 2014 11:37 PM
To: Martin Landa
Cc: GRASS developers list
Subject: Re: [GRASS-dev] addons dependencies

On Wed, Dec 3, 2014 at 7:17 PM, Martin Landa <landa.martin@gmail.com> wrote:

2014-12-03 19:07 GMT+01:00 Moritz Lennert <mlennert@club.worldonline.be>:

v.in.wfs2 url= http://geoserver.gis.irisnet.be/ows layers=urbis:URB_A_MZ
output=urbis srs=31370
Downloading data from WFS server...
Reprojecting data...
Importing vector map into GRASS...
WARNING: Please update the interface of the module: option <dsn> has been
renamed to <input>

please try out r63362.

WARNING: Please update the user interface of <v.in.ogr>: option <dsn>
has been renamed to <input>

To me that sounds a bit misleading since we don't need to update
v.in.ogr. How about

WARNING: Please update the usage of <v.in.ogr>: option <dsn> has been
renamed to <input>
?

Markus
_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

On Thu, Dec 4, 2014 at 6:30 PM, Moskovitz, Bob@DOC
<Bob.Moskovitz@conservation.ca.gov> wrote:

FYI, the QGIS Processing plugin does not work when accessing GRASS 7 tools because of the error shown below.

I have now suggested a fix as per
https://github.com/qgis/QGIS/pull/1720

Ideally someone would use our lookup table at
http://trac.osgeo.org/grass/browser/grass/trunk/lib/gis/renamed_options
and just update all the QGIS Processing plugin description automatically.

Markus