[GRASS-dev] Addons manuals: logo and CSS file missing

GRASS GRASS developer
1

Hi Martin,

since the switch to use G76 as the basis for the addon manual pages,
the two files
grassdocs.css
grass_logo.png
are no longer put onto the server.

I suspect that they are not picked up on the build server:

grass-addons/tools/addons/grass-addons-build.sh" line 38 of 59
    cp ${SRC}/grass${1}${2}_release/${DIST}/docs/html/grassdocs.css $HTMLDIR/
    cp ${SRC}/grass${1}${2}_release/${DIST}/docs/html/grass_logo.png $HTMLDIR/

Could you please verify?

thanks
Markus

2

On Wed, Apr 24, 2019 at 4:28 PM Markus Neteler <neteler@osgeo.org> wrote:

Hi Martin,

since the switch to use G76 as the basis for the addon manual pages,
the two files
grassdocs.css
grass_logo.png
are no longer put onto the server.

I suspect that they are not picked up on the build server:

grass-addons/tools/addons/grass-addons-build.sh" line 38 of 59
cp ${SRC}/grass${1}${2}_release/${DIST}/docs/html/grassdocs.css $HTMLDIR/
cp ${SRC}/grass${1}${2}_release/${DIST}/docs/html/grass_logo.png $HTMLDIR/

The reason is probably that the installation directory has been changed to include the bugfix release number in r74038, the culprit is probably the change in configure.in:L219 [0] which needs to be reverted.

Markus M

[0] https://trac.osgeo.org/grass/changeset/74038/grass/branches/releasebranch_7_6/configure.in

Could you please verify?

thanks
Markus

grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

3

Hi,

st 24. 4. 2019 v 16:28 odesílatel Markus Neteler <neteler@osgeo.org> napsal:

Could you please verify?

yes, the reason is that G76 is not compiled on server due to a new
required dependency:

configure: error: *** Unable to locate zstd includes.

I will fix it ASAP. Ma

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

4

On Thu, Apr 25, 2019 at 7:42 AM Martin Landa <landa.martin@gmail.com> wrote:

Hi,

st 24. 4. 2019 v 16:28 odesílatel Markus Neteler <neteler@osgeo.org> napsal:

Could you please verify?

yes, the reason is that G76 is not compiled on server due to a new
required dependency:

configure: error: *** Unable to locate zstd includes.

zstd is not a required dependency, you can disable it with --with-zstd=no

Markus M

I will fix it ASAP. Ma

–
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

5

Hi,

čt 25. 4. 2019 v 7:56 odesílatel Markus Metz
<markus.metz.giswork@gmail.com> napsal:

zstd is not a required dependency, you can disable it with --with-zstd=no

right, I meant "by default enabled dependency" :slight_smile: Ma

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

6

Hi,

čt 25. 4. 2019 v 7:41 odesílatel Martin Landa <landa.martin@gmail.com> napsal:

I will fix it ASAP. Ma

fixed, see eg. https://grass.osgeo.org/grass76/manuals/addons/db.join.html

Ma

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

7

On 25/04/19 07:56, Markus Metz wrote:

On Thu, Apr 25, 2019 at 7:42 AM Martin Landa <landa.martin@gmail.com <mailto:landa.martin@gmail.com>> wrote:
>
> Hi,
>
> st 24. 4. 2019 v 16:28 odesílatel Markus Neteler <neteler@osgeo.org <mailto:neteler@osgeo.org>> napsal:
> > Could you please verify?
>
> yes, the reason is that G76 is not compiled on server due to a new
> required dependency:
>
> configure: error: *** Unable to locate zstd includes.

zstd is not a required dependency, you can disable it with --with-zstd=no

This is the issue I raised with #3815. I don't think it is a good idea to use something as default if it is not a required dependency. As I described this can lead to the issue that without the user knowing it (e.g. using GRASS GIS that was compiled by someone (package manager, etc) with --with-zstd=yes) she creates raster maps that are compressed with zstd. If these maps are then moved to a machine that doesn't have zstd, the data is unusable.

That is why I proposed to make it a requirement. The other alternative, IMHO, would be to make ZLIB the default compression again and leave the use of ZSTD to power users.

Moritz