[GRASS-dev] broken API

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all.
While compiling qgis, I noticed that GRASS API has been broken:
http://freegis.org/cgi-bin/viewcvs.cgi/grass6/include/version.h.in.diff?r1=1.4&r2=1.5
As a result, QGIS can no longer be compiled with GRASS support. Are
these changes really necessary?
All the best.
pc
- --
Paolo Cavallini
http://www.faunalia.it/pc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGMHK2/NedwLUzIr4RAnkUAKCkat9NHrWXbxNZiACLNSrJuK2giwCfTSlj
Zhfj1q4SIjKkyNADu9oitgE=
=vJFF
-----END PGP SIGNATURE-----

Paolo Cavallini wrote on 04/26/2007 11:36 AM:

Hi all.
While compiling qgis, I noticed that GRASS API has been broken:
http://freegis.org/cgi-bin/viewcvs.cgi/grass6/include/version.h.in.diff?r1=1.4&r2=1.5
As a result, QGIS can no longer be compiled with GRASS support. Are
these changes really necessary?
All the best.
pc

The question is if the change keeps backwards compatibility for
GDAL, QGIS and other applications which rely on this file.

Markus

------------------
ITC -> dall'1 marzo 2007 Fondazione Bruno Kessler
ITC -> since 1 March 2007 Fondazione Bruno Kessler
------------------

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

for qgis, it does not
pc

Markus Neteler ha scritto:

The question is if the change keeps backwards compatibility for
GDAL, QGIS and other applications which rely on this file.

Markus

- --
Paolo Cavallini
http://www.faunalia.it/pc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGMKtP/NedwLUzIr4RAgA7AJ9I2I3rlB8/x/O0gl0jNT2ZG1vIYQCfZMdV
L34YIu7khLPOuVWbCD9oc/k=
=4QXv
-----END PGP SIGNATURE-----

Paolo Cavallini wrote:

While compiling qgis, I noticed that GRASS API has been broken:
http://freegis.org/cgi-bin/viewcvs.cgi/grass6/include/version.h.in.diff?r1=1.4&r2=1.5

No, the original API was broken; it has now been fixed.

As a result, QGIS can no longer be compiled with GRASS support. Are
these changes really necessary?

Yes. If they weren't done before 6.3.0 is released, we would be stuck
with the original verion for the lifetime of the 6.3.x. branch.

--
Glynn Clements <glynn@gclements.plus.com>

Markus Neteler wrote:

The question is if the change keeps backwards compatibility for
GDAL, QGIS and other applications which rely on this file.

Since gdal-grass plugin fails to build with 6.3 CVS too, will r.out.gdal in
6.3 CVS work when I build the plugin against 6.2.2 CVS, and keep both 6.2.2
and 6.3 installed?

Maciek

--
View this message in context: http://www.nabble.com/broken-API-tf3650628.html#a10216768
Sent from the Grass - Dev mailing list archive at Nabble.com.

Maciej Sieczka wrote on 04/27/2007 12:31 PM:

Markus Neteler wrote:

The question is if the change keeps backwards compatibility for
GDAL, QGIS and other applications which rely on this file.
    
Since gdal-grass plugin fails to build with 6.3 CVS too,

It now compiles again (gdal-grass plugin in the GDAL SVN).

will r.out.gdal in
6.3 CVS work when I build the plugin against 6.2.2 CVS, and keep both 6.2.2
and 6.3 installed?
  

No idea...

Markus

------------------
ITC -> dall'1 marzo 2007 Fondazione Bruno Kessler
ITC -> since 1 March 2007 Fondazione Bruno Kessler
------------------

Maciej Sieczka wrote:

> The question is if the change keeps backwards compatibility for
> GDAL, QGIS and other applications which rely on this file.

Since gdal-grass plugin fails to build with 6.3 CVS too, will r.out.gdal in
6.3 CVS work when I build the plugin against 6.2.2 CVS, and keep both 6.2.2
and 6.3 installed?

In 6.2, r.out.gdal is a script which uses gdal_translate, so it
requires a GRASS-enabled GDAL. In 6.3, r.out.gdal is a C program which
only uses GDAL for the output side, so it doesn't matter whether GDAL
has GRASS support.

So, the 6.3 version of r.out.gdal won't use GDAL's GRASS support
unless you use it to export to GRASS (why would you want to do that?).

--
Glynn Clements <glynn@gclements.plus.com>

Glynn Clements wrote:

Maciej Sieczka wrote:

The question is if the change keeps backwards compatibility for
GDAL, QGIS and other applications which rely on this file.

Since gdal-grass plugin fails to build with 6.3 CVS too, will r.out.gdal in
6.3 CVS work when I build the plugin against 6.2.2 CVS, and keep both 6.2.2
and 6.3 installed?

In 6.2, r.out.gdal is a script which uses gdal_translate, so it
requires a GRASS-enabled GDAL. In 6.3, r.out.gdal is a C program which
only uses GDAL for the output side, so it doesn't matter whether GDAL
has GRASS support.

Right. I forgot.

So, the 6.3 version of r.out.gdal won't use GDAL's GRASS support
unless you use it to export to GRASS (why would you want to do that?).

:).

Maciek

On Thu, Apr 26, 2007 at 11:36:54AM +0200, Paolo Cavallini wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all.
While compiling qgis, I noticed that GRASS API has been broken:
http://freegis.org/cgi-bin/viewcvs.cgi/grass6/include/version.h.in.diff?r1=1.4&r2=1.5
As a result, QGIS can no longer be compiled with GRASS support.

https://svn.qgis.org/trac/ticket/712

It has been fixed last night in QGIS SVN HEAD.
You need to fixed GRASS-GDAL-Plugin from GDAL SVN HEAD, too
(for raster support). A new plugin will be released soon:
http://trac.osgeo.org/gdal/ticket/1587

Apparently things are operational again.

Markus

Markus Neteler wrote:

On Thu, Apr 26, 2007 at 11:36:54AM +0200, Paolo Cavallini wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all.
While compiling qgis, I noticed that GRASS API has been broken:
http://freegis.org/cgi-bin/viewcvs.cgi/grass6/include/version.h.in.diff?r1=1.4&r2=1.5
As a result, QGIS can no longer be compiled with GRASS support.

https://svn.qgis.org/trac/ticket/712

It has been fixed last night in QGIS SVN HEAD.

Still broken for QGIS 0.8.1 to-be-relased "stable" branch, though.

Maciek

On Wed, May 02, 2007 at 05:25:57PM +0200, Maciej Sieczka wrote:

Markus Neteler wrote:
> On Thu, Apr 26, 2007 at 11:36:54AM +0200, Paolo Cavallini wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hi all.
>> While compiling qgis, I noticed that GRASS API has been broken:
>> http://freegis.org/cgi-bin/viewcvs.cgi/grass6/include/version.h.in.diff?r1=1.4&r2=1.5
>> As a result, QGIS can no longer be compiled with GRASS support.
>
> https://svn.qgis.org/trac/ticket/712
>
> It has been fixed last night in QGIS SVN HEAD.

Still broken for QGIS 0.8.1 to-be-relased "stable" branch, though.

I have posted this there and re-opened ticket 712.

Markus

On Wed, May 02, 2007 at 10:47:37PM +0200, Markus Neteler wrote:

On Wed, May 02, 2007 at 05:25:57PM +0200, Maciej Sieczka wrote:
> Markus Neteler wrote:
> > On Thu, Apr 26, 2007 at 11:36:54AM +0200, Paolo Cavallini wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> Hi all.
> >> While compiling qgis, I noticed that GRASS API has been broken:
> >> http://freegis.org/cgi-bin/viewcvs.cgi/grass6/include/version.h.in.diff?r1=1.4&r2=1.5
> >> As a result, QGIS can no longer be compiled with GRASS support.
> >
> > https://svn.qgis.org/trac/ticket/712
> >
> > It has been fixed last night in QGIS SVN HEAD.
>
> Still broken for QGIS 0.8.1 to-be-relased "stable" branch, though.

I have posted this there and re-opened ticket 712.

https://svn.qgis.org/trac/ticket/712
05/03/07 14:26:22 changed by wonder

    * status changed from reopened to closed.
    * resolution set to fixed.

    Okay, I've ported it to 0.8 branch in r6925.

Also done.
Markus

Markus Neteler wrote:

On Wed, May 02, 2007 at 05:25:57PM +0200, Maciej Sieczka wrote:

Markus Neteler wrote:

On Thu, Apr 26, 2007 at 11:36:54AM +0200, Paolo Cavallini wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all.
While compiling qgis, I noticed that GRASS API has been broken:
http://freegis.org/cgi-bin/viewcvs.cgi/grass6/include/version.h.in.diff?r1=1.4&r2=1.5
As a result, QGIS can no longer be compiled with GRASS support.

https://svn.qgis.org/trac/ticket/712

It has been fixed last night in QGIS SVN HEAD.

Still broken for QGIS 0.8.1 to-be-relased "stable" branch, though.

I have posted this there and re-opened ticket 712.

The workaround has now been backported to QGIS 0.8 SVN branch. Thanks
to Martin Dobias.

Maciek