[GRASS-dev] bugs in r.shaded.relief and r.fillnulls

GRASS GIS GRASS GIS developer
1

Hi
Just realized that r.shaded.relief doesn't deal properly with the
"@mapset" names when no output map is given.
I fixed it by changing
    ELEVSHADE="${elev}.shade"
to
    ELEVSHADE="${elev%%@*}.shade"

the fixed file is attached.

Also I noticed that r.fillnulls doesn't allow input/output filenames
to have "-" or "."

Carlos

--
+-----------------------------------------------------------+
              Carlos Henrique Grohmann - Guano
  Visiting Researcher at Kingston University London - UK
  Geologist M.Sc - Doctorate Student at IGc-USP - Brazil
Linux User #89721 - carlos dot grohmann at gmail dot com
+-----------------------------------------------------------+
_________________
"Good morning, doctors. I have taken the liberty of removing Windows
95 from my hard drive."
--The winning entry in a "What were HAL's first words" contest judged
by 2001: A SPACE ODYSSEY creator Arthur C. Clarke

Can't stop the signal.

(attachments)

r.shaded.relief (6.17 KB)

2

On Wed, 2007-07-25 at 11:44 +0100, Carlos "Guâno" Grohmann wrote:

Hi
Just realized that r.shaded.relief doesn't deal properly with the
"@mapset" names when no output map is given.
I fixed it by changing
    ELEVSHADE="${elev}.shade"
to
    ELEVSHADE="${elev%%@*}.shade"

the fixed file is attached.

I'll apply to CVS if someone else hasn't already.

Also I noticed that r.fillnulls doesn't allow input/output filenames
to have "-" or "."

This is because there is an intermediate vector step. We don't allow
"-" or "." in vector file names because it breaks SQL compatibility ("-"
could be allowed, though. I don't know what the reasoning behind that
one is).

--
73, de Brad KB8UYR/6 <rez touchofmadness com>

3

Brad Douglas wrote:

> Also I noticed that r.fillnulls doesn't allow input/output filenames
> to have "-" or "."

This is because there is an intermediate vector step. We don't allow
"-" or "." in vector file names because it breaks SQL compatibility ("-"
could be allowed, though. I don't know what the reasoning behind that
one is).

The "-" character isn't valid in SQL table/column names. Trying to use
a column named "foo-bar" would be interpreted as the result of
subtracting column "bar" from column "foo".

The only characters allowed in table/column names are letters, digits,
and underscore.

--
Glynn Clements <glynn@gclements.plus.com>