[GRASS-dev] Compile errors in r.li

Markus, in case, you don;t know already, I’m getting compile errors, probably after r58850 when compiling daemon.c (even after distclean):

daemon.c:358:24: error: implicit declaration of function ‘G_easting_to_col’ is
invalid in C99 [-Werror,-Wimplicit-function-declaration]
m.f.f_ma.x = (int)G_easting_to_col(sa_e, &window);
^
daemon.c:359:24: error: implicit declaration of function ‘G_northing_to_row’ is
invalid in C99 [-Werror,-Wimplicit-function-declaration]
m.f.f_ma.y = (int)G_northing_to_row(sa_n, &window);
^
daemon.c:377:20: error: use of undeclared identifier ‘raster_’; did you mean
‘raster’?
if (strcmp(token, raster_) != 0)
^~~~~~~
raster
daemon.c:180:68: note: ‘raster’ declared here
int parseSetup(char *path, struct list *l, struct g_area *g, char *raster)
^
daemon.c:379:45: error: use of undeclared identifier ‘raster_’; did you mean
‘raster’?
%s rasterfile and not with %s "), token, raster_);
^~~~~~~
raster
daemon.c:180:68: note: ‘raster’ declared here
int parseSetup(char *path, struct list *l, struct g_area *g, char *raster)
^

(generated by clang, best viewed in monospace)

Vaclav

[r58850] https://trac.osgeo.org/grass/changeset/58850

On Mon, Feb 3, 2014 at 5:20 PM, Vaclav Petras <wenzeslaus@gmail.com> wrote:

Markus, in case, you don;t know already, I'm getting compile errors,
probably after r58850 when compiling daemon.c (even after distclean):

daemon.c:358:24: error: implicit declaration of function 'G_easting_to_col'
is
      invalid in C99 [-Werror,-Wimplicit-function-declaration]
            m.f.f_ma.x = (int)G_easting_to_col(sa_e, &window);

                                ^

Right.
The function API change
http://trac.osgeo.org/grass/changeset/40771

is missing from the documentation:
http://trac.osgeo.org/grass/wiki/Grass7/RasterLib/ListOfFunctions

and I missed to compile it before submission, sorry.

I have simply reverted r58856 in trunk, so someone else will need to
forward port the fixes from GRASS 6.

Markus

This was is even more tricky and I don’t know what is happening.

In directory man, script ./build_keywords.py fails:

Traceback (most recent call last):
File “./build_keywords.py”, line 38, in
key = “%s%s” % (key[0].upper(), key[1:])
IndexError: string index out of range

···

On Mon, Feb 3, 2014 at 12:28 PM, Markus Neteler <neteler@osgeo.org> wrote:

On Mon, Feb 3, 2014 at 5:20 PM, Vaclav Petras <wenzeslaus@gmail.com> wrote:

Markus, in case, you don;t know already, I’m getting compile errors,
probably after r58850 when compiling daemon.c (even after distclean):

daemon.c:358:24: error: implicit declaration of function ‘G_easting_to_col’
is
invalid in C99 [-Werror,-Wimplicit-function-declaration]
m.f.f_ma.x = (int)G_easting_to_col(sa_e, &window);
^

Right.
The function API change
http://trac.osgeo.org/grass/changeset/40771

is missing from the documentation:
http://trac.osgeo.org/grass/wiki/Grass7/RasterLib/ListOfFunctions

and I missed to compile it before submission, sorry.

I have simply reverted r58856 in trunk, so someone else will need to
forward port the fixes from GRASS 6.

Markus

On Tue, Feb 4, 2014 at 1:04 AM, Vaclav Petras <wenzeslaus@gmail.com> wrote:

This was is even more tricky and I don't know what is happening.

In directory man, script ./build_keywords.py fails:

Traceback (most recent call last):
  File "./build_keywords.py", line 38, in <module>
    key = "%s%s" % (key[0].upper(), key[1:])
IndexError: string index out of range

In man/build_keywords.py we need a try/except statement or so around
line 38 to let it tell us the name of the problematic module.

Markus

On Tue, Feb 4, 2014 at 7:39 AM, Markus Neteler <neteler@osgeo.org> wrote:

On Tue, Feb 4, 2014 at 1:04 AM, Vaclav Petras <wenzeslaus@gmail.com> wrote:

This was is even more tricky and I don't know what is happening.

In directory man, script ./build_keywords.py fails:

Traceback (most recent call last):
  File "./build_keywords.py", line 38, in <module>
    key = "%s%s" % (key[0].upper(), key[1:])
IndexError: string index out of range

Kindly fixed by Luca in
http://trac.osgeo.org/grass/changeset/58876

(so far emtpy lines after NAME and KEYWORD crashed the script, now
they are filtered out)

Markus