[GRASS-dev] Contributing to addons on GitHub

With the migration to GitHub, what exactly is the process for making contributions to the addons repository? Some of the documentation still covers SVN rather than git. Can I directly pull, commit, and push from master or should I make a branch and then submit a pull request?
Thanks, Brendan

Hi,

Brendan <brendan.harmon@gmail.com> schrieb am Mo., 30. Dez. 2019, 21:27:

With the migration to GitHub, what exactly is the process for making contributions to the addons repository?

Please fork, edit/add and make pull requests.

Some of the documentation still covers SVN rather than git.

Ok that should be updated accordingly.
Which docs do you refer to?

Can I directly pull, commit, and push from master or should I make a branch and then submit a pull request?

A PR is the preferred way.
If it is your own code you can also merge right away. If it is other author’s code, some feedback might be fair to be obtained (via PR) but it also depends a bit on the case.

HTH, my 0.02 cents,

Markus

Thanks, Brendan


grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Thanks. Got it.

Documentation with old instructions includes:

How to Contribute
https://trac.osgeo.org/grass/wiki/HowToContribute#SettingupthenewSVNwriteaccessafteracceptance

Submittinghttps://trac.osgeo.org/grass/wiki/Submitting#GRASSGISAddons

https://trac.osgeo.org/grass/wiki/Submitting#SubmittingcodetoSVN

How to SVN

https://trac.osgeo.org/grass/wiki/HowToSVN

The GitHub GRASS Addons repo contains SVN_HOWTO.txt
rather than a git HOWTO like https://trac.osgeo.org/grass/wiki/HowToGit
I think a link in the README to https://trac.osgeo.org/grass/wiki/HowToGit would help.

Submitting Python Code
https://trac.osgeo.org/grass/wiki/Submitting/Python

mentions svn diff which could be updated to git diff

I believe there was a discussion on the grass-dev list about using Python Black for style.
Was there a decision? That could be added to this wiki page.

-Brendan

On Mon, Dec 30, 2019 at 3:04 PM Markus Neteler <neteler@osgeo.org> wrote:

Hi,

Brendan <brendan.harmon@gmail.com> schrieb am Mo., 30. Dez. 2019, 21:27:

With the migration to GitHub, what exactly is the process for making contributions to the addons repository?

Please fork, edit/add and make pull requests.

Some of the documentation still covers SVN rather than git.

Ok that should be updated accordingly.
Which docs do you refer to?

Can I directly pull, commit, and push from master or should I make a branch and then submit a pull request?

A PR is the preferred way.
If it is your own code you can also merge right away. If it is other author’s code, some feedback might be fair to be obtained (via PR) but it also depends a bit on the case.

HTH, my 0.02 cents,

Markus

Thanks, Brendan


grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Hi,

Sorry for the late reply.

On Tue, Dec 31, 2019 at 12:03 AM Brendan <brendan.harmon@gmail.com> wrote:

Thanks. Got it.

Documentation with old instructions includes:

How to Contribute
https://trac.osgeo.org/grass/wiki/HowToContribute#SettingupthenewSVNwriteaccessafteracceptance

... yes, that needs to be done.

Submitting
https://trac.osgeo.org/grass/wiki/Submitting#GRASSGISAddons
https://trac.osgeo.org/grass/wiki/Submitting#SubmittingcodetoSVN

... updated to "Submitting code to GitHub".

How to SVN
https://trac.osgeo.org/grass/wiki/HowToSVN

... marked as "historic" with link to new page.

The GitHub GRASS Addons repo contains SVN_HOWTO.txt

... deleted.

rather than a git HOWTO like https://trac.osgeo.org/grass/wiki/HowToGit
I think a link in the README to https://trac.osgeo.org/grass/wiki/HowToGit would help.

... yes, deduplication is the best.

Submitting Python Code
https://trac.osgeo.org/grass/wiki/Submitting/Python
mentions svn diff which could be updated to git diff

...done.

I believe there was a discussion on the grass-dev list about using Python Black for style.
Was there a decision? That could be added to this wiki page.

AFAIK no decision. It might be good to come back to this discussion.

Thanks for the links!

Markus