[GRASS-dev] Critical bugs for 6.4.4 release: last chance to react, otherwise we'll release with these bugs

GRASS GIS GRASS GIS developer
,
1

Sorry for the somewhat aggressive subject line, but it's meant as a heads-up and last call for action.

We want to release 6.4.4 and if no one has immediate solutions for these bugs, I suggest to just declare them as known bugs and release.

*************Executive summary**********

Of the remaining bugs marked as critical I see two where we might still need a backport to 6.4.4:

- https://trac.osgeo.org/grass/ticket/560 (WinGRASS not deleting temp ppm files from map display)
- https://trac.osgeo.org/grass/ticket/2300 (v.out.ogr: spatialite support not working)

For the rest, I think we can release with these bugs as know bugs.

******************************************

More in detail;

Looking at

https://trac.osgeo.org/grass/query?status=assigned&status=new&status=reopened&group=priority&order=priority&col=id&col=summary&col=owner&col=type&col=priority&col=component&col=version&milestone=6.4.4

I see 6 critical bugs:

- https://trac.osgeo.org/grass/ticket/72 (PNG driver: boundary rendering is off by one pixel): This has been around for a long time. I'm not sure I would classify this as critical, as it is mostly about display, not analysis (AFAIU). I would vote for carrying this bug on to the next release.

- https://trac.osgeo.org/grass/ticket/335 (export floats and doubles with correct precision): I'm not sure I understand what needs to be done on this, but have the feeling that we can release with this bug.

- https://trac.osgeo.org/grass/ticket/560 (WinGRASS not deleting temp ppm files from map display): should r56444 be backported before release ?

- https://trac.osgeo.org/grass/ticket/2008 (grass.script's find_program() can't find modules): I don't know how much testing r56867 (and subsequent modifications) has received, but no one has complained since. AFAIU, the original problem of the ticket is solved, but there are different discussions happening there, so I'm a bit lost.

- https://trac.osgeo.org/grass/ticket/2087 (grass64 man page: missing words): I've closed this as there have been no objections to the fix.

- https://trac.osgeo.org/grass/ticket/2300 (v.out.ogr: spatialite support not working): Hamish proposes a patch which he tested against grass6devel. This sound sufficiently critical to me to warrant a backport.

Looking through the bugs classified as major, most are nuisances, but not really critical. Possible exceptions:

- https://trac.osgeo.org/grass/ticket/2016 (v.surf.idw: very incorrect results)
- https://trac.osgeo.org/grass/ticket/1500 (g.region returns wrong convergence angle), but this seems to concern only specific environments
- https://trac.osgeo.org/grass/ticket/2081 (r.sun (mode 2): sawtooth bug in diffuse irradiation map)

Moritz

2

On Tue, Jun 24, 2014 at 5:03 AM, Moritz Lennert <
mlennert@club.worldonline.be> wrote:

Sorry for the somewhat aggressive subject line, but it's meant as a
heads-up and last call for action.

We want to release 6.4.4 and if no one has immediate solutions for these
bugs, I suggest to just declare them as known bugs and release.

*************Executive summary**********

Of the remaining bugs marked as critical I see two where we might still
need a backport to 6.4.4:

- https://trac.osgeo.org/grass/ticket/560 (WinGRASS not deleting temp ppm
files from map display)

I just committed a fix for it to 6.5, should I go ahead and backport it now?

- https://trac.osgeo.org/grass/ticket/2300 (v.out.ogr: spatialite support

not working)

For the rest, I think we can release with these bugs as know bugs.

******************************************

More in detail;

Looking at

https://trac.osgeo.org/grass/query?status=assigned&status=
new&status=reopened&group=priority&order=priority&col=
id&col=summary&col=owner&col=type&col=priority&col=component&col=version&
milestone=6.4.4

I see 6 critical bugs:

- https://trac.osgeo.org/grass/ticket/72 (PNG driver: boundary rendering
is off by one pixel): This has been around for a long time. I'm not sure I
would classify this as critical, as it is mostly about display, not
analysis (AFAIU). I would vote for carrying this bug on to the next release.

- https://trac.osgeo.org/grass/ticket/335 (export floats and doubles with
correct precision): I'm not sure I understand what needs to be done on
this, but have the feeling that we can release with this bug.

- https://trac.osgeo.org/grass/ticket/560 (WinGRASS not deleting temp ppm
files from map display): should r56444 be backported before release ?

- https://trac.osgeo.org/grass/ticket/2008 (grass.script's find_program()
can't find modules): I don't know how much testing r56867 (and subsequent
modifications) has received, but no one has complained since. AFAIU, the
original problem of the ticket is solved, but there are different
discussions happening there, so I'm a bit lost.

- https://trac.osgeo.org/grass/ticket/2087 (grass64 man page: missing
words): I've closed this as there have been no objections to the fix.

- https://trac.osgeo.org/grass/ticket/2300 (v.out.ogr: spatialite support
not working): Hamish proposes a patch which he tested against grass6devel.
This sound sufficiently critical to me to warrant a backport.

Looking through the bugs classified as major, most are nuisances, but not
really critical. Possible exceptions:

- https://trac.osgeo.org/grass/ticket/2016 (v.surf.idw: very incorrect
results)
- https://trac.osgeo.org/grass/ticket/1500 (g.region returns wrong
convergence angle), but this seems to concern only specific environments
- https://trac.osgeo.org/grass/ticket/2081 (r.sun (mode 2): sawtooth bug
in diffuse irradiation map)

Moritz
_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

3

Hi,

2014-06-24 19:59 GMT+02:00 Anna Petrášová <kratochanna@gmail.com>:

Sorry for the somewhat aggressive subject line, but it's meant as a
heads-up and last call for action.

We want to release 6.4.4 and if no one has immediate solutions for these
bugs, I suggest to just declare them as known bugs and release.

*************Executive summary**********

Of the remaining bugs marked as critical I see two where we might still
need a backport to 6.4.4:

- https://trac.osgeo.org/grass/ticket/560 (WinGRASS not deleting temp ppm
files from map display)

I just committed a fix for it to 6.5, should I go ahead and backport it now?

I think that it's going in the direction that you don't need to hurry
with backports. AFAIK Markus is going to be offline in two days for
some time (he noted that already). Deadline for OSGeo Live is July 6.
History repeats, we are close to fail to release again in time. These
two requests for backports means that we simply miss OSGeo Live, seems
to me.

Martin

--
Martin Landa * http://geo.fsv.cvut.cz/gwiki/Landa

4

2014-06-24 11:03 GMT+02:00 Moritz Lennert <mlennert@club.worldonline.be>:

Sorry for the somewhat aggressive subject line, but it's meant as a heads-up
and last call for action.

I can imagine more aggressive subject;-) in other worlds thanks for
raising this issue...

We want to release 6.4.4 and if no one has immediate solutions for these
bugs, I suggest to just declare them as known bugs and release.

*************Executive summary**********

Of the remaining bugs marked as critical I see two where we might still need
a backport to 6.4.4:

- https://trac.osgeo.org/grass/ticket/560 (WinGRASS not deleting temp ppm
files from map display)
- https://trac.osgeo.org/grass/ticket/2300 (v.out.ogr: spatialite support
not working)

If we want to pass deadline for OSGeo Live we have only one choice,
release it as it is. Martin

5

On Tue, Jun 24, 2014 at 11:47 PM, Martin Landa <landa.martin@gmail.com> wrote:
...

If we want to pass deadline for OSGeo Live we have only one choice,
release it as it is. Martin

... which is pretty fine!

My 0.02 cents,

Markus

6

2014-06-24 23:48 GMT+02:00 Markus Neteler <neteler@osgeo.org>:

On Tue, Jun 24, 2014 at 11:47 PM, Martin Landa <landa.martin@gmail.com> wrote:
...

If we want to pass deadline for OSGeo Live we have only one choice,
release it as it is. Martin

... which is pretty fine!

also for me! I think it's better to have in OSGeo Live GRASS 6.4.4
rather that 6.4.3.

Martin

--
Martin Landa * http://geo.fsv.cvut.cz/gwiki/Landa

7

2014-06-24 23:51 GMT+02:00 Martin Landa <landa.martin@gmail.com>:

also for me! I think it's better to have in OSGeo Live GRASS 6.4.4
rather that 6.4.3.

in other votes let us know if you have any objections. If not, we can
release on Wed/Thu this week.

Martin

--
Martin Landa * http://geo.fsv.cvut.cz/gwiki/Landa

8

Dear Anna,

2014-06-24 19:59 GMT+02:00 Anna Petrášová <kratochanna@gmail.com>:

- https://trac.osgeo.org/grass/ticket/560 (WinGRASS not deleting temp ppm
files from map display)

I just committed a fix for it to 6.5, should I go ahead and backport it now?

if you tested *well* (otherwise let's keep it for 6.4.5), please
backport, than we can try tomorrows build of GRASS 6.4 (build process
starts on the server at 3am CET). Martin

--
Martin Landa * http://geo.fsv.cvut.cz/gwiki/Landa

9

On Tue, Jun 24, 2014 at 5:56 PM, Martin Landa <landa.martin@gmail.com>
wrote:

Dear Anna,

2014-06-24 19:59 GMT+02:00 Anna Petrášová <kratochanna@gmail.com>:
>> - https://trac.osgeo.org/grass/ticket/560 (WinGRASS not deleting temp
ppm
>> files from map display)
>
>
> I just committed a fix for it to 6.5, should I go ahead and backport it
now?

if you tested *well* (otherwise let's keep it for 6.4.5), please
backport, than we can try tomorrows build of GRASS 6.4 (build process
starts on the server at 3am CET). Martin

Sorry for getting to it so late. Although I think the change is pretty
safe, it's not 100% safe, so let's wait for next release.

--
Martin Landa * http://geo.fsv.cvut.cz/gwiki/Landa

10

On Tue, Jun 24, 2014 at 5:52 PM, Martin Landa <landa.martin@gmail.com>
wrote:

2014-06-24 23:51 GMT+02:00 Martin Landa <landa.martin@gmail.com>:
> also for me! I think it's better to have in OSGeo Live GRASS 6.4.4
> rather that 6.4.3.

in other votes let us know if you have any objections. If not, we can
release on Wed/Thu this week.

+1

Martin

--
Martin Landa * http://geo.fsv.cvut.cz/gwiki/Landa
_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

11

[...]

Sorry for getting to it so late. Although I think the change is pretty safe,
it's not 100% safe, so let's wait for next release.

Thanks for spending time/energy on that! Martin

--
Martin Landa * http://geo.fsv.cvut.cz/gwiki/Landa

12

2014-06-24 23:52 GMT+02:00 Martin Landa <landa.martin@gmail.com>:

in other votes let us know if you have any objections. If not, we can

s/votes/words/g :wink:

--
Martin Landa * http://geo.fsv.cvut.cz/gwiki/Landa

13

On 25/06/14 00:09, Martin Landa wrote:

2014-06-24 23:52 GMT+02:00 Martin Landa <landa.martin@gmail.com>:

in other votes let us know if you have any objections. If not, we can

s/votes/words/g :wink:

Although I do adhere more to the principle of release when ready, not when some outside event forces you, I would say go ahead for release. The remaining issues should be clearly noted as known bugs, but I agree that they are not _that_ critical and that in the whole, 6.4.4 is much nicer than 6.4.3...

Moritz

14

Hi,

2014-06-25 10:22 GMT+02:00 Moritz Lennert <mlennert@club.worldonline.be>:

Although I do adhere more to the principle of release when ready, not when
some outside event forces you, I would say go ahead for release. The
remaining issues should be clearly noted as known bugs, but I agree that
they are not _that_ critical and that in the whole, 6.4.4 is much nicer than
6.4.3...

I have tested last build no. 1002 on Windows too (both standalone and
osgeo4w). Let's go ahead...

Martin

--
Martin Landa * http://geo.fsv.cvut.cz/gwiki/Landa

15

On Wed, Jun 25, 2014 at 11:58 AM, Martin Landa <landa.martin@gmail.com> wrote:

Hi,

2014-06-25 10:22 GMT+02:00 Moritz Lennert <mlennert@club.worldonline.be>:

Although I do adhere more to the principle of release when ready, not when
some outside event forces you, I would say go ahead for release. The
remaining issues should be clearly noted as known bugs, but I agree that
they are not _that_ critical and that in the whole, 6.4.4 is much nicer than
6.4.3...

I have tested last build no. 1002 on Windows too (both standalone and
osgeo4w). Let's go ahead...

I'm ready to go today.

Cheers
Markus

16

Hi devs,

I am going to tag 6.4.4 now.
Markus

17

Hi,

2014-06-25 17:48 GMT+02:00 Markus Neteler <neteler@osgeo.org>:

I am going to tag 6.4.4 now.

I put online winGRASS (both standalone [1] and OSGeo4W [2])
installers. Currently only 32bit, OSGeo4W 64bit still contains 6.4.3.
It will hopefully change soon.

Testing welcome, Martin

[1] http://grass.osgeo.org/grass64/binary/mswindows/native/WinGRASS-6.4.4-1-Setup.exe
[2] http://trac.osgeo.org/osgeo4w/wiki/PackageListing#a6.4.4stable

--
Martin Landa * http://geo.fsv.cvut.cz/gwiki/Landa