[GRASS-dev] G__create_alt_search_path() bug?

GRASS GRASS developer
1

Hi,

I found strange construction in G__create_alt_search_path()

114 return 0; /* ??? */
115
116 get_list_of_mapsets();

see

http://trac.osgeo.org/grass/browser/grass/trunk/lib/gis/mapset_nme.c?rev=30718#L107

I guess that get_list_of_mapsets() should be called before return.
This function is used in few GRASS modules.

imagery/i.points/target.c: G__create_alt_search_path();
imagery/i.ortho.photo/photo.elev/main.c: G__create_alt_search_path();
imagery/i.ortho.photo/photo.2target/target.c: G__create_alt_search_path();
imagery/i.ortho.photo/photo.2image/target.c: G__create_alt_search_path();
imagery/i.vpoints/target.c: G__create_alt_search_path();
...

Martin

--
Martin Landa <landa.martin gmail.com> * http://gama.fsv.cvut.cz/~landa *

2

Martin Landa wrote:

I found strange construction in G__create_alt_search_path()

114 return 0; /* ??? */
115
116 get_list_of_mapsets();

see

http://trac.osgeo.org/grass/browser/grass/trunk/lib/gis/mapset_nme.c?rev=30718#L107

I guess that get_list_of_mapsets() should be called before return.

It doesn't actually need to be called at all. Setting nmapset to 0
will cause get_list_of_mapsets() to be called the next time that the
mapset list is queried.

--
Glynn Clements <glynn@gclements.plus.com>

3

Hi,

2008/3/25, Glynn Clements <glynn@gclements.plus.com>:

> I found strange construction in G__create_alt_search_path()
>
> 114 return 0; /* ??? */
> 115
> 116 get_list_of_mapsets();
>
> see
>
> http://trac.osgeo.org/grass/browser/grass/trunk/lib/gis/mapset_nme.c?rev=30718#L107
>
> I guess that get_list_of_mapsets() should be called before return.

It doesn't actually need to be called at all. Setting nmapset to 0
will cause get_list_of_mapsets() to be called the next time that the
mapset list is queried.

applied in trunk

http://trac.osgeo.org/grass/changeset/30726

Martin

--
Martin Landa <landa.martin gmail.com> * http://gama.fsv.cvut.cz/~landa *