[GRASS-dev] georectifier fixes

GRASS GIS GRASS GIS developer
1

I just committed a set of fixes to the georectifier. This should fix all
reported bugs. (can't speak for new ones, but hopefully there aren't any).
Please test.

Michael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics and Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

From: Otto Dassau <otto.dassau@gmx.de>
Date: Wed, 1 Nov 2006 16:09:09 +0100
To: Michael Barton <michael.barton@asu.edu>
Subject: Re: [GRASS-dev] call for last minute testers

On Wed, 01 Nov 2006 07:53:09 -0700
Michael Barton <michael.barton@asu.edu> wrote:

Thanks. I'll check it out. You can always edit a group by running i.group
from the xy location, but it ought to work from the georectifier.

thanks a lot!

Otto

Michael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

From: Otto Dassau <otto.dassau@gmx.de>
Date: Wed, 1 Nov 2006 09:32:44 +0100
To: Michael Barton <michael.barton@asu.edu>
Cc: <grass-dev@grass.itc.it>
Subject: Re: [GRASS-dev] call for last minute testers

On Tue, 31 Oct 2006 12:18:38 -0700
Michael Barton <michael.barton@asu.edu> wrote:

Otto,

I had sent in the wrong version of a georectifier update last night. I sent
in a new one this morning to Markus, who put it into 6.2. I just added it

to

6.3 a moment ago. I don't know if this fixes the problem you are having,

but

you might test it. Thanks for the info.

Hi Michael,

Thanks for the fix. I just tested it with the new snapshot from
http://grass.itc.it/grass62/source/snapshot/ but with the same error.

And another problem occurs. I am not able to create/edit a group anymore.

The

second button only works for vector rectification but not for raster.

regards,
Otto

Michale
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics and Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

From: Otto Dassau <otto.dassau@gmx.de>
Date: Tue, 31 Oct 2006 14:05:13 +0100
To: <grass-dev@grass.itc.it>
Subject: Re: [GRASS-dev] call for last minute testers

On Tue, 31 Oct 2006 23:40:13 +1300
Hamish <hamish_nospam@yahoo.com> wrote:

Hi,

Michael & myself have just applied some last minute patches to gis.m to
make it compatible with tcl/tk 8.3. As this will be released with 6.2.0
without much (any) testing, if everyone could quickly update gis.m in
their cvs (6.3 is probably fine, 6.2 branch is better- it's the same),
make, and double check that we haven't broken anything? (main toolbar
and the georectifyer canvas toolbar)

Hi,

using the "clear all GPC entries" button (in the georectifyer) after

setting

various GCPs only clears the first 2 columns of the first line, but the
forward
and backward errors remain with following error message (command name

below

is the RMS error in line 1 third col):

invalid command name "0.590568"
invalid command name "0.590568"
    while executing
"$fwd_error($gcpnum) delete 0 end"
    (procedure "GRMap::cleargcp" line 14)
    invoked from within
"GRMap::cleargcp"
    ("uplevel" body line 1)
    invoked from within
"uplevel \#0 $cmd"
    (procedure "Button::_release" line 18)
    invoked from within
"Button::_release .gcpwin.mf.topf.tb0.bbox1.b1"
    (command bound to event

I tested with the 6.2 snapshot. Maybe someone can reproduce this?

regards,
  Otto

thanks a lot,
Hamish

--

2

On Wed, 01 Nov 2006 11:38:19 -0700
Michael Barton <michael.barton@asu.edu> wrote:

I just committed a set of fixes to the georectifier. This should fix all
reported bugs. (can't speak for new ones, but hopefully there aren't any).
Please test.

the "clear all GPC entries" button is working now - thanks a lot!
It deletes all entries. Would it be possible that it depends on wether a GCP is
used (selected) or not? I think that would be useful, after choosing the best
GCPs I could delete the rest very easily.

The second error still exists. The create/edit a group button doesn't work.

kind regards,
Otto

Michael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics and Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

> From: Otto Dassau <otto.dassau@gmx.de>
> Date: Wed, 1 Nov 2006 16:09:09 +0100
> To: Michael Barton <michael.barton@asu.edu>
> Subject: Re: [GRASS-dev] call for last minute testers
>
> On Wed, 01 Nov 2006 07:53:09 -0700
> Michael Barton <michael.barton@asu.edu> wrote:
>
>> Thanks. I'll check it out. You can always edit a group by running i.group
>> from the xy location, but it ought to work from the georectifier.
>
> thanks a lot!
>
> Otto
>
>
>> Michael
>> __________________________________________
>> Michael Barton, Professor of Anthropology
>> School of Human Evolution & Social Change
>> Center for Social Dynamics & Complexity
>> Arizona State University
>>
>> phone: 480-965-6213
>> fax: 480-965-7671
>> www: http://www.public.asu.edu/~cmbarton
>>
>>
>>
>>> From: Otto Dassau <otto.dassau@gmx.de>
>>> Date: Wed, 1 Nov 2006 09:32:44 +0100
>>> To: Michael Barton <michael.barton@asu.edu>
>>> Cc: <grass-dev@grass.itc.it>
>>> Subject: Re: [GRASS-dev] call for last minute testers
>>>
>>> On Tue, 31 Oct 2006 12:18:38 -0700
>>> Michael Barton <michael.barton@asu.edu> wrote:
>>>
>>>> Otto,
>>>>
>>>> I had sent in the wrong version of a georectifier update last night. I

sent

>>>> in a new one this morning to Markus, who put it into 6.2. I just added it
> to
>>>> 6.3 a moment ago. I don't know if this fixes the problem you are having,
> but
>>>> you might test it. Thanks for the info.
>>>
>>> Hi Michael,
>>>
>>> Thanks for the fix. I just tested it with the new snapshot from
>>> http://grass.itc.it/grass62/source/snapshot/ but with the same error.
>>>
>>> And another problem occurs. I am not able to create/edit a group anymore.
> The
>>> second button only works for vector rectification but not for raster.
>>>
>>> regards,
>>> Otto
>>>
>>>
>>>> Michale
>>>> __________________________________________
>>>> Michael Barton, Professor of Anthropology
>>>> School of Human Evolution & Social Change
>>>> Center for Social Dynamics and Complexity
>>>> Arizona State University
>>>>
>>>> phone: 480-965-6213
>>>> fax: 480-965-7671
>>>> www: http://www.public.asu.edu/~cmbarton
>>>>
>>>>
>>>>> From: Otto Dassau <otto.dassau@gmx.de>
>>>>> Date: Tue, 31 Oct 2006 14:05:13 +0100
>>>>> To: <grass-dev@grass.itc.it>
>>>>> Subject: Re: [GRASS-dev] call for last minute testers
>>>>>
>>>>> On Tue, 31 Oct 2006 23:40:13 +1300
>>>>> Hamish <hamish_nospam@yahoo.com> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Michael & myself have just applied some last minute patches to gis.m to
>>>>>> make it compatible with tcl/tk 8.3. As this will be released with 6.2.0
>>>>>> without much (any) testing, if everyone could quickly update gis.m in
>>>>>> their cvs (6.3 is probably fine, 6.2 branch is better- it's the same),
>>>>>> make, and double check that we haven't broken anything? (main toolbar
>>>>>> and the georectifyer canvas toolbar)
>>>>>
>>>>> Hi,
>>>>>
>>>>> using the "clear all GPC entries" button (in the georectifyer) after
> setting
>>>>> various GCPs only clears the first 2 columns of the first line, but the
>>>>> forward
>>>>> and backward errors remain with following error message (command name
> below
>>>>> is the RMS error in line 1 third col):
>>>>>
>>>>> invalid command name "0.590568"
>>>>> invalid command name "0.590568"
>>>>> while executing
>>>>> "$fwd_error($gcpnum) delete 0 end"
>>>>> (procedure "GRMap::cleargcp" line 14)
>>>>> invoked from within
>>>>> "GRMap::cleargcp"
>>>>> ("uplevel" body line 1)
>>>>> invoked from within
>>>>> "uplevel \#0 $cmd"
>>>>> (procedure "Button::_release" line 18)
>>>>> invoked from within
>>>>> "Button::_release .gcpwin.mf.topf.tb0.bbox1.b1"
>>>>> (command bound to event
>>>>
>>>>> I tested with the 6.2 snapshot. Maybe someone can reproduce this?
>>>>>
>>>>> regards,
>>>>> Otto
>>>>>
>>>>>> thanks a lot,
>>>>>> Hamish
>>>>>
>>>
>>
>
>
> --
>

--

3

Otto,

The idea about clearing all unchecked gcp's is easy to implement and sounds
very useful.

It is odd about the i.group problem. When I click the creat/edit group
button, it switches to the xy location/mapset and runs i.group on my
computer. What happens on yours?

Michael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics and Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

From: Otto Dassau <otto.dassau@gmx.de>
Date: Wed, 1 Nov 2006 20:20:21 +0100
To: Michael Barton <michael.barton@asu.edu>
Cc: Hamish <hamish_nospam@yahoo.com>, GRASS developers list
<grass-dev@grass.itc.it>
Subject: Re: georectifier fixes

On Wed, 01 Nov 2006 11:38:19 -0700
Michael Barton <michael.barton@asu.edu> wrote:

I just committed a set of fixes to the georectifier. This should fix all
reported bugs. (can't speak for new ones, but hopefully there aren't any).
Please test.

the "clear all GPC entries" button is working now - thanks a lot!
It deletes all entries. Would it be possible that it depends on wether a GCP
is
used (selected) or not? I think that would be useful, after choosing the best
GCPs I could delete the rest very easily.

The second error still exists. The create/edit a group button doesn't work.

kind regards,
Otto

4

Hi,

On Wed, 01 Nov 2006 12:32:39 -0700
Michael Barton <michael.barton@asu.edu> wrote:

Otto,

The idea about clearing all unchecked gcp's is easy to implement and sounds
very useful.

It is odd about the i.group problem. When I click the creat/edit group
button, it switches to the xy location/mapset and runs i.group on my
computer. What happens on yours?

nothing, not even an error. I have a debian testing and compile GRASS with
--with-tcltk-includes=/usr/include/tcl8.4.

I don't know why it doesn't work. Maybe we should wait for someone else with
debian testing who can try. Maybe I do something wrong.

thanks
  Otto

Michael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics and Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

> From: Otto Dassau <otto.dassau@gmx.de>
> Date: Wed, 1 Nov 2006 20:20:21 +0100
> To: Michael Barton <michael.barton@asu.edu>
> Cc: Hamish <hamish_nospam@yahoo.com>, GRASS developers list
> <grass-dev@grass.itc.it>
> Subject: Re: georectifier fixes
>
> On Wed, 01 Nov 2006 11:38:19 -0700
> Michael Barton <michael.barton@asu.edu> wrote:
>> I just committed a set of fixes to the georectifier. This should fix all
>> reported bugs. (can't speak for new ones, but hopefully there aren't any).
>> Please test.
>
> the "clear all GPC entries" button is working now - thanks a lot!
> It deletes all entries. Would it be possible that it depends on wether a GCP
> is
> used (selected) or not? I think that would be useful, after choosing the

best

> GCPs I could delete the rest very easily.
>
> The second error still exists. The create/edit a group button doesn't work.
>
> kind regards,
> Otto

--

5

Michael Barton wrote:

The idea about clearing all unchecked gcp's is easy to implement and
sounds very useful.

what about a "quit georectifier" button to exit?

Hamish

6

Otto Dassau wrote:

> It is odd about the i.group problem. When I click the creat/edit
> group button, it switches to the xy location/mapset and runs i.group
> on my computer. What happens on yours?

nothing, not even an error. I have a debian testing and compile GRASS
with --with-tcltk-includes=/usr/include/tcl8.4.

I don't know why it doesn't work. Maybe we should wait for someone
else with debian testing who can try. Maybe I do something wrong.

[debian/stable (sarge)]

the problem I got: gis.m file->georectify "2. Create edit group"
switches to source location/mapset, but then switches back to original
mapset right away, so i.group runs in the target mapset instead of
source mapset. if you had already created a group in the source mapset
you can continue, but otherwise you're stuck.

If I modify the source, adding "after 5000" to have the Tcl sleep for
5sec after running i.group, I can get i.group to act in the source
mapset for a fleeting moment, but if I then cancel & reclick the folder
icon I then see the available groups in the originial (target) mapset.

That is what happens with 6.2.0. With the latest 6.3, clicking the "2."
button does nothing (although mapset changes fly by in the output
window).

Hamish

7

Hamish

From: Hamish <hamish_nospam@yahoo.com>
Date: Thu, 2 Nov 2006 15:41:55 +1300
To: Otto Dassau <otto.dassau@gmx.de>
Cc: <michael.barton@asu.edu>, <grass-dev@grass.itc.it>
Subject: Re: georectifier fixes

Otto Dassau wrote:

It is odd about the i.group problem. When I click the creat/edit
group button, it switches to the xy location/mapset and runs i.group
on my computer. What happens on yours?

nothing, not even an error. I have a debian testing and compile GRASS
with --with-tcltk-includes=/usr/include/tcl8.4.

I don't know why it doesn't work. Maybe we should wait for someone
else with debian testing who can try. Maybe I do something wrong.

[debian/stable (sarge)]

the problem I got: gis.m file->georectify "2. Create edit group"
switches to source location/mapset, but then switches back to original
mapset right away, so i.group runs in the target mapset instead of
source mapset. if you had already created a group in the source mapset
you can continue, but otherwise you're stuck.

I "fixed" this by having i.group run modally. The georectifier script should
not continue until you close i.group

If I modify the source, adding "after 5000" to have the Tcl sleep for
5sec after running i.group, I can get i.group to act in the source
mapset for a fleeting moment, but if I then cancel & reclick the folder
icon I then see the available groups in the originial (target) mapset.

This won't work, as you noted.

That is what happens with 6.2.0. With the latest 6.3, clicking the "2."
button does nothing (although mapset changes fly by in the output
window).

i.group is running as a modal command under x11 on my Mac. Obviously it is
not running modally on your Debian system. Maybe Glynn or someone can offer
a clue.

I am running it in TclTk as ...

Set cmd "i.group"
Catch {exec -- $cmd}

[I use catch because closing the i.group dialog generates a non-meaningful,
non-fatal, but annoying TclTk error message]

__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

8

On Thu, 2 Nov 2006 15:41:55 +1300
Hamish <hamish_nospam@yahoo.com> wrote:

Otto Dassau wrote:
> > It is odd about the i.group problem. When I click the creat/edit
> > group button, it switches to the xy location/mapset and runs i.group
> > on my computer. What happens on yours?
>
> nothing, not even an error. I have a debian testing and compile GRASS
> with --with-tcltk-includes=/usr/include/tcl8.4.
>
> I don't know why it doesn't work. Maybe we should wait for someone
> else with debian testing who can try. Maybe I do something wrong.

[debian/stable (sarge)]

the problem I got: gis.m file->georectify "2. Create edit group"
switches to source location/mapset, but then switches back to original
mapset right away, so i.group runs in the target mapset instead of
source mapset. if you had already created a group in the source mapset
you can continue, but otherwise you're stuck.

If I modify the source, adding "after 5000" to have the Tcl sleep for
5sec after running i.group, I can get i.group to act in the source
mapset for a fleeting moment, but if I then cancel & reclick the folder
icon I then see the available groups in the originial (target) mapset.

That is what happens with 6.2.0. With the latest 6.3, clicking the "2."
button does nothing (although mapset changes fly by in the output
window).

changing line 347 as proposed by Michael in $GISBASE/etc/gm/georect.tcl

# catch {exec -- $cmd}
      exec -- $cmd

sais sth. like:

Error: Parameter <group> not set:

maybe this helps: In GRASS 6.2.0RC3 it worked.

  Otto

9

Otto Dassau wrote:

changing line 347 as proposed by Michael in
$GISBASE/etc/gm/georect.tcl

# catch {exec -- $cmd}
      exec -- $cmd

sais sth. like:

Error: Parameter <group> not set:

maybe this helps: In GRASS 6.2.0RC3 it worked.

try

exec -- $cmd --ui

to force GUI mode.

but is that running in current mapset (wrong) or switched to target
mapset (correct)?

Hamish

10

On Thu, 2 Nov 2006 21:11:25 +1300
Hamish <hamish_nospam@yahoo.com> wrote:

Otto Dassau wrote:
>
> changing line 347 as proposed by Michael in
> $GISBASE/etc/gm/georect.tcl
>
> # catch {exec -- $cmd}
> exec -- $cmd
>
> sais sth. like:
>
> Error: Parameter <group> not set:
>
> maybe this helps: In GRASS 6.2.0RC3 it worked.

try

exec -- $cmd --ui

to force GUI mode.

now it works. Clicking on the edit/create button opens the i.group window.

but is that running in current mapset (wrong) or switched to target
mapset (correct)?

what do you mean here, it is running in current mapset. I list my procedure,
maybe I missunderstand:

- I start GRASS in spearfish/PERMANENT
- I Import a not geocoded map (topographic map)
- I start georectifier
- I choose mapset PERMANENT
- I choose a new group and the map I want to rectify
- When I close the i.group window following message appears, but it still works:

child process exited abnormally
child process exited abnormally
    while executing
"exec -- $cmd --ui"
    (procedure "GRMap::group" line 17)
    invoked from within
"GRMap::group"
    ("uplevel" body line 1)
    invoked from within
"uplevel \#0 $cmd"
    (procedure "Button::_release" line 18)
    invoked from within
"Button::_release .grstart.mf.frame.group.a"
    (command bound to event)
and set GCPs

- Then I select the group a just created
- I select the map to rectify
- I start to set my GCPs and rectify.
- The result is ok and in stored the current mapset PERMANENT.

BTW: Is it intended that there are two ways to use the module?

a) I set GCPs and fill in the appropriate coordinates in the 2nd column
manually.
b) I set GCPs and fill in the appropriate coordinates interactively opening a
second monitor with a reference map where I click in the map to find
the right coordinates. The coordinates are inserted in the rectifier then...

regards,
Otto

Hamish

11

I'm a bit confused. Could clarify the following.

1. Did the new georect.tcl work -- the one in the 6.3 head? This one
*should* switch to the source mapset, run i.group, and wait until you're
done before switching back to the target mapset.

2. If it did not work, did you get the following error with the newest
georect.tcl?
Error: Parameter <group> not set:
This is an i.group error that suggests this grass command failed for some
reason

3. If the newest version (i.e., in the 6.3 head) works with adding the --ui
switch, that's fantastic. But I need to know if that actually fixes it for
you guys or if it was already fixed without this.

MIchael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

From: Otto Dassau <otto.dassau@gmx.de>
Date: Thu, 2 Nov 2006 10:11:33 +0100
To: Hamish <hamish_nospam@yahoo.com>
Cc: <michael.barton@asu.edu>, <grass-dev@grass.itc.it>
Subject: Re: georectifier fixes

On Thu, 2 Nov 2006 21:11:25 +1300
Hamish <hamish_nospam@yahoo.com> wrote:

Otto Dassau wrote:

changing line 347 as proposed by Michael in
$GISBASE/etc/gm/georect.tcl

# catch {exec -- $cmd}
exec -- $cmd

sais sth. like:

Error: Parameter <group> not set:

maybe this helps: In GRASS 6.2.0RC3 it worked.

try

exec -- $cmd --ui

to force GUI mode.

now it works. Clicking on the edit/create button opens the i.group window.

but is that running in current mapset (wrong) or switched to target
mapset (correct)?

what do you mean here, it is running in current mapset. I list my procedure,
maybe I missunderstand:

- I start GRASS in spearfish/PERMANENT
- I Import a not geocoded map (topographic map)
- I start georectifier
- I choose mapset PERMANENT
- I choose a new group and the map I want to rectify
- When I close the i.group window following message appears, but it still
works:

child process exited abnormally
child process exited abnormally
    while executing
"exec -- $cmd --ui"
    (procedure "GRMap::group" line 17)
    invoked from within
"GRMap::group"
    ("uplevel" body line 1)
    invoked from within
"uplevel \#0 $cmd"
    (procedure "Button::_release" line 18)
    invoked from within
"Button::_release .grstart.mf.frame.group.a"
    (command bound to event)
and set GCPs

- Then I select the group a just created
- I select the map to rectify
- I start to set my GCPs and rectify.
- The result is ok and in stored the current mapset PERMANENT.

BTW: Is it intended that there are two ways to use the module?

a) I set GCPs and fill in the appropriate coordinates in the 2nd column
manually.
b) I set GCPs and fill in the appropriate coordinates interactively opening a
second monitor with a reference map where I click in the map to find
the right coordinates. The coordinates are inserted in the rectifier then...

regards,
Otto

Hamish

12

On Thu, 02 Nov 2006 06:22:56 -0700
Michael Barton <michael.barton@asu.edu> wrote:

I'm a bit confused. Could clarify the following.

Hi,

1. Did the new georect.tcl work -- the one in the 6.3 head? This one
*should* switch to the source mapset, run i.group, and wait until you're
done before switching back to the target mapset.

yes, it works in the 6.3 head here. I rectified a map this morning using the
georectifier in 6.3 head.

2. If it did not work, did you get the following error with the newest
georect.tcl?
Error: Parameter <group> not set:
This is an i.group error that suggests this grass command failed for some
reason

3. If the newest version (i.e., in the 6.3 head) works with adding the --ui
switch, that's fantastic. But I need to know if that actually fixes it for
you guys or if it was already fixed without this.

the i.group window opens, but when I close the "error" message below appears,
but I can still go on rectiifying.

child process exited abnormally
child process exited abnormally
     while executing
"exec -- $cmd --ui"
     (procedure "GRMap::group" line 17)
     invoked from within
"GRMap::group"
     ("uplevel" body line 1)
     invoked from within
"uplevel \#0 $cmd"
     (procedure "Button::_release" line 18)
     invoked from within
"Button::_release .grstart.mf.frame.group.a"
     (command bound to event)
and set GCPs

is it clearer now?

regards,
Otto

PS: currently I am only online from time to time - sorry.

> works:

MIchael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

> From: Otto Dassau <otto.dassau@gmx.de>
> Date: Thu, 2 Nov 2006 10:11:33 +0100
> To: Hamish <hamish_nospam@yahoo.com>
> Cc: <michael.barton@asu.edu>, <grass-dev@grass.itc.it>
> Subject: Re: georectifier fixes
>
> On Thu, 2 Nov 2006 21:11:25 +1300
> Hamish <hamish_nospam@yahoo.com> wrote:
>
>> Otto Dassau wrote:
>>>
>>> changing line 347 as proposed by Michael in
>>> $GISBASE/etc/gm/georect.tcl
>>>
>>> # catch {exec -- $cmd}
>>> exec -- $cmd
>>>
>>> sais sth. like:
>>>
>>> Error: Parameter <group> not set:
>>>
>>> maybe this helps: In GRASS 6.2.0RC3 it worked.
>>
>>
>> try
>>
>> exec -- $cmd --ui
>>
>> to force GUI mode.
>
> now it works. Clicking on the edit/create button opens the i.group window.
>
>> but is that running in current mapset (wrong) or switched to target
>> mapset (correct)?
>
> what do you mean here, it is running in current mapset. I list my procedure,
> maybe I missunderstand:
>
> - I start GRASS in spearfish/PERMANENT
> - I Import a not geocoded map (topographic map)
> - I start georectifier
> - I choose mapset PERMANENT
> - I choose a new group and the map I want to rectify
> - When I close the i.group window following message appears, but it still
> works:
>
> child process exited abnormally
> child process exited abnormally
> while executing
> "exec -- $cmd --ui"
> (procedure "GRMap::group" line 17)
> invoked from within
> "GRMap::group"
> ("uplevel" body line 1)
> invoked from within
> "uplevel \#0 $cmd"
> (procedure "Button::_release" line 18)
> invoked from within
> "Button::_release .grstart.mf.frame.group.a"
> (command bound to event)
> and set GCPs
>
> - Then I select the group a just created
> - I select the map to rectify
> - I start to set my GCPs and rectify.
> - The result is ok and in stored the current mapset PERMANENT.
>
>
> BTW: Is it intended that there are two ways to use the module?
>
> a) I set GCPs and fill in the appropriate coordinates in the 2nd column
> manually.
> b) I set GCPs and fill in the appropriate coordinates interactively opening

a

> second monitor with a reference map where I click in the map to find
> the right coordinates. The coordinates are inserted in the rectifier then...
>
> regards,
> Otto
>
>> Hamish
>>
>

--

13

It sounds like you just need to put it back the way it was before. That is,
put the "catch {exec -- $cmd}" back in.

Using the "catch" statement traps this annoying error message.

Do you need the --ui flag?

Michael

__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics and Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

From: Otto Dassau <otto.dassau@gmx.de>
Date: Thu, 2 Nov 2006 19:40:48 +0100
To: Michael Barton <michael.barton@asu.edu>
Cc: Hamish <hamish_nospam@yahoo.com>, <grass-dev@grass.itc.it>
Subject: Re: georectifier fixes

On Thu, 02 Nov 2006 06:22:56 -0700
Michael Barton <michael.barton@asu.edu> wrote:

I'm a bit confused. Could clarify the following.

Hi,

1. Did the new georect.tcl work -- the one in the 6.3 head? This one
*should* switch to the source mapset, run i.group, and wait until you're
done before switching back to the target mapset.

yes, it works in the 6.3 head here. I rectified a map this morning using the
georectifier in 6.3 head.

2. If it did not work, did you get the following error with the newest
georect.tcl?
Error: Parameter <group> not set:
This is an i.group error that suggests this grass command failed for some
reason

3. If the newest version (i.e., in the 6.3 head) works with adding the --ui
switch, that's fantastic. But I need to know if that actually fixes it for
you guys or if it was already fixed without this.

the i.group window opens, but when I close the "error" message below appears,
but I can still go on rectiifying.

child process exited abnormally
child process exited abnormally
     while executing
"exec -- $cmd --ui"
     (procedure "GRMap::group" line 17)
     invoked from within
"GRMap::group"
     ("uplevel" body line 1)
     invoked from within
"uplevel \#0 $cmd"
     (procedure "Button::_release" line 18)
     invoked from within
"Button::_release .grstart.mf.frame.group.a"
     (command bound to event)
and set GCPs

is it clearer now?

regards,
Otto

PS: currently I am only online from time to time - sorry.

works:

MIchael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

From: Otto Dassau <otto.dassau@gmx.de>
Date: Thu, 2 Nov 2006 10:11:33 +0100
To: Hamish <hamish_nospam@yahoo.com>
Cc: <michael.barton@asu.edu>, <grass-dev@grass.itc.it>
Subject: Re: georectifier fixes

On Thu, 2 Nov 2006 21:11:25 +1300
Hamish <hamish_nospam@yahoo.com> wrote:

Otto Dassau wrote:

changing line 347 as proposed by Michael in
$GISBASE/etc/gm/georect.tcl

# catch {exec -- $cmd}
exec -- $cmd

sais sth. like:

Error: Parameter <group> not set:

maybe this helps: In GRASS 6.2.0RC3 it worked.

try

exec -- $cmd --ui

to force GUI mode.

now it works. Clicking on the edit/create button opens the i.group window.

but is that running in current mapset (wrong) or switched to target
mapset (correct)?

what do you mean here, it is running in current mapset. I list my procedure,
maybe I missunderstand:

- I start GRASS in spearfish/PERMANENT
- I Import a not geocoded map (topographic map)
- I start georectifier
- I choose mapset PERMANENT
- I choose a new group and the map I want to rectify
- When I close the i.group window following message appears, but it still
works:

child process exited abnormally
child process exited abnormally
    while executing
"exec -- $cmd --ui"
    (procedure "GRMap::group" line 17)
    invoked from within
"GRMap::group"
    ("uplevel" body line 1)
    invoked from within
"uplevel \#0 $cmd"
    (procedure "Button::_release" line 18)
    invoked from within
"Button::_release .grstart.mf.frame.group.a"
    (command bound to event)
and set GCPs

- Then I select the group a just created
- I select the map to rectify
- I start to set my GCPs and rectify.
- The result is ok and in stored the current mapset PERMANENT.

BTW: Is it intended that there are two ways to use the module?

a) I set GCPs and fill in the appropriate coordinates in the 2nd column
manually.
b) I set GCPs and fill in the appropriate coordinates interactively opening

a

second monitor with a reference map where I click in the map to find
the right coordinates. The coordinates are inserted in the rectifier then...

regards,
Otto

Hamish

--

14

Otto and Hamish,

I got a student here with Debian Ubuntu (Mepis) to try the --ui switch for
the i.group command in georectify.tcl. It seems to solve the problem of
i.group flashing on and off.

Thanks very much Hamish for suggesting it. It's in the cvs now. I'm copying
Markus so that he can backport it to 6.2.1

Michael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics and Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

From: Otto Dassau <otto.dassau@gmx.de>
Date: Thu, 2 Nov 2006 19:40:48 +0100
To: Michael Barton <michael.barton@asu.edu>
Cc: Hamish <hamish_nospam@yahoo.com>, <grass-dev@grass.itc.it>
Subject: Re: georectifier fixes

On Thu, 02 Nov 2006 06:22:56 -0700
Michael Barton <michael.barton@asu.edu> wrote:

I'm a bit confused. Could clarify the following.

Hi,

1. Did the new georect.tcl work -- the one in the 6.3 head? This one
*should* switch to the source mapset, run i.group, and wait until you're
done before switching back to the target mapset.

yes, it works in the 6.3 head here. I rectified a map this morning using the
georectifier in 6.3 head.

2. If it did not work, did you get the following error with the newest
georect.tcl?
Error: Parameter <group> not set:
This is an i.group error that suggests this grass command failed for some
reason

3. If the newest version (i.e., in the 6.3 head) works with adding the --ui
switch, that's fantastic. But I need to know if that actually fixes it for
you guys or if it was already fixed without this.

the i.group window opens, but when I close the "error" message below appears,
but I can still go on rectiifying.

child process exited abnormally
child process exited abnormally
     while executing
"exec -- $cmd --ui"
     (procedure "GRMap::group" line 17)
     invoked from within
"GRMap::group"
     ("uplevel" body line 1)
     invoked from within
"uplevel \#0 $cmd"
     (procedure "Button::_release" line 18)
     invoked from within
"Button::_release .grstart.mf.frame.group.a"
     (command bound to event)
and set GCPs

is it clearer now?

regards,
Otto

PS: currently I am only online from time to time - sorry.

works:

MIchael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

From: Otto Dassau <otto.dassau@gmx.de>
Date: Thu, 2 Nov 2006 10:11:33 +0100
To: Hamish <hamish_nospam@yahoo.com>
Cc: <michael.barton@asu.edu>, <grass-dev@grass.itc.it>
Subject: Re: georectifier fixes

On Thu, 2 Nov 2006 21:11:25 +1300
Hamish <hamish_nospam@yahoo.com> wrote:

Otto Dassau wrote:

changing line 347 as proposed by Michael in
$GISBASE/etc/gm/georect.tcl

# catch {exec -- $cmd}
exec -- $cmd

sais sth. like:

Error: Parameter <group> not set:

maybe this helps: In GRASS 6.2.0RC3 it worked.

try

exec -- $cmd --ui

to force GUI mode.

now it works. Clicking on the edit/create button opens the i.group window.

but is that running in current mapset (wrong) or switched to target
mapset (correct)?

what do you mean here, it is running in current mapset. I list my procedure,
maybe I missunderstand:

- I start GRASS in spearfish/PERMANENT
- I Import a not geocoded map (topographic map)
- I start georectifier
- I choose mapset PERMANENT
- I choose a new group and the map I want to rectify
- When I close the i.group window following message appears, but it still
works:

child process exited abnormally
child process exited abnormally
    while executing
"exec -- $cmd --ui"
    (procedure "GRMap::group" line 17)
    invoked from within
"GRMap::group"
    ("uplevel" body line 1)
    invoked from within
"uplevel \#0 $cmd"
    (procedure "Button::_release" line 18)
    invoked from within
"Button::_release .grstart.mf.frame.group.a"
    (command bound to event)
and set GCPs

- Then I select the group a just created
- I select the map to rectify
- I start to set my GCPs and rectify.
- The result is ok and in stored the current mapset PERMANENT.

BTW: Is it intended that there are two ways to use the module?

a) I set GCPs and fill in the appropriate coordinates in the 2nd column
manually.
b) I set GCPs and fill in the appropriate coordinates interactively opening

a

second monitor with a reference map where I click in the map to find
the right coordinates. The coordinates are inserted in the rectifier then...

regards,
Otto

Hamish

--

15

Michael, all,

I have backported the today's changes to gis.m in 6.2-cvs.
Also re-done the CVS snapshot for easy testing:

http://grass.itc.it/grass62/source/snapshot/

Markus

On Thu, Nov 02, 2006 at 03:40:02PM -0700, Michael Barton wrote:

Otto and Hamish,

I got a student here with Debian Ubuntu (Mepis) to try the --ui switch for
the i.group command in georectify.tcl. It seems to solve the problem of
i.group flashing on and off.

Thanks very much Hamish for suggesting it. It's in the cvs now. I'm copying
Markus so that he can backport it to 6.2.1

Michael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics and Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

> From: Otto Dassau <otto.dassau@gmx.de>
> Date: Thu, 2 Nov 2006 19:40:48 +0100
> To: Michael Barton <michael.barton@asu.edu>
> Cc: Hamish <hamish_nospam@yahoo.com>, <grass-dev@grass.itc.it>
> Subject: Re: georectifier fixes
>
> On Thu, 02 Nov 2006 06:22:56 -0700
> Michael Barton <michael.barton@asu.edu> wrote:
>
>> I'm a bit confused. Could clarify the following.
>
> Hi,
>
>> 1. Did the new georect.tcl work -- the one in the 6.3 head? This one
>> *should* switch to the source mapset, run i.group, and wait until you're
>> done before switching back to the target mapset.
>
> yes, it works in the 6.3 head here. I rectified a map this morning using the
> georectifier in 6.3 head.
>
>> 2. If it did not work, did you get the following error with the newest
>> georect.tcl?
>> Error: Parameter <group> not set:
>> This is an i.group error that suggests this grass command failed for some
>> reason
>>
>> 3. If the newest version (i.e., in the 6.3 head) works with adding the --ui
>> switch, that's fantastic. But I need to know if that actually fixes it for
>> you guys or if it was already fixed without this.
>
> the i.group window opens, but when I close the "error" message below appears,
> but I can still go on rectiifying.
>
> child process exited abnormally
> child process exited abnormally
> while executing
> "exec -- $cmd --ui"
> (procedure "GRMap::group" line 17)
> invoked from within
> "GRMap::group"
> ("uplevel" body line 1)
> invoked from within
> "uplevel \#0 $cmd"
> (procedure "Button::_release" line 18)
> invoked from within
> "Button::_release .grstart.mf.frame.group.a"
> (command bound to event)
> and set GCPs
>
> is it clearer now?
>
> regards,
> Otto
>
> PS: currently I am only online from time to time - sorry.
>
>>> works:
>
>> MIchael
>> __________________________________________
>> Michael Barton, Professor of Anthropology
>> School of Human Evolution & Social Change
>> Center for Social Dynamics & Complexity
>> Arizona State University
>>
>> phone: 480-965-6213
>> fax: 480-965-7671
>> www: http://www.public.asu.edu/~cmbarton
>>
>>
>>
>>> From: Otto Dassau <otto.dassau@gmx.de>
>>> Date: Thu, 2 Nov 2006 10:11:33 +0100
>>> To: Hamish <hamish_nospam@yahoo.com>
>>> Cc: <michael.barton@asu.edu>, <grass-dev@grass.itc.it>
>>> Subject: Re: georectifier fixes
>>>
>>> On Thu, 2 Nov 2006 21:11:25 +1300
>>> Hamish <hamish_nospam@yahoo.com> wrote:
>>>
>>>> Otto Dassau wrote:
>>>>>
>>>>> changing line 347 as proposed by Michael in
>>>>> $GISBASE/etc/gm/georect.tcl
>>>>>
>>>>> # catch {exec -- $cmd}
>>>>> exec -- $cmd
>>>>>
>>>>> sais sth. like:
>>>>>
>>>>> Error: Parameter <group> not set:
>>>>>
>>>>> maybe this helps: In GRASS 6.2.0RC3 it worked.
>>>>
>>>>
>>>> try
>>>>
>>>> exec -- $cmd --ui
>>>>
>>>> to force GUI mode.
>>>
>>> now it works. Clicking on the edit/create button opens the i.group window.
>>>
>>>> but is that running in current mapset (wrong) or switched to target
>>>> mapset (correct)?
>>>
>>> what do you mean here, it is running in current mapset. I list my procedure,
>>> maybe I missunderstand:
>>>
>>> - I start GRASS in spearfish/PERMANENT
>>> - I Import a not geocoded map (topographic map)
>>> - I start georectifier
>>> - I choose mapset PERMANENT
>>> - I choose a new group and the map I want to rectify
>>> - When I close the i.group window following message appears, but it still
>>> works:
>>>
>>> child process exited abnormally
>>> child process exited abnormally
>>> while executing
>>> "exec -- $cmd --ui"
>>> (procedure "GRMap::group" line 17)
>>> invoked from within
>>> "GRMap::group"
>>> ("uplevel" body line 1)
>>> invoked from within
>>> "uplevel \#0 $cmd"
>>> (procedure "Button::_release" line 18)
>>> invoked from within
>>> "Button::_release .grstart.mf.frame.group.a"
>>> (command bound to event)
>>> and set GCPs
>>>
>>> - Then I select the group a just created
>>> - I select the map to rectify
>>> - I start to set my GCPs and rectify.
>>> - The result is ok and in stored the current mapset PERMANENT.
>>>
>>>
>>> BTW: Is it intended that there are two ways to use the module?
>>>
>>> a) I set GCPs and fill in the appropriate coordinates in the 2nd column
>>> manually.
>>> b) I set GCPs and fill in the appropriate coordinates interactively opening
> a
>>> second monitor with a reference map where I click in the map to find
>>> the right coordinates. The coordinates are inserted in the rectifier then...
>>>
>>> regards,
>>> Otto
>>>
>>>> Hamish
>>>>
>>>
>>
>
>
> --
>

--
Markus Neteler <neteler itc it> http://mpa.itc.it/markus/
ITC-irst - Centro per la Ricerca Scientifica e Tecnologica
MPBA - Predictive Models for Biol. & Environ. Data Analysis
Via Sommarive, 18 - 38050 Povo (Trento), Italy

16

Michael Barton wrote:

I got a student here with Debian Ubuntu (Mepis) to try the --ui switch
for the i.group command in georectify.tcl. It seems to solve the
problem of i.group flashing on and off.

I have just updated to the latest CVS and the georectifier is now
working properly (AFAIU), running i.group from the other side of the
looking glass & all.

great!

Thanks very much Hamish for suggesting it. It's in the cvs now. I'm
copying Markus so that he can backport it to 6.2.1

in 6.2.0 the "2. create a group" button now is a no-op for me (note I'm
currently at 100% cpu + 80% RAM for a modelling task, so race-for-
resource errors might be different). Not a big deal, but we'll have to
answer the question of how to set the group up in another grass session
eventually. If this is the only last-minute 6.2.0 breakage I'll be very
happy.

Otto:

> the i.group window opens, but when I close the "error" message below
> appears, but I can still go on rectiifying.
>
> child process exited abnormally
> child process exited abnormally
> while executing
> "exec -- $cmd --ui"
> (procedure "GRMap::group" line 17)
> invoked from within
> "GRMap::group"
> ("uplevel" body line 1)
> invoked from within
> "uplevel \#0 $cmd"
> (procedure "Button::_release" line 18)
> invoked from within
> "Button::_release .grstart.mf.frame.group.a"
> (command bound to event)
> and set GCPs

No harm in it, AFAIK, just normal termination(?). The "catch" statement
hides this error message. Unfortunately the "catch" was also catching a
genuine error (expecting command line options; thus it needs a --ui GUI
[why is that?]).

From what I've heard here the Tcl return test is bogus so there is no

way to test a good exit from a bad one?

perhaps gis.m could use a global DEBUG 0/1 setting like the start of the
nviz2.2_script has. With it changed to 1 it could disable the catches,
etc. or maybe better it could test on startup if the gisenv DEBUG was >
0 to set a global DEBUG var.

Hamish

17

On Fri, 3 Nov 2006 20:00:38 +1300
Hamish <hamish_nospam@yahoo.com> wrote:

Michael Barton wrote:
> I got a student here with Debian Ubuntu (Mepis) to try the --ui switch
> for the i.group command in georectify.tcl. It seems to solve the
> problem of i.group flashing on and off.

I have just updated to the latest CVS and the georectifier is now
working properly (AFAIU), running i.group from the other side of the
looking glass & all.

great!

> Thanks very much Hamish for suggesting it. It's in the cvs now. I'm
> copying Markus so that he can backport it to 6.2.1

in 6.2.0 the "2. create a group" button now is a no-op for me (note I'm
currently at 100% cpu + 80% RAM for a modelling task, so race-for-
resource errors might be different). Not a big deal, but we'll have to
answer the question of how to set the group up in another grass session
eventually. If this is the only last-minute 6.2.0 breakage I'll be very
happy.

Otto:
> > the i.group window opens, but when I close the "error" message below
> > appears, but I can still go on rectiifying.
> >
> > child process exited abnormally
> > child process exited abnormally
> > while executing
> > "exec -- $cmd --ui"
> > (procedure "GRMap::group" line 17)
> > invoked from within
> > "GRMap::group"
> > ("uplevel" body line 1)
> > invoked from within
> > "uplevel \#0 $cmd"
> > (procedure "Button::_release" line 18)
> > invoked from within
> > "Button::_release .grstart.mf.frame.group.a"
> > (command bound to event)
> > and set GCPs

No harm in it, AFAIK, just normal termination(?). The "catch" statement
hides this error message. Unfortunately the "catch" was also catching a
genuine error (expecting command line options; thus it needs a --ui GUI
[why is that?]).

ok, thanks a lot for your help and fixes. I tested the current cvs version Grass
6.3 head and the georectifier is working very well now - great!!

thanks a lot

Otto

From what I've heard here the Tcl return test is bogus so there is no
way to test a good exit from a bad one?

perhaps gis.m could use a global DEBUG 0/1 setting like the start of the
nviz2.2_script has. With it changed to 1 it could disable the catches,
etc. or maybe better it could test on startup if the gisenv DEBUG was >
0 to set a global DEBUG var.

Hamish

--