[GRASS-dev] [grass-code I][396] Line width in v.digit

code I item #396, was opened at 09/05/2007 14:18
Status: Open
Priority: 3
Submitted By: Aldo Clerici (clerici)
Assigned to: Nobody (None)
Summary: Line width in v.digit
Issue type: module bad feature
Issue status: None
GRASS version: 6.2
GRASS component: None
Operating system: Linux
Operating system version:
GRASS CVS checkout date, if applies (YYMMDD): 070407

Initial Comment:
In the Setting panel of v.digit the 'Line width' option seems inactive (and the lines in the monitor have a default width greater -and unpleasant- than in the previous version of v.digit).

Greetings
A.Clerici

----------------------------------------------------------------------

You can respond by visiting:
http://wald.intevation.org/tracker/?func=detail&atid=204&aid=396&group_id=21

In the Setting panel of v.digit the 'Line width'
option seems inactive

I confirm this bug in 6.2.2 CVS - 'Line width' field is empty at a
start and entering a number followed by Enter key does not affect the
width of lines displayed.

In 6.3 CVS it's OK.

Maciek

Maciej Sieczka wrote:

In the Setting panel of v.digit the 'Line width'
option seems inactive

I confirm this bug in 6.2.2 CVS - 'Line width' field is empty at a
start and entering a number followed by Enter key does not affect the
width of lines displayed.

Oh, pressing the 'Redraw' button renders lines according to the
declared width. I guess that previously this was not necessary; it was
enough to type in the width and press Enter, then the monitor was
re-rendered automatically. Or wasn't it?

Maciek

http://wald.intevation.org/tracker/?func=detail&atid=204&aid=396&group_id=21

code I item #396, was opened at 09/05/2007 14:18

..

In the Setting panel of v.digit the 'Line width' option seems inactive
(and the lines in the monitor have a default width greater -and
unpleasant- than in the previous version of v.digit).

(just cc'd my msg; see the bug report for more)

I'm pretty sure you always had to hit Refresh in the old version.
(just tested with 6.2.1, yes, you need to refresh)

I have just fixed it in 6.3 so that the line width changes as
you adjust the spinbox. (it redraws when you change it)

I am glad to see the width reduced -- note that it needed to
be changed in global.h as well.

The "x" icon is still a bit thick.
(cleaning complicated vectors is often like picking needles out of
haystacks so any extra clutter is to be avoided, and why invalid
features are drawn on top of/after valid green ones)

n.b. the smallest D_line_width is 0, not 1. width=1 still looks
a little lumpy. (experiment with d.vect)

I tried to fix this, by changing SpinBox -range in settings.tcl
to {0 50 1} ({min max stepsize}) and this in driver.c:

void driver_line_width(int w)
{
- width = w ? w : 1;
+ width = w >= 0 ? w : 1;
}

but no luck. Is the Tcl canvas destined to be not-as-nice as
the xmon displays? (ugly stagger effect seen on thin diagonal lines)

If the tcl width has a minimum size of 1, while the xdriver had a min
size of 0, maybe this is why the line appears to be 1 size bigger than
it did before.

Hamish