Here is a patch done with this command:
diff -Naur main.cppold main.cpp > main_atcorr.diff
Just commented the '...->answer=...' pointers.
Yann
On Wednesday 29 August 2007 01:53:08 Markus Neteler wrote:
Hi Yann,
could you send us a patch to get it right?
thanks
Markus
Yann Chemin-3 wrote:
> Yes, this is test data, was in testdata/ dir in the grassSVN Add-ons
> before
> joining CVS.
>
> Please anyone with write access may change this.
> Yann
I started working on this awhile ago after realizing values were
hardcoded, etc. IIRC, I didn't finish because it was becoming
complicated and I didn't have time to dedicate to it.
I can commit what I have (and comment unfinished code) if someone wants
to have it done relatively quickly and is willing to finish it
themselves.
Until then, I think it should probably be removed from the Makefile.
On Wed, 2007-08-29 at 00:16 +0700, Yann wrote:
Yes, this is test data, was in testdata/ dir in the grassSVN Add-ons before
joining CVS.
Please anyone with write access may change this.
Yann
On Tuesday 28 August 2007 03:41:17 grass-dev@grass.itc.it wrote:
> code I item #470, was opened at 2007-08-27 22:41
> Status: Open
> Priority: 3
> Submitted By: Maciej Sieczka (msieczka)
> Assigned to: Nobody (None)
> Summary: i.atcorr: hardcoded input/output map names
> Issue type: module bug
> Issue status: None
> GRASS version: CVS HEAD
> GRASS component: imagery
> Operating system: None
> Operating system version:
> GRASS CVS checkout date, if applies (YYMMDD): 070827
>
>
> Initial Comment:
> i.atcorr has a follwoing set of map names hardcoded:
>
> iimg=ETM4_400x400.raw
> ialt=dem_float
> ivis=visibility
> icnd=ETM4_atmospheric_input_GRASS.txt
> oimg=6s_output_file
>
> Shouldn't have any.
I started working on this awhile ago after realizing values were
hardcoded, etc. IIRC, I didn't finish because it was becoming
complicated and I didn't have time to dedicate to it.
I can commit what I have (and comment unfinished code) if someone
wants to have it done relatively quickly and is willing to finish it
themselves.
Until then, I think it should probably be removed from the Makefile.
I have committed the documenation clean up. Things still unclear
On Wed, 2007-08-29 at 00:16 +0700, Yann wrote:
Yes, this is test data, was in testdata/ dir in the grassSVN
Add-ons before joining CVS.
Please anyone with write access may change this. Yann
On Tuesday 28 August 2007 03:41:17 grass-dev@grass.itc.it wrote:
code I item #470, was opened at 2007-08-27 22:41 Status: Open
Priority: 3 Submitted By: Maciej Sieczka (msieczka) Assigned to:
Nobody (None) Summary: i.atcorr: hardcoded input/output map
names Issue type: module bug Issue status: None GRASS version:
CVS HEAD GRASS component: imagery Operating system: None
Operating system version: GRASS CVS checkout date, if applies
(YYMMDD): 070827
Initial Comment: i.atcorr has a follwoing set of map names
hardcoded:
I started working on this awhile ago after realizing values were
hardcoded, etc. IIRC, I didn't finish because it was becoming
complicated and I didn't have time to dedicate to it.
I can commit what I have (and comment unfinished code) if someone
wants to have it done relatively quickly and is willing to finish it
themselves.
Until then, I think it should probably be removed from the Makefile.
I have committed the documenation clean up. Things still unclear
Sorry - hit send too soon. Once again:
I have committed my doc clean up. Things still unclear are in red. It
would be great if someone i.attcor and 6s savvy could finish it. For
now, I think that i.attcor in it's current shape should not be a part
of the planned GRASS 6.3 release. However, IMHO it should enabled in
the makefile for people fetching latest GRASS from CVS, so the the
final cleanup could be more likely.
I think that i.attcor in it's current shape should not be a part
of the planned GRASS 6.3 release.
Note the 6.3.0 release will be a development preview, not a stable
release.
Thus it shouldn't be a shock to folks if a few things don't work as
expected, as we are clearly labeling that it is only beta-ware.
While it reflects badly on the project when users find things that
don't work, I don't think we should make huge efforts to make 6.3.0
perfect, better to spend that energy fixing problems directly in CVS.
In CVS terms, 6.3.0 will be a tag not a branch. (AFAIU)
As for i.attcor, it's easy enough to change the Makefile before tagging
6.3.0, then back afterwards if that is the general consensus. I express no
opinion on the module as I've never used it.