[GRASS-dev] [GRASS GIS] #1029: r.in.bin: make LFS safe

GRASS GRASS developer
1

#1029: r.in.bin: make LFS safe
----------------------+-----------------------------------------------------
Reporter: hamish | Owner: grass-dev@lists.osgeo.org
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.0
Component: default | Version: svn-releasebranch64
Keywords: r.in.bin | Platform: All
      Cpu: All |
----------------------+-----------------------------------------------------
Hi,

r.in.bin uses int,%d for filesize right now. It should be updated to used
off_t,%ld etc.

maybe check r.out.bin while we're at it.

Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1029&gt;
GRASS GIS <http://grass.osgeo.org>

2

#1029: r.in.bin: make LFS safe
----------------------+-----------------------------------------------------
  Reporter: hamish | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: normal | Milestone: 6.4.0
Component: default | Version: svn-releasebranch64
Resolution: | Keywords: r.in.bin
  Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Comment (by glynn):

Replying to [ticket:1029 hamish]:

> r.in.bin uses int,%d for filesize right now. It should be updated to
used off_t,%ld etc.
>
> maybe check r.out.bin while we're at it.

FWIW, this has already been done in 7.0 with r40374, r40618, r40622, but
there's too much divergence to back-port anything.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1029#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

3

#1029: r.in.bin: make LFS safe
----------------------+-----------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.4
Component: Default | Version: svn-releasebranch64
Keywords: r.in.bin | Platform: All
      Cpu: All |
----------------------+-----------------------------------------------------
Changes (by neteler):

  * milestone: 6.4.0 => 6.4.4

Comment:

Replying to [comment:1 glynn]:
> FWIW, this has already been done in 7.0 with r40374, r40618, r40622,
> but there's too much divergence to back-port anything.

Hence close as "wontfix"?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1029#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

4

#1029: r.in.bin: make LFS safe
----------------------+-----------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.4
Component: Default | Version: svn-releasebranch64
Keywords: r.in.bin | Platform: All
      Cpu: All |
----------------------+-----------------------------------------------------

Comment(by glynn):

Replying to [comment:2 neteler]:
> Replying to [comment:1 glynn]:
> > FWIW, this has already been done in 7.0 with r40374, r40618, r40622,
> > but there's too much divergence to back-port anything.
>
> Hence close as "wontfix"?

Actually, it has been back-ported with r45467 (6.5) and r45934 (6.4).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1029#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

5

#1029: r.in.bin: make LFS safe
----------------------+-----------------------------------------------------
  Reporter: hamish | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 6.4.3
Component: Default | Version: svn-releasebranch64
Resolution: fixed | Keywords: r.in.bin
  Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Changes (by neteler):

  * status: new => closed
  * resolution: => fixed
  * milestone: 6.4.4 => 6.4.3

Comment:

OK, fine, closing.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1029#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>