[GRASS-dev] [GRASS GIS] #1159: v.in.ascii fails with long text file in WinGRASS-6.4.0-1

#1159: v.in.ascii points import fails in WinGRASS-6.4.0-1
------------------------+---------------------------------------------------
Reporter: lponti | Owner: grass-dev@…
     Type: defect | Status: new
Priority: blocker | Milestone: 6.4.1
Component: Vector | Version: 6.4.0
Keywords: v.in.ascii | Platform: MSWindows 7
      Cpu: x86-32 |
------------------------+---------------------------------------------------

Comment(by hellik):

Replying to [comment:19 hamish]:
> eye be blind. louder version of debug message applied to trunk in r43610
so it is not forgotten.

Glynn suggested also following patch which was confirmed as working by
Luigi:

{{{
--- vector/v.in.ascii/in.c~ 2010-09-04 16:31:59.000000000 +0100
+++ vector/v.in.ascii/in.c 2010-09-21 08:57:12.000000000 +0100
@@ -519,8 +519,7 @@
         if (driver) {
             G_message(_("Populating table..."));
             db_commit_transaction(driver);
- if(db_close_database_shutdown_driver(driver) == DB_FAILED)
- G_fatal_error(_("Could not close attribute table. The DBMI
driver did not accept all attributes"));
+ db_close_database_shutdown_driver(driver);
         }
         fclose(tmpascii);
      }
}}}

(see:
http://lists.osgeo.org/pipermail/grass-user/2010-September/057976.html
http://lists.osgeo.org/pipermail/grass-user/2010-September/057985.html)

maybe I've missed something (I can't see this in any branches nor in
trunk)?

should this also be applied?

best regards
Helmut

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1159#comment:20&gt;
GRASS GIS <http://grass.osgeo.org>

#1159: v.in.ascii points import fails in WinGRASS-6.4.0-1
------------------------+---------------------------------------------------
Reporter: lponti | Owner: grass-dev@…
     Type: defect | Status: new
Priority: blocker | Milestone: 6.4.1
Component: Vector | Version: 6.4.0
Keywords: v.in.ascii | Platform: MSWindows 7
      Cpu: x86-32 |
------------------------+---------------------------------------------------

Comment(by glynn):

Replying to [comment:20 hellik]:

> Glynn suggested also following patch which was confirmed as working by
Luigi:

> maybe I've missed something (I can't see this in any branches nor in
trunk)?
>
> should this also be applied?

It's an alternative to r43610, r43550, and r43601. It makes v.in.ascii
consistent with other modules, none of which check the return code from
db_close_database_shutdown_driver().

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1159#comment:21&gt;
GRASS GIS <http://grass.osgeo.org>

#1159: v.in.ascii points import fails in WinGRASS-6.4.0-1
--------------------------+-------------------------------------------------
  Reporter: lponti | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: blocker | Milestone: 6.4.1
Component: Vector | Version: 6.4.0
Resolution: fixed | Keywords: v.in.ascii
  Platform: MSWindows 7 | Cpu: x86-32
--------------------------+-------------------------------------------------
Changes (by hamish):

  * status: new => closed
  * resolution: => fixed

Comment:

tested in 6.4svn and 6.5svn nightly wingrass builds on XP. all working
now.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1159#comment:22&gt;
GRASS GIS <http://grass.osgeo.org>