[GRASS-dev] [GRASS GIS] #1260: Georectifier: RMS broken

#1260: Georectifier: RMS broken
---------------------------+------------------------------------------------
  Reporter: q076256 | Owner: grass-dev@…
      Type: defect | Status: reopened
  Priority: blocker | Milestone: 7.0.0
Component: wxGUI | Version: svn-trunk
Resolution: | Keywords: wingrass, gcp, georect
  Platform: MSWindows 2K | Cpu: x86-32
---------------------------+------------------------------------------------

Comment(by mlennert):

Replying to [ticket:1260 q076256]:
>
> '''Issue 1:'''[[BR]]
> Rectifying raster maps in xy breaks when RMS is calculated. Raster map
was imported and 6 RCP's defined. Whereas first rectification 1st order
was set. Number of RCP's was increased up to 6. Now RMS selected - ok,
then rectification set to 2nd order and RMS selected -> see following
backtrace:[[BR]]
>
> 'ascii' codec can't decode byte 0xfc in position 44: ordinal
> not in range(128)
> Traceback (most recent call last):
> File "c:/osgeo4w/usr/src/grass_trunk/dist.i686-pc-
> mingw32/etc/gui/wxpython/gui_modules/gcpmanager.py", line
> 1292, in OnRMS
> File "c:/osgeo4w/usr/src/grass_trunk/dist.i686-pc-
> mingw32/etc/gui/wxpython/gui_modules/gcpmanager.py", line
> 1603, in RMSError
> File "c:/osgeo4w/usr/src/grass_trunk/dist.i686-pc-
> mingw32/etc/gui/wxpython/gui_modules/gcmd.py", line 573, in
> RunCommand
> File "c:/osgeo4w/usr/src/grass_trunk/dist.i686-pc-
> mingw32/etc/gui/wxpython/gui_modules/gcmd.py", line 77, in
> __init__
> UnicodeDecodeError
> :
> 'ascii' codec can't decode byte 0xfc in position 44: ordinal
> not in range(128)[[BR]]

This is (was) an encoding error. From the pathnames, it seems that the OP
works in a German environment. The po files for the gcp manager (notably
the message about not enough GCPs) contains special characters in German.
I just tried to reproduce in a French environment and the message shows up
correctly. But that's in Debian GNU/Linux, not Windows.

> '''Issue 2:'''[[BR]]
> Now selection rectification 3d order immediately expands the GCP list
with further 4 entries with 0 values, RMS selected shows message: not
enough GCP's.
> Now rectification 2d order selected and RMS run -> same as up here.

I don't understand why here the message would work for 3rd order, but not
for 2d order.

> At this time the GCP #7 can not be defined, a click in the map with
setGCP always set the points in GCP #10 no matter what GCP entry in the
list is selected.[[BR]]

I cannot reproduce this, at least no on Debian GNU/Linux.

> Now added a 7th GCP and choosed rectification 2d order, RMS works fine.
But if there are only 6 GCP activated the behavior is as in the 1st case
up here. In this case there shall be a warning: not enough points,
obviously for 2nd order 6 GCP are not enough![[BR]]

There is a warning. Apparently it failed at the time because of encoding
issues.

> '''Issue 3:'''[[BR]]
> Removing one or more GCPs from the list, saving GCPs and end and restart
Georectifier do not work, see trace below:[[BR]]

Again, I cannot reproduce this in Debian GNU/Linux. ISTR a similar issue a
couple years, but that was solved. Cannot find trace of it, though.

> '''Hint:''' Even more than one empty line at the end of one of the
points files prevents Georectifier from starting up

Cannot reproduce in Debian GNU/Linux.

> '''Issue 4:'''[[BR]]
> Removing a GCP form the the list does not clear the Backward error
field.

Cannot reproduce in Debian GNU/Linux.

Could someone try to reproduce these issues in Windows ?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1260#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>