[GRASS-dev] [GRASS GIS] #1384: wxGUI Preferences: apply or save settings erases Layer Manager menu

#1384: wxGUI Preferences: apply or save settings erases Layer Manager menu
--------------------------------+-------------------------------------------
Reporter: mmetz | Owner: grass-dev@…
     Type: defect | Status: new
Priority: blocker | Milestone: 6.4.2
Component: wxGUI | Version: svn-releasebranch64
Keywords: wxGUI, Preferences | Platform: All
      Cpu: All |
--------------------------------+-------------------------------------------
In the wxGUI Preferences dialog, when clicking on Apply or on Save, the
menu bar "File Settings Raster .." is erased to blank. Cancel works.

Maybe related: in gui/wxpython/gui_modules/preferences.py, the function
_updateSettings of class !PreferencesDialog is never called, and the
current window layout never saved. The function _updateSettings of class
!PreferencesBaseDialog does not check the current window layout.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1384&gt;
GRASS GIS <http://grass.osgeo.org>

#1384: wxGUI Preferences: apply or save settings erases Layer Manager menu
--------------------------------+-------------------------------------------
Reporter: mmetz | Owner: grass-dev@…
     Type: defect | Status: new
Priority: blocker | Milestone: 6.4.2
Component: wxGUI | Version: svn-releasebranch64
Keywords: wxGUI, Preferences | Platform: All
      Cpu: All |
--------------------------------+-------------------------------------------
Changes (by martinl):

* cc: martinl (added)

Comment:

Unable to reproduce this bug? What version of wxPython? Could you send a
screenshot?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1384#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#1384: wxGUI Preferences: apply or save settings erases Layer Manager menu
--------------------------------+-------------------------------------------
Reporter: mmetz | Owner: grass-dev@…
     Type: defect | Status: new
Priority: blocker | Milestone: 6.4.2
Component: wxGUI | Version: svn-releasebranch64
Keywords: wxGUI, Preferences | Platform: All
      Cpu: All |
--------------------------------+-------------------------------------------

Comment(by wenzeslaus):

I also cannot reproduce it (grass 7, Ubuntu 10.04, wxPython 2.8.10.1
(gtk2-unicode)). But I think that problem is caused by new code writen by
me (change menu style). Menu bar is re-created always after "Apply" or
"Save".

The possible solution is do not change menu style (do not re-create menu)
on the fly but only after GUI restart (same as "icon theme").

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1384#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#1384: wxGUI Preferences: apply or save settings erases Layer Manager menu
--------------------------------+-------------------------------------------
Reporter: mmetz | Owner: grass-dev@…
     Type: defect | Status: new
Priority: blocker | Milestone: 6.4.2
Component: wxGUI | Version: svn-releasebranch64
Keywords: wxGUI, Preferences | Platform: All
      Cpu: All |
--------------------------------+-------------------------------------------

Comment(by martinl):

Replying to [comment:2 wenzeslaus]:
> I also cannot reproduce it (grass 7, Ubuntu 10.04, wxPython 2.8.10.1
(gtk2-unicode)). But I think that problem is caused by new code writen by
me (change menu style). Menu bar is re-created always after "Apply" or
"Save".

it can be, see r46397

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1384#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#1384: wxGUI Preferences: apply or save settings erases Layer Manager menu
--------------------------------+-------------------------------------------
Reporter: mmetz | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.2
Component: wxGUI | Version: svn-releasebranch64
Keywords: wxGUI, Preferences | Platform: All
      Cpu: All |
--------------------------------+-------------------------------------------
Changes (by mmetz):

  * priority: blocker => major

Comment:

I have a screenshot attached. My wxPython version is 2.8.12, recently
upgraded from 2.8.11, and I can not remember having seen this before.
Maybe this is the problem, because wxPython often comes with interesting
changes between 2.8.x versions. Or my Fedora version of wxPython is
patched to death...

Downgrading priority.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1384#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#1384: wxGUI Preferences: apply or save settings erases Layer Manager menu
--------------------------------+-------------------------------------------
Reporter: mmetz | Owner: martinl
     Type: defect | Status: assigned
Priority: major | Milestone: 6.4.2
Component: wxGUI | Version: svn-releasebranch64
Keywords: wxGUI, Preferences | Platform: All
      Cpu: All |
--------------------------------+-------------------------------------------
Changes (by martinl):

* cc: martinl (removed)
* cc: grass-dev@… (added)
  * owner: grass-dev@… => martinl
  * status: new => assigned

Comment:

Replying to [comment:3 martinl]:
> Replying to [comment:2 wenzeslaus]:
> > I also cannot reproduce it (grass 7, Ubuntu 10.04, wxPython 2.8.10.1
(gtk2-unicode)). But I think that problem is caused by new code writen by
me (change menu style). Menu bar is re-created always after "Apply" or
"Save".
>
> it can be, see r46397

patch provided by Vaclav applied in r46665 (& backported to
devbr6/relbr64).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1384#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#1384: wxGUI Preferences: apply or save settings erases Layer Manager menu
---------------------+------------------------------------------------------
  Reporter: mmetz | Owner: martinl
      Type: defect | Status: closed
  Priority: major | Milestone: 6.4.2
Component: wxGUI | Version: svn-releasebranch64
Resolution: fixed | Keywords: wxGUI, Preferences
  Platform: All | Cpu: All
---------------------+------------------------------------------------------
Changes (by martinl):

  * status: assigned => closed
  * resolution: => fixed

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1384#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>