[GRASS-dev] [GRASS GIS] #1398: problem with multiple entry selection

GRASS GIS GRASS GIS developer
1

#1398: problem with multiple entry selection
---------------------------------------------------+------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone:
Component: wxGUI | Version: 6.4.1 RCs
Keywords: multiple entries, multiple selections | Platform: All
      Cpu: All |
---------------------------------------------------+------------------------
For commands that allow for multiple entry selections, the entry cannot be
edited in the gui dialog. Example: For a command like r.report, select
map1, map2, map3 and press run. Then delete map1 and map2 from the list in
the map selection control. Press run and r.report is run on map1, map2,
and map3 again.

In gselect.py, when multiple=True, all selections are stored to a list.
New selections are appended to that list. But the list is not updated with
values actually in the control. So any edits to the list of maps (or other
items) is not recognized. I think this is happening in line 493, but I
can't find a way to update the list of multiple values (self.value) with
the items that are actually in the control.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1398&gt;
GRASS GIS <http://grass.osgeo.org>

2

#1398: problem with multiple entry selection
---------------------------------------------------+------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone:
Component: wxGUI | Version: 6.4.1 RCs
Keywords: multiple entries, multiple selections | Platform: All
      Cpu: All |
---------------------------------------------------+------------------------

Comment(by cmbarton):

Maybe I found it.

I think you need to insert

self.value = self.GetCombo().GetValue().split(',')

before line 236 in gselect.py.

I can't commit this tonight, but if someone wants to check and let me know
if this solves the problem for them too, I can do so tomorrow.

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1398#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

3

#1398: problem with multiple entry selection
---------------------------------------------------+------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: 6.4.1 RCs
Keywords: multiple entries, multiple selections | Platform: All
      Cpu: All |
---------------------------------------------------+------------------------
Changes (by martinl):

  * milestone: => 6.4.2

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1398#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

4

#1398: problem with multiple entry selection
---------------------------------------------------+------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: 6.4.1 RCs
Keywords: multiple entries, multiple selections | Platform: All
      Cpu: All |
---------------------------------------------------+------------------------

Comment(by cmbarton):

This should be fixed now in all versions. Can anyone else give it a test
so we can close this?

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1398#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

5

#1398: problem with multiple entry selection
---------------------------------------------------+------------------------
Reporter: cmbarton | Owner: martinl
     Type: defect | Status: assigned
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: 6.4.1 RCs
Keywords: multiple entries, multiple selections | Platform: All
      Cpu: All |
---------------------------------------------------+------------------------
Changes (by martinl):

* cc: grass-dev@… (added)
  * owner: grass-dev@… => martinl
  * status: new => assigned

Comment:

Replying to [comment:3 cmbarton]:
> This should be fixed now in all versions. Can anyone else give it a test
so we can close this?

Not really it introduced extra comma before first selected map. Hopefully
fixed in r48264.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1398#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

6

#1398: problem with multiple entry selection
---------------------------------------------------+------------------------
Reporter: cmbarton | Owner: martinl
     Type: defect | Status: assigned
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: 6.4.1 RCs
Keywords: multiple entries, multiple selections | Platform: All
      Cpu: All |
---------------------------------------------------+------------------------

Comment(by cmbarton):

I just tested and it seems to be fixed.

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1398#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

7

#1398: problem with multiple entry selection
-----------------------+----------------------------------------------------
  Reporter: cmbarton | Owner: martinl
      Type: defect | Status: closed
  Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: 6.4.1 RCs
Resolution: fixed | Keywords: multiple entries, multiple selections
  Platform: All | Cpu: All
-----------------------+----------------------------------------------------
Changes (by martinl):

  * status: assigned => closed
  * resolution: => fixed

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1398#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>