[GRASS-dev] [GRASS GIS] #1400: preferences apply doesn't seem to do anything

#1400: preferences apply doesn't seem to do anything
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: unspecified
Keywords: preferences | Platform: MacOSX
      Cpu: OSX/Intel |
-------------------------+--------------------------------------------------
Pressing the apply button in preferences seems to have no effect on the
current session.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1400&gt;
GRASS GIS <http://grass.osgeo.org>

#1400: preferences apply doesn't seem to do anything
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: unspecified
Keywords: preferences | Platform: MacOSX
      Cpu: OSX/Intel |
-------------------------+--------------------------------------------------

Comment(by martinl):

It should, can you give an example?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1400#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#1400: preferences apply doesn't seem to do anything
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: unspecified
Keywords: preferences | Platform: MacOSX
      Cpu: OSX/Intel |
-------------------------+--------------------------------------------------

Comment(by cmbarton):

I went to test this and I cannot do so because the settings dialog is
modal in GRASS 6.4.2. So I can't tell if any setting changes are sticking
when I press the "apply" button. Because I cannot exit the settings dialog
to check until I press OK.

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1400#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#1400: preferences apply doesn't seem to do anything
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: unspecified
Keywords: preferences | Platform: MacOSX
      Cpu: OSX/Intel |
-------------------------+--------------------------------------------------

Comment(by martinl):

Replying to [comment:2 cmbarton]:
> I went to test this and I cannot do so because the settings dialog is
modal in GRASS 6.4.2. So I can't tell if any setting changes are sticking
when I press the "apply" button. Because I cannot exit the settings dialog
to check until I press OK.

are you speaking about GUI Settings dialog? There is no OK button, only
Cancel, Apply and Save. Dialog is not modal, and Apply closes the dialog.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1400#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#1400: preferences apply doesn't seem to do anything
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: unspecified
Keywords: preferences | Platform: MacOSX
      Cpu: OSX/Intel |
-------------------------+--------------------------------------------------

Comment(by hamish):

Replying to [comment:3 martinl]:
> There is no OK button, only Cancel, Apply and Save.
> Dialog is not modal, and Apply closes the dialog.

so IIUC [Apply] uses the new settings without saving to the wxrc? I was
wondering about that. which leads to the question of why call it "Apply"
and not "Ok"? (I think Apply is kinda weird in most software, nothing
grass specific)

shrug,
Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1400#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#1400: preferences apply doesn't seem to do anything
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: unspecified
Keywords: preferences | Platform: MacOSX
      Cpu: OSX/Intel |
-------------------------+--------------------------------------------------

Comment(by cmbarton):

Replying to [comment:3 martinl]:
> Replying to [comment:2 cmbarton]:
> > I went to test this and I cannot do so because the settings dialog is
modal in GRASS 6.4.2. So I can't tell if any setting changes are sticking
when I press the "apply" button. Because I cannot exit the settings dialog
to check until I press OK.
>
> are you speaking about GUI Settings dialog? There is no OK button, only
Cancel, Apply and Save. Dialog is not modal, and Apply closes the dialog.

I meant "save" instead of "OK".

This settings dialog is modal in GRASS 6.4.2 so I cannot test whether or
not the settings are applied or not without saving.

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1400#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#1400: preferences apply doesn't seem to do anything
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: unspecified
Keywords: preferences | Platform: MacOSX
      Cpu: OSX/Intel |
-------------------------+--------------------------------------------------

Comment(by cmbarton):

Replying to [comment:4 hamish]:
> Replying to [comment:3 martinl]:
> > There is no OK button, only Cancel, Apply and Save.
> > Dialog is not modal, and Apply closes the dialog.
>
> so IIUC [Apply] uses the new settings without saving to the wxrc?

Right. That's how it's supposed to work AFAIK. That way you can make some
settings for the current session but not have to save them for future
sessions.

  I was wondering about that. which leads to the question of why call it
"Apply" and not "Ok"? (I think Apply is kinda weird in most software,
nothing grass specific)
>
>
> shrug,
> Hamish

The second, somewhat related use of "apply" is so that you can change some
parameters from a dialog and not have the dialog close (which is often the
default behavior when the "OK" or similar button is pressed).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1400#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

#1400: preferences apply doesn't seem to do anything
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: unspecified
Keywords: preferences | Platform: MacOSX
      Cpu: OSX/Intel |
-------------------------+--------------------------------------------------

Comment(by martinl):

Replying to [comment:5 cmbarton]:

> This settings dialog is modal in GRASS 6.4.2 so I cannot test whether or
not the settings are applied or not without saving.

why the modal dialog is problem? When you press button 'Apply', the
settings is stored for current session and the dialog is closed.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1400#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>

#1400: preferences apply doesn't seem to do anything
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: unspecified
Keywords: preferences | Platform: MacOSX
      Cpu: OSX/Intel |
-------------------------+--------------------------------------------------
Changes (by martinl):

  * reporter: digit,cmbarton => cmbarton

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1400#comment:9&gt;
GRASS GIS <http://grass.osgeo.org>

#1400: preferences apply doesn't seem to do anything
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: unspecified
Keywords: preferences | Platform: MacOSX
      Cpu: OSX/Intel |
-------------------------+--------------------------------------------------

Comment(by cmbarton):

In most cases, including in many or most GRASS cases, pressing "apply"
allows the dialog to remain open non-modally to do something with the new
settings of whatever apply works with.

I did some spot checking.

The following items changed in settings also show up in the current GRASS
session when the "apply" button is pressed.
-ask when removing map from layer tree
-expand all (element list)
-status bar mode (need to open a new display for this to register)

The following items changed do not show up in the current GRASS session
with "apply" and only show up when the "save" button is pressed.
-command font (NB: only some fonts, maybe only 2, show up even with
"save"; but font size always affected by "save")
-display font
-close dialog when command is successfully finished

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1400#comment:10&gt;
GRASS GIS <http://grass.osgeo.org>

#1400: preferences apply doesn't seem to do anything
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: unspecified
Keywords: preferences | Platform: MacOSX
      Cpu: OSX/Intel |
-------------------------+--------------------------------------------------

Comment(by cmbarton):

Here is a reformatting of my results for easier reading

The following items changed in settings also show up in the current GRASS
session when the "apply" button is pressed. [[BR]][[BR]]
-ask when removing map from layer tree -expand all (element list)[[BR]]
-status bar mode (need to open a new display for this to register)[[BR]]

The following items changed do not show up in the current GRASS session
with "apply" and only show up when the "save" button is pressed.
[[BR]][[BR]]
-command font (NB: only some fonts, maybe only 2, show up even with
"save"; but font size always affected by "save") [[BR]]
-display font [[BR]]
-close dialog when command is successfully finished

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1400#comment:11&gt;
GRASS GIS <http://grass.osgeo.org>

#1400: preferences apply doesn't seem to do anything
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: unspecified
Keywords: preferences | Platform: MacOSX
      Cpu: OSX/Intel |
-------------------------+--------------------------------------------------

Comment(by cmbarton):

This is now working on the Mac. On other platforms? Maybe we can close.

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1400#comment:12&gt;
GRASS GIS <http://grass.osgeo.org>

#1400: preferences apply doesn't seem to do anything
-----------------------+----------------------------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: unspecified
Resolution: fixed | Keywords: preferences
  Platform: MacOSX | Cpu: OSX/Intel
-----------------------+----------------------------------------------------
Changes (by wenzeslaus):

  * status: new => closed
  * resolution: => fixed

Comment:

Replying to [comment:12 cmbarton]:
> This is now working on the Mac. On other platforms? Maybe we can close.
>
No further problems reported, closing. If there will be some problems,
please open new specific tickets.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1400#comment:13&gt;
GRASS GIS <http://grass.osgeo.org>