[GRASS-dev] [GRASS GIS] #1448: run model menu item does not seem to work

#1448: run model menu item does not seem to work
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: Default | Version: svn-trunk
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
I made and saved a model using the graphical modeler. The model works
fine. I can load the saved model into the graphical modeler and it works
fine.

If I select "run model" from the file menu and select this saved model,
nothing happens. No error and nothing produced.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1448&gt;
GRASS GIS <http://grass.osgeo.org>

#1448: run model menu item does not seem to work
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: svn-trunk
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by cmbarton):

  * component: Default => wxGUI

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1448#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#1448: run model menu item does not seem to work
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: martinl
     Type: defect | Status: assigned
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: svn-trunk
Keywords: modeler | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by martinl):

* cc: grass-dev@… (added)
  * keywords: => modeler
  * status: new => assigned
  * owner: grass-dev@… => martinl

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1448#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#1448: run model menu item does not seem to work
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: martinl
     Type: defect | Status: assigned
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: svn-trunk
Keywords: modeler | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by martinl):

There is an error (check 'command output' if you have no debug level
defined).

{{{
   File "/usr/local/src/grass64_release/dist.i686-pc-linux-
gnu/etc/wxpython/gui_modules/gmodeler.py", line 1751, in _setPen
     pen = self.GetPen()
   File "/usr/lib/python2.6/dist-
packages/wx-2.8-gtk2-unicode/wx/lib/ogl/_basic.py", line 2069, in GetPen
     return self._pen
AttributeError: 'ModelAction' object has no attribute '_pen'
}}}

Hopefully fixed in r48307 (trunk) and r48308 (devbr6). After some testing
it could be backported to `relbr64`.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1448#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#1448: run model menu item does not seem to work
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: martinl
     Type: defect | Status: assigned
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: svn-trunk
Keywords: modeler | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by cmbarton):

Tested in trunk. Now it runs without an error. But it does not respect the
'parameterization' checkbox when run this way. That is, it does not open a
dialog for file selection or module options when the relevant
parameterization box is checked. When loaded and run in the modeler GUI
window, it does present dialogs for parameterized options. I don't know
if this is by design or not.

Michael

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1448#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#1448: run model menu item does not seem to work
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: martinl
     Type: defect | Status: assigned
Priority: normal | Milestone: 6.4.2
Component: wxGUI | Version: svn-trunk
Keywords: modeler | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by martinl):

Replying to [comment:4 cmbarton]:
> Tested in trunk. Now it runs without an error. But it does not respect
the 'parameterization' checkbox when run this way. That is, it does not
open a dialog for file selection or module options when the relevant
parameterization box is checked. When loaded and run in the modeler GUI
window, it does present dialogs for parameterized options. I don't know
if this is by design or not.

hopefully fixed in r48342 (trunk) and r48343 (develbr6).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1448#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#1448: run model menu item does not seem to work
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: martinl
     Type: defect | Status: assigned
Priority: critical | Milestone: 6.4.2
Component: wxGUI | Version: svn-trunk
Keywords: modeler | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by martinl):

  * priority: normal => critical

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1448#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

#1448: run model menu item does not seem to work
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: martinl
     Type: defect | Status: assigned
Priority: critical | Milestone: 6.4.2
Component: wxGUI | Version: svn-trunk
Keywords: modeler | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by martinl):

Replying to [comment:6 martinl]:

Candidates for backport (relbr64):

  * r48308
  * r48343

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1448#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>

#1448: run model menu item does not seem to work
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: martinl
     Type: defect | Status: assigned
Priority: critical | Milestone: 6.4.2
Component: wxGUI | Version: svn-trunk
Keywords: modeler | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by cmbarton):

I just tested. Parameterization is now respected in the run model. AFAICT
it works fine. Thanks much!

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1448#comment:8&gt;
GRASS GIS <http://grass.osgeo.org>

#1448: run model menu item does not seem to work
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: martinl
     Type: defect | Status: assigned
Priority: critical | Milestone: 6.4.2
Component: wxGUI | Version: svn-trunk
Keywords: modeler | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by martinl):

Replying to [comment:8 cmbarton]:
> I just tested. Parameterization is now respected in the run model.
AFAICT it works fine. Thanks much!

Backported to `relr64` in r48387. Before closing this ticket, could you
test also G64? Thanks.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1448#comment:9&gt;
GRASS GIS <http://grass.osgeo.org>

#1448: run model menu item does not seem to work
--------------------------+-------------------------------------------------
  Reporter: cmbarton | Owner: martinl
      Type: defect | Status: closed
  Priority: critical | Milestone: 6.4.2
Component: wxGUI | Version: svn-trunk
Resolution: fixed | Keywords: modeler
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Changes (by cmbarton):

  * status: assigned => closed
  * resolution: => fixed

Comment:

Tested and it seems to work fine. I ran into an error initially that I
traced to the fact that the output argument for r.blend has changed in
GRASS 7 from "output" to "output_prefix" . A more accurate name for the
argument but it breaks backward compatibility (permitted across version
changes of course).

Thanks again for making this very nice tool for GRASS. I've already been
recommending it as a way to get started writing Python scripts. I'll go
ahead and close this.

BTW, how does the variables section work for the modeler?

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1448#comment:10&gt;
GRASS GIS <http://grass.osgeo.org>

#1448: run model menu item does not seem to work
--------------------------+-------------------------------------------------
  Reporter: cmbarton | Owner: martinl
      Type: defect | Status: closed
  Priority: critical | Milestone: 6.4.2
Component: wxGUI | Version: svn-trunk
Resolution: fixed | Keywords: modeler
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------

Comment(by martinl):

Replying to [comment:10 cmbarton]:

> BTW, how does the variables section work for the modeler?

http://www.youtube.com/watch?v=RztxMXXtA0s&feature=player_embedded#!

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1448#comment:11&gt;
GRASS GIS <http://grass.osgeo.org>

#1448: run model menu item does not seem to work
--------------------------+-------------------------------------------------
  Reporter: cmbarton | Owner: martinl
      Type: defect | Status: closed
  Priority: critical | Milestone: 6.4.2
Component: wxGUI | Version: svn-trunk
Resolution: fixed | Keywords: modeler
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------

Comment(by cmbarton):

Very cool!

Thanks.

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1448#comment:12&gt;
GRASS GIS <http://grass.osgeo.org>