[GRASS-dev] [GRASS GIS] #1454: v.outlier manual page does not refer that the vector needs to be a 3D one

GRASS GIS GRASS GIS developer
1

#1454: v.outlier manual page does not refer that the vector needs to be a 3D one
-------------------------+--------------------------------------------------
Reporter: lutra | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Docs | Version: 6.4.1
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Summary says it all

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1454&gt;
GRASS GIS <http://grass.osgeo.org>

2

#1454: v.outlier manual page does not refer that the vector needs to be a 3D one
-------------------------+--------------------------------------------------
Reporter: lutra | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Docs | Version: 6.4.1
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by neteler):

I would suggest this modification:
{{{
--- description.html (revision 48395)
+++ description.html (working copy)
@@ -1,6 +1,6 @@
  <h2>DESCRIPTION</h2>

-<em>v.outlier</em> removes outlier points. By default, the outlier
+<em>v.outlier</em> removes outliers in a 3D point cloud. By default, the
outlier
  identification is done by a bicubic spline interpolation of the
  observation with a high regularization parameter and a low resolution
  in south-north and east-west directions. Those points that differ in
}}}

Makes sense?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1454#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

3

#1454: v.outlier manual page does not refer that the vector needs to be a 3D one
-------------------------+--------------------------------------------------
Reporter: lutra | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Docs | Version: 6.4.1
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by lutra):

>
> Makes sense?

yes!

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1454#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

4

#1454: v.outlier manual page does not refer that the vector needs to be a 3D one
-------------------------+--------------------------------------------------
Reporter: lutra | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Docs | Version: 6.4.1
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by martinl):

So `v.outlier` should complain if input is 2D vector data, right?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1454#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

5

#1454: v.outlier manual page does not refer that the vector needs to be a 3D one
-------------------------+--------------------------------------------------
Reporter: lutra | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 6.4.2
Component: Docs | Version: 6.4.1
Keywords: v.outlier | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by martinl):

  * keywords: => v.outlier
  * milestone: => 6.4.2

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1454#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

6

#1454: v.outlier manual page does not refer that the vector needs to be a 3D one
-------------------------+--------------------------------------------------
Reporter: lutra | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 6.4.2
Component: Docs | Version: 6.4.1
Keywords: v.outlier | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by hamish):

Replying to [comment:3 martinl]:
> So `v.outlier` should complain if input is 2D vector data, right?

yes,

https://trac.osgeo.org/grass/browser/grass/trunk/vector/v.outlier/main.c#L377

Vect_is_3d() seems to be the test to use..

Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1454#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

7

#1454: v.outlier manual page does not refer that the vector needs to be a 3D one
--------------------------+-------------------------------------------------
  Reporter: lutra | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: normal | Milestone: 6.4.2
Component: Docs | Version: 6.4.1
Resolution: fixed | Keywords: v.outlier
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Changes (by neteler):

  * status: new => closed
  * resolution: => fixed

Comment:

Replying to [comment:5 hamish]:
> Replying to [comment:3 martinl]:
> > So `v.outlier` should complain if input is 2D vector data, right?
>
> yes,
...
> Vect_is_3d() seems to be the test to use..

You mean the test which *is* used:
{{{
    /* Input vector must be 3D */
     if (!Vect_is_3d(&In))
         G_fatal_error(_("Input vector map <%s> is not 3D!"),
in_opt->answer);
}}}

Manual fixed, closing.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1454#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

8

#1454: v.outlier manual page does not refer that the vector needs to be a 3D one
--------------------------+-------------------------------------------------
  Reporter: lutra | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: normal | Milestone: 6.4.2
Component: Docs | Version: 6.4.1
Resolution: fixed | Keywords: v.outlier
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------

Comment(by hamish):

Replying to [comment:6 neteler]:
> You mean the test which *is* used:

oops, missed that.

Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1454#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>