[GRASS-dev] [GRASS GIS] #1467: include/gis.h hard-coding version a the SVN revision level

#1467: include/gis.h hard-coding version a the SVN revision level
-------------------------+--------------------------------------------------
Reporter: strk | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone:
Component: Default | Version: unspecified
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Setting GIS_H_VERSION to the SVN revision level and using that to check
compatibility between clients and library means no two SVN revisions would
be considered compatible. Is this intended ?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1467&gt;
GRASS GIS <http://grass.osgeo.org>

#1467: include/gis.h hard-coding version a the SVN revision level
-------------------------+--------------------------------------------------
Reporter: strk | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone:
Component: Default | Version: unspecified
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by strk):

The attached patch makes the incompatibility error message more complete
(and clearer to me).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1467#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#1467: include/gis.h hard-coding version a the SVN revision level
-------------------------+--------------------------------------------------
Reporter: strk | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone:
Component: Default | Version: unspecified
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by glynn):

Replying to [ticket:1467 strk]:
> Setting GIS_H_VERSION to the SVN revision level and using that to check
compatibility between clients and library means no two SVN revisions would
be considered compatible. Is this intended ?
Yes.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1467#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#1467: include/gis.h hard-coding version a the SVN revision level
-------------------------+--------------------------------------------------
Reporter: strk | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone:
Component: Default | Version: unspecified
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by neteler):

Replying to [comment:1 strk]:
> The attached patch makes the incompatibility error message more complete
(and clearer to me).

Indeed the current message (here, using spgrass6 in R):
{{{
GRASS GIS interface loaded with GRASS version: GRASS 6.4.2svn48651M (2011)
and location: latlong
ERROR: Incompatible library version for module. You need to rebuild GRASS
        or untangle multiple installations.
}}}

is fairly unhelpful. No clue what to recompile since GRASS is working...

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1467#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#1467: include/gis.h hard-coding version a the SVN revision level
-------------------------+--------------------------------------------------
Reporter: strk | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: minor | Milestone: 6.4.4
Component: LibGIS | Version: svn-develbranch6
Keywords: api | Platform: All
      Cpu: All |
-------------------------+--------------------------------------------------
Changes (by hamish):

  * component: Default => LibGIS
  * priority: normal => minor
  * platform: Unspecified => All
  * version: unspecified => svn-develbranch6
  * milestone: => 6.4.4
  * keywords: => api
  * type: defect => enhancement
  * cpu: Unspecified => All

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1467#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#1467: include/gis.h hard-coding version a the SVN revision level
-------------------------+--------------------------------------------------
Reporter: strk | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: minor | Milestone: 6.4.4
Component: LibGIS | Version: svn-develbranch6
Keywords: api | Platform: All
      Cpu: All |
-------------------------+--------------------------------------------------

Comment(by neteler):

Replying to [comment:3 neteler]:
> Replying to [comment:1 strk]:
> > The attached patch makes the incompatibility error message more
complete (and clearer to me).
>
> Indeed the current message (here, using spgrass6 in R):
> {{{
> GRASS GIS interface loaded with GRASS version: GRASS 6.4.2svn48651M
(2011)
> and location: latlong
> ERROR: Incompatible library version for module. You need to rebuild
GRASS
> or untangle multiple installations.
> }}}
>
> is fairly unhelpful. No clue what to recompile since GRASS is working...

New message:

{{{
...
if [ "/home/neteler/software/grass71/dist.x86_64-unknown-linux-
gnu/bin/v.perturb" != "" ] ; then
GISRC=/home/neteler/software/grass71/dist.x86_64-unknown-linux-
gnu/demolocation/.grassrc71
GISBASE=/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu
PATH="/home/neteler/software/grass71/dist.x86_64-unknown-linux-
gnu/bin:/home/neteler/software/grass71/dist.x86_64-unknown-linux-
gnu/bin:/home/neteler/software/grass71/dist.x86_64-unknown-linux-
gnu/scripts:$PATH" PYTHONPATH="/home/neteler/software/grass71/dist.x86_64
-unknown-linux-gnu/etc/python:/home/neteler/software/grass71/dist.x86_64
-unknown-linux-gnu/gui/wxpython:$PYTHONPATH"
LD_LIBRARY_PATH="/home/neteler/software/grass71/dist.x86_64-unknown-linux-
gnu/bin:/home/neteler/software/grass71/dist.x86_64-unknown-linux-
gnu/scripts:/home/neteler/software/grass71/dist.x86_64-unknown-linux-
gnu/lib:/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu/lib:"
LC_ALL=C /home/neteler/software/grass71/dist.x86_64-unknown-linux-
gnu/bin/v.perturb --html-description < /dev/null | grep -v
'</body>\|</html>' > v.perturb.tmp.html ; fi
ERROR: Module built against version $Revision: 59317 $ trying to use
        version $Revision: 60123 $.You need to rebuild GRASS GIS or
untangle
        multiple installations.
make[3]: *** [v.patch.tmp.html] Error 1
rm v.patch.tmp.html
make[3]: Leaving directory `/home/neteler/software/grass71/vector/v.patch'
}}}

Patch applied to trunk in r60135.

Backport desired (perhaps with improved wording).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1467#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#1467: include/gis.h hard-coding version a the SVN revision level
-------------------------+--------------------------------------------------
Reporter: strk | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: minor | Milestone: 6.4.4
Component: LibGIS | Version: svn-develbranch6
Keywords: api | Platform: All
      Cpu: All |
-------------------------+--------------------------------------------------

Comment(by strk):

Sounds good to me, thanks.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1467#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

#1467: include/gis.h hard-coding version a the SVN revision level
--------------------------+-------------------------------------------------
  Reporter: strk | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: minor | Milestone: 6.4.4
Component: LibGIS | Version: svn-develbranch6
Resolution: fixed | Keywords: api
  Platform: All | Cpu: All
--------------------------+-------------------------------------------------
Changes (by neteler):

  * status: new => closed
  * resolution: => fixed

Comment:

Backported to relbr7 (r60193), devlbr6 (r60194) and relbr6 (r60195).

Thanks for the patch & closing.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1467#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>