[GRASS-dev] [GRASS GIS] #1607: WXGUI regression - attribute query fails to display text attribute values

GRASS GIS GRASS GIS developer
1

#1607: WXGUI regression - attribute query fails to display text attribute values
-------------------------+--------------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.3
Component: wxGUI | Version: 6.4.2
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Steps to reproduce:
  * add a vector map
  * use attribute query tool to get object attributes
  * observe an error instead of attribute value "Unable to decode value.
Set encoding in GUI preferences ('Attributes')."
  * repeat the same steps in 6.4.0 and observe correct attribute data
values

Both wxgui instances have no "attribute data encoding" set.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1607&gt;
GRASS GIS <http://grass.osgeo.org>

2

#1607: WXGUI regression - attribute query fails to display text attribute values
-------------------------+--------------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.3
Component: wxGUI | Version: 6.4.2
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by neteler):

Do you have a sample map to test?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1607#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

3

#1607: WXGUI regression - attribute query fails to display text attribute values
-------------------------+--------------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.3
Component: wxGUI | Version: 6.4.2
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by marisn):

Replying to [comment:1 neteler]:
> Do you have a sample map to test?
Here You go. Just create a location and import attached file. Compare
output of 6.4.0 and 6.4.x current on the same file.

The idea of setting encoding in a GUI preferences is flawed by design. I
routinely deal with datasets in different encodings (map1 - utf-8; map2 -
ISO-8859-13; etc.). Still this is a change that needs to be done in GRASS
7 to allow specifying encoding for each vector dataset/layer(?)
separately.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1607#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

4

#1607: WXGUI regression - attribute query fails to display text attribute values
-------------------------+--------------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.3
Component: wxGUI | Version: 6.4.2
Keywords: query | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by neteler):

  * keywords: => query

Comment:

Yes, confirmed.

OGR can decipher it:
{{{
ogrinfo grass_encoding.shp grass_encoding
INFO: Open of `grass_encoding.shp'
       using driver `ESRI Shapefile' successful.

Layer name: grass_encoding
Geometry: Point
Feature Count: 2
Extent: (490813.154373, 280495.272002) - (516942.353107, 284572.168258)
Layer SRS WKT:
PROJCS["LKS92_Latvia_TM",
     GEOGCS["GCS_LKS92",
         DATUM["Latvia_1992",
             SPHEROID["GRS_1980",6378137,298.257222101]],
         PRIMEM["Greenwich",0],
         UNIT["Degree",0.017453292519943295]],
     PROJECTION["Transverse_Mercator"],
     PARAMETER["latitude_of_origin",0],
     PARAMETER["central_meridian",24],
     PARAMETER["scale_factor",0.9996],
     PARAMETER["false_easting",500000],
     PARAMETER["false_northing",-6000000],
     UNIT["Meter",1]]
id: Integer (10.0)
nosaukums: String (80.0)
OGRFeature(grass_encoding):0
   id (Integer) = (null)
   nosaukums (String) = âðòï
   POINT (490813.154373089957517 284572.168258102843538)

OGRFeature(grass_encoding):1
   id (Integer) = (null)
   nosaukums (String) = çèþì
   POINT (516942.35310710943304 280495.272001731034834)
}}}

while GRASS' wxGUI query tool cannot giving the indicated error.

Also the Tcl/TK form fails: "nosaukums : âðòï "

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1607#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

5

#1607: WXGUI regression - attribute query fails to display text attribute values
-------------------------+--------------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.3
Component: wxGUI | Version: 6.4.2
Keywords: query | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by marisn):

Replying to [comment:3 neteler]:
> Yes, confirmed.
>
> while GRASS' wxGUI query tool cannot giving the indicated error.
>
> Also the Tcl/TK form fails: "nosaukums : âðòï "

Well - OGR just passes raw string trough. It's not correct, still for a
latin letters based text it will work just fine. I made a bad example, as
I should be using example "Rîga", which is incorrect, still for anyone in
Latvia it would be clear that it should be "Rīga". GRASS 6.4.0 was just
passing-through any attribute data and thus ignored any coding issues.
Changes in 6.4.x introduced (broken by design) recoding of values and thus
instead of just seeing broken string, that might be meaningful enough to
be fine, now it displays error message. Saying "just set correct encoding
in blahblah" for non-technical users equals "no attributes for You!".
Why it's broken? Try to set encoding in preferences to datasets encoding:
"CP-1257"

{{{
Settings applied to current session but not saved
Traceback (most recent call last):
   File "/home/maris/soft/grass_64/dist.x86_64-unknown-linux-
gnu/etc/wxpython/lmgr/frame.py", line 1355, in
OnShowAttributeTable

selection = selection)
   File "/home/maris/soft/grass_64/dist.x86_64-unknown-linux-
gnu/etc/wxpython/dbmgr/manager.py", line 641, in __init__

self._createBrowsePage()
   File "/home/maris/soft/grass_64/dist.x86_64-unknown-linux-
gnu/etc/wxpython/dbmgr/manager.py", line 688, in
_createBrowsePage

self.mapDBInfo, layer)
   File "/home/maris/soft/grass_64/dist.x86_64-unknown-linux-
gnu/etc/wxpython/dbmgr/manager.py", line 93, in __init__

keyColumn = self.LoadData(layer)
   File "/home/maris/soft/grass_64/dist.x86_64-unknown-linux-
gnu/etc/wxpython/dbmgr/manager.py", line 246, in LoadData

self.AddDataRow(i, record, columns, keyId)
   File "/home/maris/soft/grass_64/dist.x86_64-unknown-linux-
gnu/etc/wxpython/dbmgr/manager.py", line 295, in AddDataRow

self.itemDataMap[i].append(unicodeValue(value))
   File "/home/maris/soft/grass_64/dist.x86_64-unknown-linux-
gnu/etc/wxpython/dbmgr/vinfo.py", line 35, in unicodeValue

value = unicode(value, enc)
LookupError
:
unknown encoding: CP-1257
}}}

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1607#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

6

#1607: WXGUI regression - attribute query fails to display text attribute values
-------------------------+--------------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.4
Component: wxGUI | Version: 6.4.2
Keywords: query | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by neteler):

  * milestone: 6.4.3 => 6.4.4

Comment:

(see also Ticket #1609)

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1607#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>