[GRASS-dev] [GRASS GIS] #1717: layer remove does not work on multiple selections

#1717: layer remove does not work on multiple selections
-------------------------+--------------------------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.3
Component: Default | Version: unspecified
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
You can make multiple selections in the layer manager, but you can't DO
anything with multiple selections (like move or remove them). We should
either not permit multiple selections (I think it is a flag for the tree
control) or fix it so that you can do something with multiple selections.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1717&gt;
GRASS GIS <http://grass.osgeo.org>

#1717: layer remove does not work on multiple selections
-------------------------------------------+--------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.3
Component: wxGUI | Version: unspecified
Keywords: layer manager, multiselection | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------------------+--------------------------------
Changes (by martinl):

  * keywords: => layer manager, multiselection
  * component: Default => wxGUI

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1717#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

Just airing my opinion: it would be really, really, good if the second option would be possible, having the ability to do something (like delete) multiple selection. I would make working with layers that much easier.

On 09/02/2012 04:48 AM, GRASS GIS wrote:

#1717: layer remove does not work on multiple selections
-------------------------+--------------------------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 6.4.3
Component: Default | Version: unspecified
  Keywords: | Platform: Unspecified
       Cpu: Unspecified |
-------------------------+--------------------------------------------------
  You can make multiple selections in the layer manager, but you can't DO
  anything with multiple selections (like move or remove them). We should
  either not permit multiple selections (I think it is a flag for the tree
  control) or fix it so that you can do something with multiple selections.

#1717: layer remove does not work on multiple selections
-------------------------------------------+--------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
Keywords: layer manager, multiselection | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------------------+--------------------------------
Changes (by neteler):

  * version: unspecified => svn-releasebranch64
  * type: defect => enhancement
  * milestone: 6.4.3 => 6.4.4

Comment:

On Sun, Sep 2, 2012 at 10:07 AM, Paulo van Breugel
<p.vanbreugel@gmail.com> wrote:
> Just airing my opinion: it would be really, really, good if the second
> option would be possible, having the ability to do something (like
delete)
> multiple selection. I would make working with layers that much easier.

I have the same wish. When working with many layers (e.g., after multi-
layer
import from GeoTIFF), this missing feature arises.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1717#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#1717: layer remove does not work on multiple selections
-------------------------------------------+--------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
Keywords: layer manager, multiselection | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------------------+--------------------------------

Comment(by annakrat):

Are you sure you can't remove them? It's working for me. There are 3
enabled options - remove, zoom, set region.

I recently fixed layer selection in grass 7 (#1616), seems that nobody
tested yet... I'd like to backport it soon.

Anna

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1717#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#1717: layer remove does not work on multiple selections
-------------------------------------------+--------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
Keywords: layer manager, multiselection | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------------------+--------------------------------

Comment(by cmbarton):

I tested this on GRASS 7 compiled yesterday. Removing, moving, and zooming
only affects one of the maps selected.

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1717#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#1717: layer remove does not work on multiple selections
-------------------------------------------+--------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
Keywords: layer manager, multiselection | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------------------+--------------------------------

Comment(by annakrat):

Are we really talking about the same thing? For example when I select 2
layers and choose 'Set computational region from selected maps' this
command is executed (copied from command output):

g.region rast=elevation@PERMANENT,aspect@PERMANENT -p

So this is ok. Is it possible that it's not working on Mac? I agree that
it is not possible to move them by dragging.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1717#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

I just compiled the latest build (revision 53062) (working on Ubuntu 12.04) and I can confirm it only works on one of the maps selected (as far as I know, it never has been possible to act on more then one layer?)

On 09/02/2012 11:12 PM, GRASS GIS wrote:

#1717: layer remove does not work on multiple selections
-------------------------------------------+--------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
  Keywords: layer manager, multiselection | Platform: Unspecified
       Cpu: Unspecified |
-------------------------------------------+--------------------------------

Comment(by cmbarton):

  I tested this on GRASS 7 compiled yesterday. Removing, moving, and zooming
  only affects one of the maps selected.

  Michael

I was mostly concerned with the 'remove' function. But I just tried the 'Set computational region from selected maps' and it doesn't work for me either. It sets the region for the first map of the selected ones.

But I am running GRASS GIS 7 (on Ubuntu 12.04), so was this not changed for GRASS 7?

Cheers

Paulo

On 09/03/2012 10:41 AM, GRASS GIS wrote:

#1717: layer remove does not work on multiple selections
-------------------------------------------+--------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
  Keywords: layer manager, multiselection | Platform: Unspecified
       Cpu: Unspecified |
-------------------------------------------+--------------------------------

Comment(by annakrat):

  Are we really talking about the same thing? For example when I select 2
  layers and choose 'Set computational region from selected maps' this
  command is executed (copied from command output):

  g.region rast=elevation@PERMANENT,aspect@PERMANENT -p

  So this is ok. Is it possible that it's not working on Mac? I agree that
  it is not possible to move them by dragging.

#1717: layer remove does not work on multiple selections
-------------------------------------------+--------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
Keywords: layer manager, multiselection | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------------------+--------------------------------

Comment(by annakrat):

Maybe the different behaviour comes from different version of wx. I have
quite old 2.8.10.1 which is working ok.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1717#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

#1717: layer remove does not work on multiple selections
-------------------------------------------+--------------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
Keywords: layer manager, multiselection | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------------------+--------------------------------

Comment(by annakrat):

Could you try r53064 in grass7?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1717#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>

Brilliant, it works (with GRASS 7, r53065)!! You made my day!

Cheers,

Paulo

On 09/03/2012 12:52 PM, GRASS GIS wrote:

#1717: layer remove does not work on multiple selections
-------------------------------------------+--------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
  Keywords: layer manager, multiselection | Platform: Unspecified
       Cpu: Unspecified |
-------------------------------------------+--------------------------------

Comment(by annakrat):

  Could you try r53064 in grass7?

#1717: layer remove does not work on multiple selections
--------------------------+-------------------------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
Resolution: fixed | Keywords: layer manager, multiselection
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Changes (by annakrat):

  * status: new => closed
  * resolution: => fixed

Comment:

Fix confirmed in [http://lists.osgeo.org/pipermail/grass-
dev/2012-September/059815.html], backported in r53070 and r53071 together
with changes related to ticket #1616.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1717#comment:8&gt;
GRASS GIS <http://grass.osgeo.org>

#1717: layer remove does not work on multiple selections
--------------------------+-------------------------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
Resolution: fixed | Keywords: layer manager, multiselection
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------

Comment(by cmbarton):

We are talking about the same thing. I put 3 maps in the layer manager,
select them all and click 'remove'. One is removed only. Click again and
it says that nothing is selected. Select 2 maps covering different
geographical areas and 'zoom to map'. It zooms to only one of the maps.
Create a group; select 3 maps and drag them to the group. Only one moves
to the group.

I am just getting around here in Arizona this morning and have to meet my
daughter for breakfast :slight_smile: because it is a holiday. I'll test once I get
back. Thanks much.

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1717#comment:9&gt;
GRASS GIS <http://grass.osgeo.org>

#1717: layer remove does not work on multiple selections
--------------------------+-------------------------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
Resolution: fixed | Keywords: layer manager, multiselection
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------

Comment(by cmbarton):

I can confirm that this DOES work in GRASS 7 now. Thanks much. One caveat,
however. If you select a raster and a vector and zoom to map(s), it will
only zoom to EITHER the raster OR the vector, not to the combined raster
and vector.

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1717#comment:10&gt;
GRASS GIS <http://grass.osgeo.org>

#1717: layer remove does not work on multiple selections
--------------------------+-------------------------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
Resolution: fixed | Keywords: layer manager, multiselection
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------

Comment(by annakrat):

It seems to me that the problem is in g.region. What is g.region supposed
to do with both parameters rast and vect?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1717#comment:11&gt;
GRASS GIS <http://grass.osgeo.org>

#1717: layer remove does not work on multiple selections
--------------------------+-------------------------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: normal | Milestone: 6.4.4
Component: wxGUI | Version: svn-releasebranch64
Resolution: fixed | Keywords: layer manager, multiselection
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------

Comment(by cmbarton):

good question. I think g.region used to expand to fit all maps of any
types, but I haven't tried it recently by itself recently.

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1717#comment:12&gt;
GRASS GIS <http://grass.osgeo.org>