[GRASS-dev] [GRASS GIS] #1785: r.param.scale module source code error ?

GRASS GIS GRASS GIS developer
1

#1785: r.param.scale module source code error ?
--------------------------------------+-------------------------------------
Reporter: jprigol | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.3
Component: Raster | Version: unspecified
Keywords: r.param.scale, feature.c | Platform: Unspecified
      Cpu: Unspecified |
--------------------------------------+-------------------------------------
Hi.

I've been looking trhough r.param.scale source code. The point is that I
was wondering if there was an error in file
http://trac.osgeo.org/grass/browser/grass/trunk/raster/r.param.scale/feature.c
The last "else if... (line 103)" includes two simultaneous conditions that
should (?) have opposite comparison operations (in addition, it never will
take place because the root "if" has the same condition), i.e.
"else if (minic < curve_tol && minic > -curve_tol) {"
Then, final "return (FLAT) (line 108)" will be useless (?).

Kind regards,
Juan

--
Atentamente,
Juan P. Rigol-Sánchez
Recursos Hídricos y Geología Ambiental
Dpto. Hidrogeología y Química Analítica
Universidad de Almería - España (Spain, EU)

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1785&gt;
GRASS GIS <http://grass.osgeo.org>

2

#1785: r.param.scale module source code error ?
--------------------------------------+-------------------------------------
Reporter: jprigol | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.4
Component: Raster | Version: svn-releasebranch64
Keywords: r.param.scale, feature.c | Platform: Unspecified
      Cpu: Unspecified |
--------------------------------------+-------------------------------------
Changes (by neteler):

  * version: unspecified => svn-releasebranch64
  * milestone: 6.4.3 => 6.4.4

Old description:

Hi.

I've been looking trhough r.param.scale source code. The point is that I
was wondering if there was an error in file
http://trac.osgeo.org/grass/browser/grass/trunk/raster/r.param.scale/feature.c
The last "else if... (line 103)" includes two simultaneous conditions
that should (?) have opposite comparison operations (in addition, it
never will take place because the root "if" has the same condition), i.e.
"else if (minic < curve_tol && minic > -curve_tol) {"
Then, final "return (FLAT) (line 108)" will be useless (?).

Kind regards,
Juan

--
Atentamente,
Juan P. Rigol-Sánchez
Recursos Hídricos y Geología Ambiental
Dpto. Hidrogeología y Química Analítica
Universidad de Almería - España (Spain, EU)

New description:

Hi.

I've been looking trhough r.param.scale source code. The point is that I
was wondering if there was an error in file
http://trac.osgeo.org/grass/browser/grass/trunk/raster/r.param.scale/feature.c

The last "else if... (line 103)" includes two simultaneous conditions that
should (?) have opposite comparison operations (in addition, it never will
take place because the root "if" has the same condition), i.e.

"else if (minic < curve_tol && minic > -curve_tol) {"

Then, final "return (FLAT) (line 108)" will be useless (?).

Kind regards,
Juan

--
Atentamente,
Juan P. Rigol-Sánchez
Recursos Hídricos y Geología Ambiental
Dpto. Hidrogeología y Química Analítica
Universidad de Almería - España (Spain, EU)

--

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1785#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>