[GRASS-dev] [GRASS GIS] #1813: RST lib quad_divide_data calls exit with 0

GRASS GIS GRASS GIS developer
1

#1813: RST lib quad_divide_data calls exit with 0
-------------------------+--------------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Raster | Version: svn-trunk
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
RST lib in quad_divide_data() calls exit with argument 0.

First - how a failure can be 0 (success)?

Second - #1598 This looks like one of those places, where G_fatal_error()
is more appropriate.

Third - this exit() prevents interpolation when data points are arranged
in a stripe (filling a hole between two map sheets). Is it really
necessary to EXIT here instead of just printing a warning?

http://trac.osgeo.org/grass/browser/grass/trunk/lib/rst/data/dataquad.c#L214

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1813&gt;
GRASS GIS <http://grass.osgeo.org>

2

#1813: RST lib quad_divide_data calls exit with 0
-------------------------+--------------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Raster | Version: svn-trunk
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by marisn):

Attached file contains a 3D shapefile with data stripe and hole in the
middle. The goal is to interpolate data from surrounding points to fill
the hole.

Unzip file, create a new location based on provided file. Remove imported
vector file and import it again this time with -z option (see bug #1822).

Set region and run interpolation:
{{{
g.region -a res=20
v.surf.rst -z input=interpolate_this layer=1 elev=filled_hole
}}}

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1813#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>