[GRASS-dev] [GRASS GIS] #1834: backport r47878 (set field width for string columns in v.out.ogr) to grass6 ?

#1834: backport r47878 (set field width for string columns in v.out.ogr) to grass6
?
-------------------------+--------------------------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.3
Component: Vector | Version: svn-releasebranch64
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Is there any reason that r47878 couldn't be backported to grass6 ? If not
then it would be a good idea to do so.

Moritz

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1834&gt;
GRASS GIS <http://grass.osgeo.org>

#1834: backport r47878 (set field width for string columns in v.out.ogr) to grass6
?
-------------------------+--------------------------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.3
Component: Vector | Version: svn-releasebranch64
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by neteler):

The real change seem to be these two lines:
{{{

         630 if (ogr_ftype == OFTString && colwidth >
0)
         631 OGR_Fld_SetWidth(Ogr_field,
colwidth);
}}}

I cannot see anything dangerous here.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1834#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#1834: backport r47878 (set field width for string columns in v.out.ogr) to grass6
?
-------------------------+--------------------------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.3
Component: Vector | Version: svn-releasebranch64
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by mlennert):

Replying to [comment:1 neteler]:
> The real change seem to be these two lines:
> {{{
>
> 630 if (ogr_ftype == OFTString && colwidth >
0)
> 631 OGR_Fld_SetWidth(Ogr_field,
colwidth);
> }}}
>
> I cannot see anything dangerous here.

The attached patch seems to do the job for me. Potential candidate for
bugfix in grass64 release, or is it too late ? I find this a quite
annoying bug.

Moritz

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1834#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#1834: backport r47878 (set field width for string columns in v.out.ogr) to grass6
?
--------------------------+-------------------------------------------------
  Reporter: mlennert | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 6.4.3
Component: Vector | Version: svn-releasebranch64
Resolution: fixed | Keywords:
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Changes (by neteler):

  * status: new => closed
  * resolution: => fixed

Comment:

Committed in r55575 and r55576. Closing.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1834#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>