{{{
19 ;Select if you are building a "Development Version" (Devel) or a
"Release Version" (Release) of the GRASS Installer
20
21 !define INSTALLER_TYPE "Devel"
}}}
Replying to [ticket:1940 hellik]:
> http://trac.osgeo.org/grass/browser/grass/branches/releasebranch_6_4/mswindows
/GRASS-Installer.nsi.tmpl#L19
>
{{{
> 19 ;Select if you are building a "Development Version" (Devel) or a
"Release Version" (Release) of the GRASS Installer
> 20
> 21 !define INSTALLER_TYPE "Devel"
}}}
The installer type should be not related to this ticket. At least I didn't
encountered any problem when building osgeo4w package source:grass-
addons/tools/wingrass-packager/grass_svn_info.sh#L34
replacement should be done automatically
(source:grass/branches/releasebranch_6_4/mswindows/Makefile#L22) when SVN
rev number is defined in
source:grass/branches/releasebranch_6_4/include/Make/Grass.make.in#L75. Do
you have `svnversion` in the path (when running `configure`)?
> replacement should be done automatically
(source:grass/branches/releasebranch_6_4/mswindows/Makefile#L22) when SVN
rev number is defined in
source:grass/branches/releasebranch_6_4/include/Make/Grass.make.in#L75. Do
you have `svnversion` in the path (when running `configure`)?
source code downloaded from SVN? If you use tarball, it will fail (missing
svn number).
Replying to [comment:4 martinl]:
> Replying to [comment:2 martinl]:
>
> > replacement should be done automatically
(source:grass/branches/releasebranch_6_4/mswindows/Makefile#L22) when SVN
rev number is defined in
source:grass/branches/releasebranch_6_4/include/Make/Grass.make.in#L75. Do
you have `svnversion` in the path (when running `configure`)?
>
> source code downloaded from SVN? If you use tarball, it will fail
(missing svn number).
just to note in the release tarball there are no .svn/ dirs present, so
svnversion (if installed) should just return "exported" to stdout.
I'm not sure what happens with 'svn export' of a branch, I assume the
same, but hellik reports using 'svn checkout', which should have .svn/
dirs, so something else is going on.
If there are things which need to be changed just before release, then
changed back just after, automatically-detecting is best but if that is
not possible please document what needs to be done in
src:doc/howto_release.txt.
Replying to [comment:7 hamish]:
> Hi,
>
> just to note in the release tarball there are no .svn/ dirs present, so
svnversion (if installed) should just return "exported" to stdout.
>
> I'm not sure what happens with 'svn export' of a branch, I assume the
same, but hellik reports using 'svn checkout', which should have .svn/
dirs, so something else is going on.
Replying to [comment:9 martinl]:
> Replying to [comment:6 hellik]:
> > Replying to [comment:2 martinl]:
> > > Do you have `svnversion` in the path (when running `configure`)?
>
> When you launch `configure` or better `package.sh` you should get (see
`package.log`)
>
> {{{
> checking for svnversion... /c/Subversion/svnversion
> }}}
>
> `include/Make/Grass` should contain
>
> {{{
> GRASS_VERSION_SVN = XXXXXX
> }}}
>
> In other words, try to check if `svnversion` is in the path when running
`package.sh`. (?)
Replying to [comment:10 hellik]:
> and in /c/Program Files/TortoiseSVN/bin: there is svnversion
>
> so it's seems it's in $PATH, but not found by configure
from the subject of this bug it seems the issue has to do with building an
official versioned release, not with a random svn snapshot build?
In that case the svn rev and thus svnversion are mostly irrelevant;
".svn/" metadata is not in the final tarball, and if a historian is
curious what svn rev the version refers to they can always look it up in
the tag's log. For versioned releases it already has an official version
number, so we know exactly which version of the codebase the user is
talking about- the point of including svn revs is to provide that info for
non-official-versioned checkouts.
of course the packaging script should handle all the variable setting (or
leaving blank) cleanly for you once you change the "Devel" keyword to
"Release"...
I'm not sure what the status of this one is, but it seems that building
the RC4 wingrass package will be a good opportunity to field test what
happens to the build when there is no .svn/ metadata in the tarball GRASS
is built from.
Replying to [comment:11 hamish]:
>
> from the subject of this bug it seems the issue has to do with building
an official versioned release, not with a random svn snapshot build?
>
> In that case the svn rev and thus svnversion are mostly irrelevant;
".svn/" metadata is not in the final tarball, and if a historian is
curious what svn rev the version refers to they can always look it up in
the tag's log.